| Message ID | 20210414083022.25453-2-me@fabwu.ch |
|---|---|
| State | Accepted |
| Commit | 6814a524857f2da9624dedbcac9659675406f441 |
| Headers | show |
| Series | [v3,1/2] ACPI: Add _PLD panel positions | expand |
Hi Erik, Do I need to add anything to this patch or is it fine like that? Thanks, Fabian On 14.04.21 15:50, Rafael J. Wysocki wrote: > On Wed, Apr 14, 2021 at 10:30 AM Fabian Wüthrich <me@fabwu.ch> wrote: >> >> The ACPI specification v6.3 defines the panel positions in chapter 6.1.8 >> "_PLD (Physical Location of Device)" >> >> Signed-off-by: Fabian Wüthrich <me@fabwu.ch> >> Reviewed-by: Daniel Scally <djrscally@gmail.com> >> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> > > This is ACPICA material. > > Erik, can you pick up this one, please? > >> --- >> include/acpi/acbuffer.h | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/include/acpi/acbuffer.h b/include/acpi/acbuffer.h >> index 18197c16149f..d42e82a82852 100644 >> --- a/include/acpi/acbuffer.h >> +++ b/include/acpi/acbuffer.h >> @@ -207,4 +207,13 @@ struct acpi_pld_info { >> #define ACPI_PLD_GET_HORIZ_OFFSET(dword) ACPI_GET_BITS (dword, 16, ACPI_16BIT_MASK) >> #define ACPI_PLD_SET_HORIZ_OFFSET(dword,value) ACPI_SET_BITS (dword, 16, ACPI_16BIT_MASK, value) /* Offset 128+16=144, Len 16 */ >> >> +/* Panel position defined in _PLD section of ACPI Specification 6.3 */ >> +#define ACPI_PLD_PANEL_TOP 0 >> +#define ACPI_PLD_PANEL_BOTTOM 1 >> +#define ACPI_PLD_PANEL_LEFT 2 >> +#define ACPI_PLD_PANEL_RIGHT 3 >> +#define ACPI_PLD_PANEL_FRONT 4 >> +#define ACPI_PLD_PANEL_BACK 5 >> +#define ACPI_PLD_PANEL_UNKNOWN 6 >> + >> #endif /* ACBUFFER_H */ >> -- >> 2.31.1 >>
> -----Original Message----- > From: Fabian Wüthrich <me@fabwu.ch> > Sent: Sunday, May 9, 2021 9:29 AM > To: Kaneda, Erik <erik.kaneda@intel.com> > Cc: Linux Media Mailing List <linux-media@vger.kernel.org>; ACPI Devel > Maling List <linux-acpi@vger.kernel.org>; open list:ACPI COMPONENT > ARCHITECTURE (ACPICA) <devel@acpica.org>; Jacopo Mondi > <jacopo@jmondi.org>; Zhi, Yong <yong.zhi@intel.com>; Sakari Ailus > <sakari.ailus@linux.intel.com>; Cao, Bingbu <bingbu.cao@intel.com>; Dan > Scally <djrscally@gmail.com>; Qiu, Tian Shu <tian.shu.qiu@intel.com>; > Mauro Carvalho Chehab <mchehab@kernel.org>; Moore, Robert > <robert.moore@intel.com>; Wysocki, Rafael J <rafael.j.wysocki@intel.com>; > Len Brown <lenb@kernel.org>; Andy Shevchenko > <andy.shevchenko@gmail.com>; Rafael J. Wysocki <rafael@kernel.org> > Subject: Re: [PATCH v3 1/2] ACPI: Add _PLD panel positions > > Hi Erik, > Hi Fabian, > Do I need to add anything to this patch or is it fine like that? Sorry about the late response. I submitted a pull request on your behalf for ACPICA upstream here: https://github.com/acpica/acpica/pull/689 I'll port it to Linux and circulate on this mailing list after ACPICA does a release (usually about once per month). Thanks, Erik > > Thanks, > Fabian > > On 14.04.21 15:50, Rafael J. Wysocki wrote: > > On Wed, Apr 14, 2021 at 10:30 AM Fabian Wüthrich <me@fabwu.ch> > wrote: > >> > >> The ACPI specification v6.3 defines the panel positions in chapter 6.1.8 > >> "_PLD (Physical Location of Device)" > >> > >> Signed-off-by: Fabian Wüthrich <me@fabwu.ch> > >> Reviewed-by: Daniel Scally <djrscally@gmail.com> > >> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> > > > > This is ACPICA material. > > > > Erik, can you pick up this one, please? > > > >> --- > >> include/acpi/acbuffer.h | 9 +++++++++ > >> 1 file changed, 9 insertions(+) > >> > >> diff --git a/include/acpi/acbuffer.h b/include/acpi/acbuffer.h > >> index 18197c16149f..d42e82a82852 100644 > >> --- a/include/acpi/acbuffer.h > >> +++ b/include/acpi/acbuffer.h > >> @@ -207,4 +207,13 @@ struct acpi_pld_info { > >> #define ACPI_PLD_GET_HORIZ_OFFSET(dword) ACPI_GET_BITS > (dword, 16, ACPI_16BIT_MASK) > >> #define ACPI_PLD_SET_HORIZ_OFFSET(dword,value) ACPI_SET_BITS > (dword, 16, ACPI_16BIT_MASK, value) /* Offset 128+16=144, Len 16 */ > >> > >> +/* Panel position defined in _PLD section of ACPI Specification 6.3 */ > >> +#define ACPI_PLD_PANEL_TOP 0 > >> +#define ACPI_PLD_PANEL_BOTTOM 1 > >> +#define ACPI_PLD_PANEL_LEFT 2 > >> +#define ACPI_PLD_PANEL_RIGHT 3 > >> +#define ACPI_PLD_PANEL_FRONT 4 > >> +#define ACPI_PLD_PANEL_BACK 5 > >> +#define ACPI_PLD_PANEL_UNKNOWN 6 > >> + > >> #endif /* ACBUFFER_H */ > >> -- > >> 2.31.1 > >>
diff --git a/include/acpi/acbuffer.h b/include/acpi/acbuffer.h index 18197c16149f..d42e82a82852 100644 --- a/include/acpi/acbuffer.h +++ b/include/acpi/acbuffer.h @@ -207,4 +207,13 @@ struct acpi_pld_info { #define ACPI_PLD_GET_HORIZ_OFFSET(dword) ACPI_GET_BITS (dword, 16, ACPI_16BIT_MASK) #define ACPI_PLD_SET_HORIZ_OFFSET(dword,value) ACPI_SET_BITS (dword, 16, ACPI_16BIT_MASK, value) /* Offset 128+16=144, Len 16 */ +/* Panel position defined in _PLD section of ACPI Specification 6.3 */ +#define ACPI_PLD_PANEL_TOP 0 +#define ACPI_PLD_PANEL_BOTTOM 1 +#define ACPI_PLD_PANEL_LEFT 2 +#define ACPI_PLD_PANEL_RIGHT 3 +#define ACPI_PLD_PANEL_FRONT 4 +#define ACPI_PLD_PANEL_BACK 5 +#define ACPI_PLD_PANEL_UNKNOWN 6 + #endif /* ACBUFFER_H */