diff mbox series

[v2,net-next,5/5] dt-bindings: net: dsa: Document dsa,tag-protocol property

Message ID 20210415092610.953134-6-tobias@waldekranz.com
State New
Headers show
Series net: dsa: Allow default tag protocol to be overridden from DT | expand

Commit Message

Tobias Waldekranz April 15, 2021, 9:26 a.m. UTC
The 'dsa,tag-protocol' is used to force a switch tree to use a
particular tag protocol, typically because the Ethernet controller
that it is connected to is not compatible with the default one.

Signed-off-by: Tobias Waldekranz <tobias@waldekranz.com>
---
 Documentation/devicetree/bindings/net/dsa/dsa.yaml | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Vladimir Oltean April 19, 2021, 6:55 p.m. UTC | #1
On Thu, Apr 15, 2021 at 04:27:58PM -0500, Rob Herring wrote:
> On Thu, Apr 15, 2021 at 11:26:10AM +0200, Tobias Waldekranz wrote:
> > The 'dsa,tag-protocol' is used to force a switch tree to use a
> > particular tag protocol, typically because the Ethernet controller
> > that it is connected to is not compatible with the default one.
> > 
> > Signed-off-by: Tobias Waldekranz <tobias@waldekranz.com>
> > ---
> >  Documentation/devicetree/bindings/net/dsa/dsa.yaml | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/net/dsa/dsa.yaml b/Documentation/devicetree/bindings/net/dsa/dsa.yaml
> > index 8a3494db4d8d..c4dec0654c6a 100644
> > --- a/Documentation/devicetree/bindings/net/dsa/dsa.yaml
> > +++ b/Documentation/devicetree/bindings/net/dsa/dsa.yaml
> > @@ -70,6 +70,15 @@ patternProperties:
> >                device is what the switch port is connected to
> >              $ref: /schemas/types.yaml#/definitions/phandle
> >  
> > +          dsa,tag-protocol:
> 
> 'dsa' is not a vendor. 'dsa-tag-protocol' instead.

Can confirm, DSA is not a vendor.
You can change to 'dsa-tag-protocol' if this makes acceptance any easier.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/net/dsa/dsa.yaml b/Documentation/devicetree/bindings/net/dsa/dsa.yaml
index 8a3494db4d8d..c4dec0654c6a 100644
--- a/Documentation/devicetree/bindings/net/dsa/dsa.yaml
+++ b/Documentation/devicetree/bindings/net/dsa/dsa.yaml
@@ -70,6 +70,15 @@  patternProperties:
               device is what the switch port is connected to
             $ref: /schemas/types.yaml#/definitions/phandle
 
+          dsa,tag-protocol:
+            description:
+              Instead of the default, the switch will use this tag protocol if
+              possible. Useful when a device supports multiple protcols and
+              the default is incompatible with the Ethernet device.
+            enum:
+              - dsa
+              - edsa
+
           phy-handle: true
 
           phy-mode: true