diff mbox series

[v3] tty: serial: samsung_tty: remove set but not used variables

Message ID 1619484575-26098-1-git-send-email-tiantao6@hisilicon.com
State Superseded
Headers show
Series [v3] tty: serial: samsung_tty: remove set but not used variables | expand

Commit Message

Tian Tao April 27, 2021, 12:49 a.m. UTC 
The value of 'ret' is not used which reported by svace, so just return
instead of break.

Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
v2: s3c24xx_serial_probe function exit than convert ret to some default
value when the attribute "reg-io-width" is not 1 or 4.

v3: Fix word spelling error in commit message.
---
 drivers/tty/serial/samsung_tty.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c
index d9e4b67..9fbc611 100644
--- a/drivers/tty/serial/samsung_tty.c
+++ b/drivers/tty/serial/samsung_tty.c
@@ -2220,8 +2220,7 @@  static int s3c24xx_serial_probe(struct platform_device *pdev)
 			default:
 				dev_warn(&pdev->dev, "unsupported reg-io-width (%d)\n",
 						prop);
-				ret = -EINVAL;
-				break;
+				return -EINVAL;
 			}
 		}
 	}