diff mbox series

[2/2] ARM: dts: imx6qdl-sabresd: Configure the gpio for hp detect

Message ID 1619664627-12470-2-git-send-email-shengjiu.wang@nxp.com
State Superseded
Headers show
Series [1/2] ARM: dts: imx6qdl-sabresd: Add asrc support for wm8962 sound card | expand

Commit Message

Shengjiu Wang April 29, 2021, 2:50 a.m. UTC 
Configure the gpio for hp detect for wm8962 sound card

Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>

---
 arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 9 +++++++++
 1 file changed, 9 insertions(+)

-- 
2.27.0

Comments

Fabio Estevam May 3, 2021, 2:38 p.m. UTC | #1 
Hi Shengjiu,

On Thu, Apr 29, 2021 at 12:06 AM Shengjiu Wang <shengjiu.wang@nxp.com> wrote:

> +               pinctrl_hp: hpgrp {

> +                       fsl,pins = <

> +                               MX6QDL_PAD_SD3_RST__GPIO7_IO08          0x80000000

> +                               MX6QDL_PAD_GPIO_9__GPIO1_IO09           0x80000000


Please avoid using 0x80000000. Use the real PAD_CTL value instead.
Shengjiu Wang May 6, 2021, 3:11 a.m. UTC | #2 
On Mon, May 3, 2021 at 10:38 PM Fabio Estevam <festevam@gmail.com> wrote:
>

> Hi Shengjiu,

>

> On Thu, Apr 29, 2021 at 12:06 AM Shengjiu Wang <shengjiu.wang@nxp.com> wrote:

>

> > +               pinctrl_hp: hpgrp {

> > +                       fsl,pins = <

> > +                               MX6QDL_PAD_SD3_RST__GPIO7_IO08          0x80000000

> > +                               MX6QDL_PAD_GPIO_9__GPIO1_IO09           0x80000000

>

> Please avoid using 0x80000000. Use the real PAD_CTL value instead.


Ok, will send v2.

best regards
wang shengjiu
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
index d20eaac6c5d6..4728dc612912 100644
--- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
@@ -97,6 +97,8 @@  sound {
 		compatible = "fsl,imx6q-sabresd-wm8962",
 			   "fsl,imx-audio-wm8962";
 		model = "wm8962-audio";
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_hp>;
 		ssi-controller = <&ssi2>;
 		audio-codec = <&codec>;
 		audio-asrc = <&asrc>;
@@ -546,6 +548,13 @@  MX6QDL_PAD_KEY_ROW2__HDMI_TX_CEC_LINE	0x1f8b0
 			>;
 		};
 
+		pinctrl_hp: hpgrp {
+			fsl,pins = <
+				MX6QDL_PAD_SD3_RST__GPIO7_IO08          0x80000000
+				MX6QDL_PAD_GPIO_9__GPIO1_IO09           0x80000000
+			>;
+		};
+
 		pinctrl_i2c1: i2c1grp {
 			fsl,pins = <
 				MX6QDL_PAD_CSI0_DAT8__I2C1_SDA		0x4001b8b1