From patchwork Sun Jan 18 02:04:23 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Poirier X-Patchwork-Id: 43267 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ee0-f70.google.com (mail-ee0-f70.google.com [74.125.83.70]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 44406240E9 for ; Sun, 18 Jan 2015 02:05:22 +0000 (UTC) Received: by mail-ee0-f70.google.com with SMTP id c13sf173999eek.1 for ; Sat, 17 Jan 2015 18:05:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=MQwm8xnQF1dX7Y9zfH/R9LKJwkHsuT/Au2OqCSof7ow=; b=EY7YPIaWhAnzDSK2BxbD47s3lJa9CTNzI+0geTettc2y2S7OpR80ljrxPdjytOdh70 Rcuz0OqDoN1M55vmcDrKn+sqlqpAL6QmqsH9Hb/zLlEPUraQVc6n1K41og4k8kICPUJH ORUDii6fY30JD9rb9k6C5qgQab8Z9ZxAaKZCC2Y0s7gzt/Pc7GXk4lXfGpR3PVVu9HCG qsgbneAhISF3e6YtghFiMMRLkEalUpPcnOYvopRBIt0DPnQmy/mwZpyB0U2Wfw7LLDQe nach67ZEyF4rzij3dZR1uYGBB1rasSTgZB0roHCeS3sRCRAoKKAXgFQgWzaHDMipjHJ7 pZQw== X-Gm-Message-State: ALoCoQn910tfcZwbQ1mGW64QAsSebmrcAaAzQtZt6+SgF4DM45cNOfhsEUgmhsI1+JrfBDEdsPxx X-Received: by 10.194.77.1 with SMTP id o1mr2794254wjw.1.1421546720961; Sat, 17 Jan 2015 18:05:20 -0800 (PST) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.37.104 with SMTP id x8ls508680laj.4.gmail; Sat, 17 Jan 2015 18:05:20 -0800 (PST) X-Received: by 10.112.185.101 with SMTP id fb5mr23018144lbc.12.1421546720505; Sat, 17 Jan 2015 18:05:20 -0800 (PST) Received: from mail-la0-f51.google.com (mail-la0-f51.google.com. [209.85.215.51]) by mx.google.com with ESMTPS id dv9si6979511lbc.63.2015.01.17.18.05.20 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 17 Jan 2015 18:05:20 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.51 as permitted sender) client-ip=209.85.215.51; Received: by mail-la0-f51.google.com with SMTP id ge10so3180962lab.10 for ; Sat, 17 Jan 2015 18:05:20 -0800 (PST) X-Received: by 10.112.170.36 with SMTP id aj4mr22776418lbc.3.1421546720360; Sat, 17 Jan 2015 18:05:20 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.9.200 with SMTP id c8csp716244lbb; Sat, 17 Jan 2015 18:05:19 -0800 (PST) X-Received: by 10.68.110.161 with SMTP id ib1mr34271597pbb.36.1421546718129; Sat, 17 Jan 2015 18:05:18 -0800 (PST) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ki10si10951154pdb.1.2015.01.17.18.05.17; Sat, 17 Jan 2015 18:05:18 -0800 (PST) Received-SPF: none (google.com: linux-kernel-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752085AbbARCFC (ORCPT + 28 others); Sat, 17 Jan 2015 21:05:02 -0500 Received: from mail-pd0-f180.google.com ([209.85.192.180]:43257 "EHLO mail-pd0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751689AbbARCE4 (ORCPT ); Sat, 17 Jan 2015 21:04:56 -0500 Received: by mail-pd0-f180.google.com with SMTP id ft15so603512pdb.11 for ; Sat, 17 Jan 2015 18:04:55 -0800 (PST) X-Received: by 10.68.211.7 with SMTP id my7mr34384539pbc.115.1421546695535; Sat, 17 Jan 2015 18:04:55 -0800 (PST) Received: from t430.cg.shawcable.net (S0106002369de4dac.cg.shawcable.net. [70.73.24.112]) by mx.google.com with ESMTPSA id zk9sm7852666pac.1.2015.01.17.18.04.54 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 17 Jan 2015 18:04:54 -0800 (PST) From: mathieu.poirier@linaro.org To: forest@alittletooquiet.net, gregkh@linuxfoundation.org Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, mathieu.poirier@linaro.org Subject: [PATCH 1/4] staging: vt6655: correcting function declaration sparse error Date: Sat, 17 Jan 2015 19:04:23 -0700 Message-Id: <1421546666-21461-2-git-send-email-mathieu.poirier@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1421546666-21461-1-git-send-email-mathieu.poirier@linaro.org> References: <1421546666-21461-1-git-send-email-mathieu.poirier@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: mathieu.poirier@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.51 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , From: Mathieu Poirier mpoirier@t430:~/work/kernel1$ make C=1 M=drivers/staging/vt6655/ LD drivers/staging/vt6655/built-in.o CHECK drivers/staging/vt6655/device_main.c drivers/staging/vt6655/device_main.c:1672:5: warning: symbol 'vnt_init' was not declared. Should it be static? CC [M] drivers/staging/vt6655/device_main.o Function @vnt_init is only called by @vt6655_probe, in turn is declared "static". As sparse suggest, @vnt_init should very likely be declared static as well. At least nothing in the file indicate that it should be otherwise. Signed-off-by: Mathieu Poirier --- drivers/staging/vt6655/device_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c index 83e4162c0094..a3f5cd84259a 100644 --- a/drivers/staging/vt6655/device_main.c +++ b/drivers/staging/vt6655/device_main.c @@ -1669,7 +1669,7 @@ static const struct ieee80211_ops vnt_mac_ops = { .reset_tsf = vnt_reset_tsf, }; -int vnt_init(struct vnt_private *priv) +static int vnt_init(struct vnt_private *priv) { SET_IEEE80211_PERM_ADDR(priv->hw, priv->abyCurrentNetAddr);