diff mbox series

arm64: dts: qcom: sm8350: fix the node unit addresses

Message ID 20210510070532.3838598-1-vkoul@kernel.org
State New
Headers show
Series arm64: dts: qcom: sm8350: fix the node unit addresses | expand

Commit Message

Vinod Koul May 10, 2021, 7:05 a.m. UTC
Some node unit addresses were put wrongly in the dts, resulting in
below warning when run with W=1

arch/arm64/boot/dts/qcom/sm8350.dtsi:693.34-702.5: Warning (simple_bus_reg): /soc@0/thermal-sensor@c222000: simple-bus unit address format error, expected "c263000"
arch/arm64/boot/dts/qcom/sm8350.dtsi:704.34-713.5: Warning (simple_bus_reg): /soc@0/thermal-sensor@c223000: simple-bus unit address format error, expected "c265000"
arch/arm64/boot/dts/qcom/sm8350.dtsi:1180.32-1185.5: Warning (simple_bus_reg): /soc@0/interconnect@90e0000: simple-bus unit address format error, expected "90c0000"

Fix by correcting to the correct address as given in reg node

Signed-off-by: Vinod Koul <vkoul@kernel.org>

---
 arch/arm64/boot/dts/qcom/sm8350.dtsi | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

-- 
2.26.3

Comments

Robert Foss May 10, 2021, 8:31 a.m. UTC | #1
Hey Vinod,

Thanks for catching this.

On Mon, 10 May 2021 at 09:05, Vinod Koul <vkoul@kernel.org> wrote:
>

> Some node unit addresses were put wrongly in the dts, resulting in

> below warning when run with W=1

>

> arch/arm64/boot/dts/qcom/sm8350.dtsi:693.34-702.5: Warning (simple_bus_reg): /soc@0/thermal-sensor@c222000: simple-bus unit address format error, expected "c263000"

> arch/arm64/boot/dts/qcom/sm8350.dtsi:704.34-713.5: Warning (simple_bus_reg): /soc@0/thermal-sensor@c223000: simple-bus unit address format error, expected "c265000"

> arch/arm64/boot/dts/qcom/sm8350.dtsi:1180.32-1185.5: Warning (simple_bus_reg): /soc@0/interconnect@90e0000: simple-bus unit address format error, expected "90c0000"

>

> Fix by correcting to the correct address as given in reg node

>

> Signed-off-by: Vinod Koul <vkoul@kernel.org>

> ---

>  arch/arm64/boot/dts/qcom/sm8350.dtsi | 7 ++++---

>  1 file changed, 4 insertions(+), 3 deletions(-)

>

> diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi

> index a8cd224a2f31..d015a9ca95a5 100644

> --- a/arch/arm64/boot/dts/qcom/sm8350.dtsi

> +++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi

> @@ -6,6 +6,7 @@

>  #include <dt-bindings/interrupt-controller/arm-gic.h>

>  #include <dt-bindings/clock/qcom,gcc-sm8350.h>

>  #include <dt-bindings/clock/qcom,rpmh.h>

> +#include <dt-bindings/interconnect/qcom,sm8350.h>

>  #include <dt-bindings/mailbox/qcom-ipcc.h>

>  #include <dt-bindings/power/qcom-aoss-qmp.h>

>  #include <dt-bindings/power/qcom-rpmpd.h>

> @@ -689,7 +690,7 @@ pdc: interrupt-controller@b220000 {

>                         interrupt-controller;

>                 };

>

> -               tsens0: thermal-sensor@c222000 {

> +               tsens0: thermal-sensor@c263000 {

>                         compatible = "qcom,sm8350-tsens", "qcom,tsens-v2";

>                         reg = <0 0x0c263000 0 0x1ff>, /* TM */

>                               <0 0x0c222000 0 0x8>; /* SROT */

> @@ -700,7 +701,7 @@ tsens0: thermal-sensor@c222000 {

>                         #thermal-sensor-cells = <1>;

>                 };

>

> -               tsens1: thermal-sensor@c223000 {

> +               tsens1: thermal-sensor@c265000 {

>                         compatible = "qcom,sm8350-tsens", "qcom,tsens-v2";

>                         reg = <0 0x0c265000 0 0x1ff>, /* TM */

>                               <0 0x0c223000 0 0x8>; /* SROT */

> @@ -1176,7 +1177,7 @@ usb_2_ssphy: phy@88ebe00 {

>                         };

>                 };

>

> -               dc_noc: interconnect@90e0000 {

> +               dc_noc: interconnect@90c0000 {

>                         compatible = "qcom,sm8350-dc-noc";

>                         reg = <0 0x090c0000 0 0x4200>;

>                         #interconnect-cells = <1>;


Reviewed-by: Robert Foss <robert.foss@linaro.org>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi
index a8cd224a2f31..d015a9ca95a5 100644
--- a/arch/arm64/boot/dts/qcom/sm8350.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi
@@ -6,6 +6,7 @@ 
 #include <dt-bindings/interrupt-controller/arm-gic.h>
 #include <dt-bindings/clock/qcom,gcc-sm8350.h>
 #include <dt-bindings/clock/qcom,rpmh.h>
+#include <dt-bindings/interconnect/qcom,sm8350.h>
 #include <dt-bindings/mailbox/qcom-ipcc.h>
 #include <dt-bindings/power/qcom-aoss-qmp.h>
 #include <dt-bindings/power/qcom-rpmpd.h>
@@ -689,7 +690,7 @@  pdc: interrupt-controller@b220000 {
 			interrupt-controller;
 		};
 
-		tsens0: thermal-sensor@c222000 {
+		tsens0: thermal-sensor@c263000 {
 			compatible = "qcom,sm8350-tsens", "qcom,tsens-v2";
 			reg = <0 0x0c263000 0 0x1ff>, /* TM */
 			      <0 0x0c222000 0 0x8>; /* SROT */
@@ -700,7 +701,7 @@  tsens0: thermal-sensor@c222000 {
 			#thermal-sensor-cells = <1>;
 		};
 
-		tsens1: thermal-sensor@c223000 {
+		tsens1: thermal-sensor@c265000 {
 			compatible = "qcom,sm8350-tsens", "qcom,tsens-v2";
 			reg = <0 0x0c265000 0 0x1ff>, /* TM */
 			      <0 0x0c223000 0 0x8>; /* SROT */
@@ -1176,7 +1177,7 @@  usb_2_ssphy: phy@88ebe00 {
 			};
 		};
 
-		dc_noc: interconnect@90e0000 {
+		dc_noc: interconnect@90c0000 {
 			compatible = "qcom,sm8350-dc-noc";
 			reg = <0 0x090c0000 0 0x4200>;
 			#interconnect-cells = <1>;