| Message ID | 20110308110904.23531.66727.stgit@otae.warmcat.com |
|---|---|
| State | New |
| Headers | show |
On Tue, Mar 8, 2011 at 4:39 PM, Andy Green <andy@warmcat.com> wrote: > +/* struct omap_i2c_bus_platform_data .flags meanings */ > + > +#define OMAP_I2C_FLAG_NO_FIFO 1 > Hi, Minor comment, Can you use BIT(0) for 1, BIT(1) for 2 ... BIT (8) for 0x100 +#define OMAP_I2C_FLAG_SIMPLE_CLOCK 2 > +#define OMAP_I2C_FLAG_16BIT_DATA_REG 4 > +#define OMAP_I2C_FLAG_RESET_REGS_POSTIDLE 8 > +#define OMAP_I2C_FLAG_APPLY_ERRATA_I207 0x10 > +#define OMAP_I2C_FLAG_ALWAYS_ARMXOR_CLK 0x20 > +#define OMAP_I2C_FLAG_FORCE_19200_INT_CLK 0x40 > +/* how the CPU address bus must be translated for I2C unit access */ > +#define OMAP_I2C_FLAG_BUS_SHIFT_NONE 0 > +#define OMAP_I2C_FLAG_BUS_SHIFT_1 0x80 > +#define OMAP_I2C_FLAG_BUS_SHIFT_2 0x100 > +#define OMAP_I2C_FLAG_BUS_SHIFT__SHIFT 7 > + > struct omap_i2c_bus_platform_data { > u32 clkrate; > u32 rev; > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
On Tue, Mar 8, 2011 at 4:39 PM, Andy Green <andy@warmcat.com> wrote: > +/* struct omap_i2c_bus_platform_data .flags meanings */ > + > +#define OMAP_I2C_FLAG_NO_FIFO 1 Hi, Minor comment, Can you use BIT(0) for 1, BIT(1) for 2 ... BIT (8) for 0x100 > +#define OMAP_I2C_FLAG_SIMPLE_CLOCK 2 > +#define OMAP_I2C_FLAG_16BIT_DATA_REG 4 > +#define OMAP_I2C_FLAG_RESET_REGS_POSTIDLE 8 > +#define OMAP_I2C_FLAG_APPLY_ERRATA_I207 0x10 > +#define OMAP_I2C_FLAG_ALWAYS_ARMXOR_CLK 0x20
On 03/09/2011 02:31 PM, Somebody in the thread at some point said: Hi - > Minor comment, Can you use > BIT(0) for 1, BIT(1) for 2 ... BIT (8) for 0x100 OK, I agree it will be nicer. Thanks for the comment. I guess I can just change this and issue just this guy as try 3 rather than sending the whole series mostly unchanged. In that case, I'll take care of Benoit's member re-ordering to match the scripts at the same time and issue that guy as try 3 as well. -Andy
On 3/9/2011 4:18 PM, Andy Green wrote: > On 03/09/2011 02:31 PM, Somebody in the thread at some point said: > > Hi - > >> Minor comment, Can you use >> BIT(0) for 1, BIT(1) for 2 ... BIT (8) for 0x100 > > OK, I agree it will be nicer. Thanks for the comment. > > I guess I can just change this and issue just this guy as try 3 rather > than sending the whole series mostly unchanged. In that case, I'll take > care of Benoit's member re-ordering to match the scripts at the same > time and issue that guy as try 3 as well. It is up to Ben, but maybe it will be less confusing to re-send the whole series, since you have at least two patches to update. Maybe, just wait a little bit in case someone else has something to say about this series. Benoit
diff --git a/include/linux/i2c-omap.h b/include/linux/i2c-omap.h index 776c8e1..98ae49b 100644 --- a/include/linux/i2c-omap.h +++ b/include/linux/i2c-omap.h @@ -15,6 +15,21 @@ #define OMAP_I2C_IP_VERSION_1 1 #define OMAP_I2C_IP_VERSION_2 2 +/* struct omap_i2c_bus_platform_data .flags meanings */ + +#define OMAP_I2C_FLAG_NO_FIFO 1 +#define OMAP_I2C_FLAG_SIMPLE_CLOCK 2 +#define OMAP_I2C_FLAG_16BIT_DATA_REG 4 +#define OMAP_I2C_FLAG_RESET_REGS_POSTIDLE 8 +#define OMAP_I2C_FLAG_APPLY_ERRATA_I207 0x10 +#define OMAP_I2C_FLAG_ALWAYS_ARMXOR_CLK 0x20 +#define OMAP_I2C_FLAG_FORCE_19200_INT_CLK 0x40 +/* how the CPU address bus must be translated for I2C unit access */ +#define OMAP_I2C_FLAG_BUS_SHIFT_NONE 0 +#define OMAP_I2C_FLAG_BUS_SHIFT_1 0x80 +#define OMAP_I2C_FLAG_BUS_SHIFT_2 0x100 +#define OMAP_I2C_FLAG_BUS_SHIFT__SHIFT 7 + struct omap_i2c_bus_platform_data { u32 clkrate; u32 rev;
These represent the 8 kinds of implementation functionality that up until now were inferred by the 16 remaining cpu_...() tests in the omap i2c driver. Cc: patches@linaro.org Cc: Ben Dooks <ben-linux@fluff.org> Reported-by: Peter Maydell <peter.maydell@linaro.org> Signed-off-by: Andy Green <andy.green@linaro.org> --- include/linux/i2c-omap.h | 15 +++++++++++++++ 1 files changed, 15 insertions(+), 0 deletions(-)