| Message ID | 20210511093329.4670-1-thunder.leizhen@huawei.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/1] mmc: jz4740: Remove redundant error printing in jz4740_mmc_probe() | expand |
On Tue, 11 May 2021 at 11:33, Zhen Lei <thunder.leizhen@huawei.com> wrote: > > When devm_ioremap_resource() fails, a clear enough error message will be > printed by its subfunction __devm_ioremap_resource(). The error > information contains the device name, failure cause, and possibly resource > information. > > Therefore, remove the error printing here to simplify code and reduce the > binary size. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> Applied for next, thanks! Kind regards Uffe > --- > drivers/mmc/host/jz4740_mmc.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/mmc/host/jz4740_mmc.c b/drivers/mmc/host/jz4740_mmc.c > index b3c636edbb4610d..861ff6d9661a908 100644 > --- a/drivers/mmc/host/jz4740_mmc.c > +++ b/drivers/mmc/host/jz4740_mmc.c > @@ -1013,7 +1013,6 @@ static int jz4740_mmc_probe(struct platform_device* pdev) > host->base = devm_ioremap_resource(&pdev->dev, host->mem_res); > if (IS_ERR(host->base)) { > ret = PTR_ERR(host->base); > - dev_err(&pdev->dev, "Failed to ioremap base memory\n"); > goto err_free_host; > } > > -- > 2.26.0.106.g9fadedd > >
diff --git a/drivers/mmc/host/jz4740_mmc.c b/drivers/mmc/host/jz4740_mmc.c index b3c636edbb4610d..861ff6d9661a908 100644 --- a/drivers/mmc/host/jz4740_mmc.c +++ b/drivers/mmc/host/jz4740_mmc.c @@ -1013,7 +1013,6 @@ static int jz4740_mmc_probe(struct platform_device* pdev) host->base = devm_ioremap_resource(&pdev->dev, host->mem_res); if (IS_ERR(host->base)) { ret = PTR_ERR(host->base); - dev_err(&pdev->dev, "Failed to ioremap base memory\n"); goto err_free_host; }
When devm_ioremap_resource() fails, a clear enough error message will be printed by its subfunction __devm_ioremap_resource(). The error information contains the device name, failure cause, and possibly resource information. Therefore, remove the error printing here to simplify code and reduce the binary size. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> --- drivers/mmc/host/jz4740_mmc.c | 1 - 1 file changed, 1 deletion(-) -- 2.26.0.106.g9fadedd