diff mbox

test: makefile: remove check_PROGRAMS

Message ID 1422044748-14970-1-git-send-email-mike.holmes@linaro.org
State Accepted
Commit 30b60c59ccf88fc04401c772862ca4770cd6d900
Headers show

Commit Message

Mike Holmes Jan. 23, 2015, 8:25 p.m. UTC
check_PROGRAMS is used to list programs needed by the tests, it should
not list the tests themselves.

Signed-off-by: Mike Holmes <mike.holmes@linaro.org>
---
 test/performance/Makefile.am | 1 -
 test/validation/Makefile.am  | 1 -
 2 files changed, 2 deletions(-)

Comments

Anders Roxell Jan. 27, 2015, 9:38 a.m. UTC | #1
On 2015-01-23 15:25, Mike Holmes wrote:
> check_PROGRAMS is used to list programs needed by the tests, it should
> not list the tests themselves.
> 
> Signed-off-by: Mike Holmes <mike.holmes@linaro.org>

Reviewed-by: Anders Roxell <anders.roxell@linaro.org>

> ---
>  test/performance/Makefile.am | 1 -
>  test/validation/Makefile.am  | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/test/performance/Makefile.am b/test/performance/Makefile.am
> index 8b2e0e2..4378268 100644
> --- a/test/performance/Makefile.am
> +++ b/test/performance/Makefile.am
> @@ -2,7 +2,6 @@ include $(top_srcdir)/test/Makefile.inc
>  
>  if test_perf
>  TESTS = odp_scheduling
> -check_PROGRAMS = ${bin_PROGRAMS}
>  endif
>  
>  bin_PROGRAMS = odp_scheduling
> diff --git a/test/validation/Makefile.am b/test/validation/Makefile.am
> index 0f5799c..be896c7 100644
> --- a/test/validation/Makefile.am
> +++ b/test/validation/Makefile.am
> @@ -7,7 +7,6 @@ TESTS_ENVIRONMENT = ODP_PLATFORM=${with_platform}
>  
>  if test_vald
>  TESTS = odp_init odp_queue odp_crypto odp_shm odp_schedule odp_pktio_run odp_buffer odp_system odp_timer odp_time odp_synchronizers
> -check_PROGRAMS = ${bin_PROGRAMS}
>  endif
>  
>  bin_PROGRAMS = odp_init odp_queue odp_crypto odp_shm odp_schedule odp_pktio odp_buffer odp_system odp_timer odp_time odp_synchronizers
> -- 
> 2.1.0
> 
> 
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> http://lists.linaro.org/mailman/listinfo/lng-odp
Maxim Uvarov Jan. 27, 2015, 5:18 p.m. UTC | #2
Merged that.

Maxim.

On 01/27/2015 12:38 PM, Anders Roxell wrote:
> On 2015-01-23 15:25, Mike Holmes wrote:
>> check_PROGRAMS is used to list programs needed by the tests, it should
>> not list the tests themselves.
>>
>> Signed-off-by: Mike Holmes <mike.holmes@linaro.org>
> Reviewed-by: Anders Roxell <anders.roxell@linaro.org>
>
>> ---
>>   test/performance/Makefile.am | 1 -
>>   test/validation/Makefile.am  | 1 -
>>   2 files changed, 2 deletions(-)
>>
>> diff --git a/test/performance/Makefile.am b/test/performance/Makefile.am
>> index 8b2e0e2..4378268 100644
>> --- a/test/performance/Makefile.am
>> +++ b/test/performance/Makefile.am
>> @@ -2,7 +2,6 @@ include $(top_srcdir)/test/Makefile.inc
>>   
>>   if test_perf
>>   TESTS = odp_scheduling
>> -check_PROGRAMS = ${bin_PROGRAMS}
>>   endif
>>   
>>   bin_PROGRAMS = odp_scheduling
>> diff --git a/test/validation/Makefile.am b/test/validation/Makefile.am
>> index 0f5799c..be896c7 100644
>> --- a/test/validation/Makefile.am
>> +++ b/test/validation/Makefile.am
>> @@ -7,7 +7,6 @@ TESTS_ENVIRONMENT = ODP_PLATFORM=${with_platform}
>>   
>>   if test_vald
>>   TESTS = odp_init odp_queue odp_crypto odp_shm odp_schedule odp_pktio_run odp_buffer odp_system odp_timer odp_time odp_synchronizers
>> -check_PROGRAMS = ${bin_PROGRAMS}
>>   endif
>>   
>>   bin_PROGRAMS = odp_init odp_queue odp_crypto odp_shm odp_schedule odp_pktio odp_buffer odp_system odp_timer odp_time odp_synchronizers
>> -- 
>> 2.1.0
>>
>>
>> _______________________________________________
>> lng-odp mailing list
>> lng-odp@lists.linaro.org
>> http://lists.linaro.org/mailman/listinfo/lng-odp
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> http://lists.linaro.org/mailman/listinfo/lng-odp
diff mbox

Patch

diff --git a/test/performance/Makefile.am b/test/performance/Makefile.am
index 8b2e0e2..4378268 100644
--- a/test/performance/Makefile.am
+++ b/test/performance/Makefile.am
@@ -2,7 +2,6 @@  include $(top_srcdir)/test/Makefile.inc
 
 if test_perf
 TESTS = odp_scheduling
-check_PROGRAMS = ${bin_PROGRAMS}
 endif
 
 bin_PROGRAMS = odp_scheduling
diff --git a/test/validation/Makefile.am b/test/validation/Makefile.am
index 0f5799c..be896c7 100644
--- a/test/validation/Makefile.am
+++ b/test/validation/Makefile.am
@@ -7,7 +7,6 @@  TESTS_ENVIRONMENT = ODP_PLATFORM=${with_platform}
 
 if test_vald
 TESTS = odp_init odp_queue odp_crypto odp_shm odp_schedule odp_pktio_run odp_buffer odp_system odp_timer odp_time odp_synchronizers
-check_PROGRAMS = ${bin_PROGRAMS}
 endif
 
 bin_PROGRAMS = odp_init odp_queue odp_crypto odp_shm odp_schedule odp_pktio odp_buffer odp_system odp_timer odp_time odp_synchronizers