From patchwork Wed Jan 28 18:33:59 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leif Lindholm X-Patchwork-Id: 43883 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-lb0-f199.google.com (mail-lb0-f199.google.com [209.85.217.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 0D5102410D for ; Wed, 28 Jan 2015 18:34:16 +0000 (UTC) Received: by mail-lb0-f199.google.com with SMTP id f15sf11961775lbj.2 for ; Wed, 28 Jan 2015 10:34:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:date:from:to:subject:message-id :mime-version:content-disposition:user-agent:precedence:reply-to :list-id:list-unsubscribe:list-archive:list-post:list-help :list-subscribe:content-type:content-transfer-encoding:errors-to :sender:x-original-sender:x-original-authentication-results :mailing-list; bh=X4gc70MOkCd2zqzXq8x8Q1Wy5W1yIOIrxS9taEepgDI=; b=ERpccubVwSsGTlrC6CLuPbDKQePs4Fz34kx94Q3tpHpYjOqKbPO5JqI2owX4ND5K8I q5ynRgsMuGBdwKSbc1UyM0aLKEhxgTaPtQW/qa55PfuN0qgTe1y3pBjDqllB3q+EHGC3 TjWmEVy5Mz0r4mQCICDF1U3aJTyQkp+jiFaSYJjmdqoS5xe2C3ATlzHg+ENLuHzVUd2g TYr+Pfa2w8ZFEhc4Sqjjn1+YvP+tRUc30NVNJrOi6rTTHRmccAumDFMYFaOaAoket/f5 CbRJFOjXlHw8EYlLTpNP9tFrPQA5XczGEYOLmJFo7jelhUqY49n2sUoxkJWOVHAEj2bW x/wA== X-Gm-Message-State: ALoCoQlCOT7CX8fFIVCkOjFifXs3i+pKljndfazs72Uh0kdaSP5Ou+jy9kLJ/aPM2s6e13EbfuyD X-Received: by 10.194.142.174 with SMTP id rx14mr705419wjb.4.1422470054909; Wed, 28 Jan 2015 10:34:14 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.37.137 with SMTP id y9ls234623laj.59.gmail; Wed, 28 Jan 2015 10:34:14 -0800 (PST) X-Received: by 10.112.235.67 with SMTP id uk3mr10192112lbc.48.1422470054746; Wed, 28 Jan 2015 10:34:14 -0800 (PST) Received: from mail-la0-f46.google.com (mail-la0-f46.google.com. [209.85.215.46]) by mx.google.com with ESMTPS id oi2si5166576lbb.125.2015.01.28.10.34.14 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 28 Jan 2015 10:34:14 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.46 as permitted sender) client-ip=209.85.215.46; Received: by mail-la0-f46.google.com with SMTP id s18so20746910lam.5 for ; Wed, 28 Jan 2015 10:34:14 -0800 (PST) X-Received: by 10.152.6.132 with SMTP id b4mr10240650laa.59.1422470054594; Wed, 28 Jan 2015 10:34:14 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.35.133 with SMTP id h5csp1527825lbj; Wed, 28 Jan 2015 10:34:13 -0800 (PST) X-Received: by 10.224.79.82 with SMTP id o18mr15828196qak.3.1422470053109; Wed, 28 Jan 2015 10:34:13 -0800 (PST) Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id 61si7061481qgx.12.2015.01.28.10.34.12 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Wed, 28 Jan 2015 10:34:13 -0800 (PST) Received-SPF: pass (google.com: domain of grub-devel-bounces+patch=linaro.org@gnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Received: from localhost ([::1]:55357 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGXRM-0005uu-4Z for patch@linaro.org; Wed, 28 Jan 2015 13:34:12 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35169) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGXRG-0005uD-Rh for grub-devel@gnu.org; Wed, 28 Jan 2015 13:34:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YGXRD-0006wR-G2 for grub-devel@gnu.org; Wed, 28 Jan 2015 13:34:06 -0500 Received: from mail-wg0-f49.google.com ([74.125.82.49]:42482) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGXRD-0006wI-Af for grub-devel@gnu.org; Wed, 28 Jan 2015 13:34:03 -0500 Received: by mail-wg0-f49.google.com with SMTP id k14so22253760wgh.8 for ; Wed, 28 Jan 2015 10:34:02 -0800 (PST) X-Received: by 10.194.187.235 with SMTP id fv11mr10461935wjc.16.1422470042360; Wed, 28 Jan 2015 10:34:02 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by mx.google.com with ESMTPSA id mz10sm3893354wic.9.2015.01.28.10.34.01 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 28 Jan 2015 10:34:01 -0800 (PST) Date: Wed, 28 Jan 2015 18:33:59 +0000 From: Leif Lindholm To: grub-devel@gnu.org Subject: commit 3661261f breaks arm64 Message-ID: <20150128183359.GG4278@bivouac.eciton.net> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 74.125.82.49 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Errors-To: grub-devel-bounces+patch=linaro.org@gnu.org Sender: grub-devel-bounces+patch=linaro.org@gnu.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: leif.lindholm@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.46 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 commit 3661261fe17a8fe19681073889b5b36ec1ee823d, "Always add -msoft-float to avoid compiler generating float arithmetics." breaks the arm64 build. -msoft-float is not a valid command line option for aarch64 (as far as I can see, it is technically a target-specific option which just happens to exist for most targets - including arm). This setting will need to be conditionalised somehow. An option that works for arm64 is -march=armv8-a+nofp+nosimd. Would something like this be an acceptable workaround?: # By default, GCC 4.4 generates .eh_frame sections containing unwind # information in some cases where it previously did not. GRUB doesn't # need / Leif diff --git a/configure.ac b/configure.ac index a3bca06..c99e1ea 100644 --- a/configure.ac +++ b/configure.ac @@ -678,7 +678,11 @@ fi # that floats are a good fit to run instead of what's written in the # code. # Given that floating point unit is disabled (if present to begin # with) # when GRUB is running which may result in various hard crashes. -TARGET_CFLAGS="$TARGET_CFLAGS -msoft-float" +if ( test "x$target_cpu" = xarm64 ); then + TARGET_CFLAGS="$TARGET_CFLAGS -march=armv8-a+nofp+nosimd" +else + TARGET_CFLAGS="$TARGET_CFLAGS -msoft-float" +fi