diff mbox

firmware: efi: remove unneeded guid unparse

Message ID 1422542102-19348-1-git-send-email-ivan.khoronzhuk@linaro.org
State Accepted
Commit 613782b0875269b6f849e3344a789e647414a434
Headers show

Commit Message

Ivan Khoronzhuk Jan. 29, 2015, 2:35 p.m. UTC
There is no reason to translate guid number to string here.
So remove it in order to not do unneeded work.

Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
---
 drivers/firmware/efi/efi.c | 5 -----
 1 file changed, 5 deletions(-)

Comments

Ivan Khoronzhuk Jan. 29, 2015, 2:57 p.m. UTC | #1
Oh, sorry.
Just didn't note that it's picked up from linaro list.


On 01/29/2015 04:47 PM, Matt Fleming wrote:
> On Thu, 2015-01-29 at 16:35 +0200, Ivan Khoronzhuk wrote:
>> There is no reason to translate guid number to string here.
>> So remove it in order to not do unneeded work.
>>
>> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
>> ---
>>   drivers/firmware/efi/efi.c | 5 -----
>>   1 file changed, 5 deletions(-)
> Why the resend? I already picked this commit up,
>
>    https://lkml.kernel.org/r/20150120223238.GC12079@codeblueprint.co.uk
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
diff mbox

Patch

diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c
index 9035c1b..f6be017 100644
--- a/drivers/firmware/efi/efi.c
+++ b/drivers/firmware/efi/efi.c
@@ -272,15 +272,10 @@  static __init int match_config_table(efi_guid_t *guid,
 				     unsigned long table,
 				     efi_config_table_type_t *table_types)
 {
-	u8 str[EFI_VARIABLE_GUID_LEN + 1];
 	int i;
 
 	if (table_types) {
-		efi_guid_unparse(guid, str);
-
 		for (i = 0; efi_guidcmp(table_types[i].guid, NULL_GUID); i++) {
-			efi_guid_unparse(&table_types[i].guid, str);
-
 			if (!efi_guidcmp(*guid, table_types[i].guid)) {
 				*(table_types[i].ptr) = table;
 				pr_cont(" %s=0x%lx ",