| Message ID | 1422969216-19870-1-git-send-email-petri.savolainen@linaro.org |
|---|---|
| State | Accepted |
| Commit | 420dc9de60eb9120946ef2ac214f2811b77284bc |
| Headers | show |
Bill, you wanted to review that patch. Maxim. On 02/03/2015 04:13 PM, Petri Savolainen wrote: > This is currently the only output side packet flag. It's removed > now and re-defined later with all other output side control flags. > > Signed-off-by: Petri Savolainen <petri.savolainen@linaro.org> > --- > include/odp/api/packet_flags.h | 7 ------- > platform/linux-generic/odp_packet_flags.c | 7 ------- > test/validation/buffer/odp_packet_test.c | 7 ------- > 3 files changed, 21 deletions(-) > > diff --git a/include/odp/api/packet_flags.h b/include/odp/api/packet_flags.h > index df1486b..f864bba 100644 > --- a/include/odp/api/packet_flags.h > +++ b/include/odp/api/packet_flags.h > @@ -174,13 +174,6 @@ int odp_packet_has_sctp(odp_packet_t pkt); > int odp_packet_has_icmp(odp_packet_t pkt); > > /** > - * Request L4 checksum calculation > - * > - * @param pkt Packet handle > - */ > -void odp_packet_override_l4_chksum(odp_packet_t pkt); > - > -/** > * Set flag for L2 header, e.g. ethernet > * > * @param pkt Packet handle > diff --git a/platform/linux-generic/odp_packet_flags.c b/platform/linux-generic/odp_packet_flags.c > index f2ef61d..ab3d12f 100644 > --- a/platform/linux-generic/odp_packet_flags.c > +++ b/platform/linux-generic/odp_packet_flags.c > @@ -100,13 +100,6 @@ int odp_packet_has_icmp(odp_packet_t pkt) > return odp_packet_hdr(pkt)->input_flags.icmp; > } > > -/* Set Output Flags */ > - > -void odp_packet_override_l4_chksum(odp_packet_t pkt) > -{ > - odp_packet_hdr(pkt)->output_flags.l4_chksum = 1; > -} > - > /* Set Input Flags */ > > void odp_packet_has_l2_set(odp_packet_t pkt, int val) > diff --git a/test/validation/buffer/odp_packet_test.c b/test/validation/buffer/odp_packet_test.c > index 0a5d32e..b8995f7 100644 > --- a/test/validation/buffer/odp_packet_test.c > +++ b/test/validation/buffer/odp_packet_test.c > @@ -443,12 +443,6 @@ static void packet_error_flags(void) > CU_ASSERT(err == 0 || err == 1); > } > > -static void packet_out_flags(void) > -{ > - odp_packet_override_l4_chksum(test_packet); > - CU_PASS("Current API doesn't return any error code\n"); > -} > - > struct packet_metadata { > uint32_t l2_off; > uint32_t l3_off; > @@ -659,7 +653,6 @@ CU_TestInfo packet_tests[] = { > _CU_TEST_INFO(packet_segments), > _CU_TEST_INFO(packet_segment_last), > _CU_TEST_INFO(packet_in_flags), > - _CU_TEST_INFO(packet_out_flags), > _CU_TEST_INFO(packet_error_flags), > _CU_TEST_INFO(packet_add_rem_data), > _CU_TEST_INFO(packet_copy),
On Tue, Feb 3, 2015 at 7:13 AM, Petri Savolainen < petri.savolainen@linaro.org> wrote: > This is currently the only output side packet flag. It's removed > now and re-defined later with all other output side control flags. > > Signed-off-by: Petri Savolainen <petri.savolainen@linaro.org> > Reviewed-by: Bill Fischofer <bill.fischofer@linaro.org> > --- > include/odp/api/packet_flags.h | 7 ------- > platform/linux-generic/odp_packet_flags.c | 7 ------- > test/validation/buffer/odp_packet_test.c | 7 ------- > 3 files changed, 21 deletions(-) > > diff --git a/include/odp/api/packet_flags.h > b/include/odp/api/packet_flags.h > index df1486b..f864bba 100644 > --- a/include/odp/api/packet_flags.h > +++ b/include/odp/api/packet_flags.h > @@ -174,13 +174,6 @@ int odp_packet_has_sctp(odp_packet_t pkt); > int odp_packet_has_icmp(odp_packet_t pkt); > > /** > - * Request L4 checksum calculation > - * > - * @param pkt Packet handle > - */ > -void odp_packet_override_l4_chksum(odp_packet_t pkt); > - > -/** > * Set flag for L2 header, e.g. ethernet > * > * @param pkt Packet handle > diff --git a/platform/linux-generic/odp_packet_flags.c > b/platform/linux-generic/odp_packet_flags.c > index f2ef61d..ab3d12f 100644 > --- a/platform/linux-generic/odp_packet_flags.c > +++ b/platform/linux-generic/odp_packet_flags.c > @@ -100,13 +100,6 @@ int odp_packet_has_icmp(odp_packet_t pkt) > return odp_packet_hdr(pkt)->input_flags.icmp; > } > > -/* Set Output Flags */ > - > -void odp_packet_override_l4_chksum(odp_packet_t pkt) > -{ > - odp_packet_hdr(pkt)->output_flags.l4_chksum = 1; > -} > - > /* Set Input Flags */ > > void odp_packet_has_l2_set(odp_packet_t pkt, int val) > diff --git a/test/validation/buffer/odp_packet_test.c > b/test/validation/buffer/odp_packet_test.c > index 0a5d32e..b8995f7 100644 > --- a/test/validation/buffer/odp_packet_test.c > +++ b/test/validation/buffer/odp_packet_test.c > @@ -443,12 +443,6 @@ static void packet_error_flags(void) > CU_ASSERT(err == 0 || err == 1); > } > > -static void packet_out_flags(void) > -{ > - odp_packet_override_l4_chksum(test_packet); > - CU_PASS("Current API doesn't return any error code\n"); > -} > - > struct packet_metadata { > uint32_t l2_off; > uint32_t l3_off; > @@ -659,7 +653,6 @@ CU_TestInfo packet_tests[] = { > _CU_TEST_INFO(packet_segments), > _CU_TEST_INFO(packet_segment_last), > _CU_TEST_INFO(packet_in_flags), > - _CU_TEST_INFO(packet_out_flags), > _CU_TEST_INFO(packet_error_flags), > _CU_TEST_INFO(packet_add_rem_data), > _CU_TEST_INFO(packet_copy), > -- > 2.2.2 > > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > http://lists.linaro.org/mailman/listinfo/lng-odp >
diff --git a/include/odp/api/packet_flags.h b/include/odp/api/packet_flags.h index df1486b..f864bba 100644 --- a/include/odp/api/packet_flags.h +++ b/include/odp/api/packet_flags.h @@ -174,13 +174,6 @@ int odp_packet_has_sctp(odp_packet_t pkt); int odp_packet_has_icmp(odp_packet_t pkt); /** - * Request L4 checksum calculation - * - * @param pkt Packet handle - */ -void odp_packet_override_l4_chksum(odp_packet_t pkt); - -/** * Set flag for L2 header, e.g. ethernet * * @param pkt Packet handle diff --git a/platform/linux-generic/odp_packet_flags.c b/platform/linux-generic/odp_packet_flags.c index f2ef61d..ab3d12f 100644 --- a/platform/linux-generic/odp_packet_flags.c +++ b/platform/linux-generic/odp_packet_flags.c @@ -100,13 +100,6 @@ int odp_packet_has_icmp(odp_packet_t pkt) return odp_packet_hdr(pkt)->input_flags.icmp; } -/* Set Output Flags */ - -void odp_packet_override_l4_chksum(odp_packet_t pkt) -{ - odp_packet_hdr(pkt)->output_flags.l4_chksum = 1; -} - /* Set Input Flags */ void odp_packet_has_l2_set(odp_packet_t pkt, int val) diff --git a/test/validation/buffer/odp_packet_test.c b/test/validation/buffer/odp_packet_test.c index 0a5d32e..b8995f7 100644 --- a/test/validation/buffer/odp_packet_test.c +++ b/test/validation/buffer/odp_packet_test.c @@ -443,12 +443,6 @@ static void packet_error_flags(void) CU_ASSERT(err == 0 || err == 1); } -static void packet_out_flags(void) -{ - odp_packet_override_l4_chksum(test_packet); - CU_PASS("Current API doesn't return any error code\n"); -} - struct packet_metadata { uint32_t l2_off; uint32_t l3_off; @@ -659,7 +653,6 @@ CU_TestInfo packet_tests[] = { _CU_TEST_INFO(packet_segments), _CU_TEST_INFO(packet_segment_last), _CU_TEST_INFO(packet_in_flags), - _CU_TEST_INFO(packet_out_flags), _CU_TEST_INFO(packet_error_flags), _CU_TEST_INFO(packet_add_rem_data), _CU_TEST_INFO(packet_copy),
This is currently the only output side packet flag. It's removed now and re-defined later with all other output side control flags. Signed-off-by: Petri Savolainen <petri.savolainen@linaro.org> --- include/odp/api/packet_flags.h | 7 ------- platform/linux-generic/odp_packet_flags.c | 7 ------- test/validation/buffer/odp_packet_test.c | 7 ------- 3 files changed, 21 deletions(-)