diff mbox series

[net-next] ethtool: stats: Fix a copy-paste error

Message ID 20210519021038.25928-1-yuehaibing@huawei.com
State New
Headers show
Series [net-next] ethtool: stats: Fix a copy-paste error | expand

Commit Message

Yue Haibing May 19, 2021, 2:10 a.m. UTC
data->ctrl_stats should be memset with correct size.

Fixes: bfad2b979ddc ("ethtool: add interface to read standard MAC Ctrl stats")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 net/ethtool/stats.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jakub Kicinski May 19, 2021, 2:37 a.m. UTC | #1
On Wed, 19 May 2021 10:10:38 +0800 YueHaibing wrote:
> data->ctrl_stats should be memset with correct size.
> 
> Fixes: bfad2b979ddc ("ethtool: add interface to read standard MAC Ctrl stats")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Acked-by: Jakub Kicinski <kuba@kernel.org>
Jakub Kicinski May 19, 2021, 2:38 a.m. UTC | #2
On Wed, 19 May 2021 10:10:38 +0800 YueHaibing wrote:
> data->ctrl_stats should be memset with correct size.
> 
> Fixes: bfad2b979ddc ("ethtool: add interface to read standard MAC Ctrl stats")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Ah, FWIW this should had been targeting net.
patchwork-bot+netdevbpf@kernel.org May 19, 2021, 7 p.m. UTC | #3
Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Wed, 19 May 2021 10:10:38 +0800 you wrote:
> data->ctrl_stats should be memset with correct size.
> 
> Fixes: bfad2b979ddc ("ethtool: add interface to read standard MAC Ctrl stats")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  net/ethtool/stats.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
  - [net-next] ethtool: stats: Fix a copy-paste error
    https://git.kernel.org/netdev/net/c/c71b99640d2d

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
diff mbox series

Patch

diff --git a/net/ethtool/stats.c b/net/ethtool/stats.c
index b7642dc96d50..ec07f5765e03 100644
--- a/net/ethtool/stats.c
+++ b/net/ethtool/stats.c
@@ -119,7 +119,7 @@  static int stats_prepare_data(const struct ethnl_req_info *req_base,
 	 */
 	memset(&data->phy_stats, 0xff, sizeof(data->phy_stats));
 	memset(&data->mac_stats, 0xff, sizeof(data->mac_stats));
-	memset(&data->ctrl_stats, 0xff, sizeof(data->mac_stats));
+	memset(&data->ctrl_stats, 0xff, sizeof(data->ctrl_stats));
 	memset(&data->rmon_stats, 0xff, sizeof(data->rmon_stats));
 
 	if (test_bit(ETHTOOL_STATS_ETH_PHY, req_info->stat_mask) &&