From patchwork Tue Feb 3 22:48:42 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anders Roxell X-Patchwork-Id: 44315 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-lb0-f198.google.com (mail-lb0-f198.google.com [209.85.217.198]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 5F10D2034D for ; Tue, 3 Feb 2015 22:49:17 +0000 (UTC) Received: by mail-lb0-f198.google.com with SMTP id l4sf6696596lbv.1 for ; Tue, 03 Feb 2015 14:49:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:date:from:to:message-id:references :mime-version:content-disposition:in-reply-to:user-agent:cc:subject :precedence:list-id:list-unsubscribe:list-archive:list-post :list-help:list-subscribe:content-type:content-transfer-encoding :errors-to:sender:x-original-sender :x-original-authentication-results:mailing-list; bh=EJ+WznApS/1Q84wSaXdaCONtyPFZIXRMKmcieF1OvIg=; b=UhUwr/6MCGq0NY5dIHWyiSxj06nzqKfTloaWFQOZojE61o6h+OyAisqaPBOwT1YnUe ch8SnQA/zUoGLvdVcZgScbiRh+HshMRNvA5gbNcsD3MHREontlJmdfwgDhmZZ4xj2ZDK BL96VkdtaERt9eGsaXaTjQ62Wm45Fpf/sVHV5JkiMQUOblFdq0lDpJ6LbuNxBfr8h5LG /U0m6+rUqqaLh3HmCqMlNcOi2K95AYu95yQMUlpHMWTgN/GkxGG9yVF9PH70dWQ2Jfew 3hjpnCTFjiqDzNegU/c2SAYmkZ3DPPcZh/72GdkGRnPpZ9Msc2ukpPBrhXBkSqUsQQNY dG6w== X-Gm-Message-State: ALoCoQkFl7TE6nnGQo+ZjS7Szdma1wUxWxEqc+eSsXNSqu6njZWlMFmPK8YglACrWjXRPFuSVLRU X-Received: by 10.152.26.74 with SMTP id j10mr3432667lag.10.1423003755660; Tue, 03 Feb 2015 14:49:15 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.44.232 with SMTP id h8ls252539lam.30.gmail; Tue, 03 Feb 2015 14:49:15 -0800 (PST) X-Received: by 10.152.22.129 with SMTP id d1mr27694095laf.22.1423003755446; Tue, 03 Feb 2015 14:49:15 -0800 (PST) Received: from mail-lb0-f172.google.com (mail-lb0-f172.google.com. [209.85.217.172]) by mx.google.com with ESMTPS id mt5si20499111lbb.59.2015.02.03.14.49.15 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 03 Feb 2015 14:49:15 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.172 as permitted sender) client-ip=209.85.217.172; Received: by mail-lb0-f172.google.com with SMTP id l4so41425441lbv.3 for ; Tue, 03 Feb 2015 14:49:15 -0800 (PST) X-Received: by 10.112.25.104 with SMTP id b8mr27368878lbg.69.1423003755318; Tue, 03 Feb 2015 14:49:15 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.35.133 with SMTP id h5csp130517lbj; Tue, 3 Feb 2015 14:49:14 -0800 (PST) X-Received: by 10.140.106.100 with SMTP id d91mr53948586qgf.18.1423003753620; Tue, 03 Feb 2015 14:49:13 -0800 (PST) Received: from ip-10-35-177-41.ec2.internal (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTPS id m20si30583625qgd.65.2015.02.03.14.49.12 (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 03 Feb 2015 14:49:13 -0800 (PST) Received-SPF: none (google.com: lng-odp-bounces@lists.linaro.org does not designate permitted sender hosts) client-ip=54.225.227.206; Received: from localhost ([127.0.0.1] helo=ip-10-35-177-41.ec2.internal) by ip-10-35-177-41.ec2.internal with esmtp (Exim 4.76) (envelope-from ) id 1YImHO-0001GJ-0m; Tue, 03 Feb 2015 22:49:10 +0000 Received: from mail-lb0-f180.google.com ([209.85.217.180]) by ip-10-35-177-41.ec2.internal with esmtp (Exim 4.76) (envelope-from ) id 1YImHI-0001EJ-4Z for lng-odp@lists.linaro.org; Tue, 03 Feb 2015 22:49:04 +0000 Received: by mail-lb0-f180.google.com with SMTP id b6so41304825lbj.11 for ; Tue, 03 Feb 2015 14:48:57 -0800 (PST) X-Received: by 10.112.129.228 with SMTP id nz4mr124911lbb.8.1423003737757; Tue, 03 Feb 2015 14:48:57 -0800 (PST) Received: from 8074w.roxell.se (c-853670d5.07-21-73746f28.cust.bredbandsbolaget.se. [213.112.54.133]) by mx.google.com with ESMTPSA id q9sm5301123lbo.29.2015.02.03.14.48.56 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 03 Feb 2015 14:48:57 -0800 (PST) Date: Tue, 3 Feb 2015 23:48:42 +0100 From: Anders Roxell To: Mike Holmes Message-ID: <20150203224842.GL10838@8074w.roxell.se> References: <1422979975-32548-1-git-send-email-maxim.uvarov@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Topics: patch Cc: lng-odp Subject: Re: [lng-odp] [PATCHv2] api: fix odp_version_api_str() X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: lng-odp-bounces@lists.linaro.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: anders.roxell@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.172 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 On 2015-02-03 11:28, Mike Holmes wrote: > On 3 February 2015 at 11:12, Maxim Uvarov wrote: > > > odp_version_api_str() has to be in API header while > > odp_version_impl_str() should be in linux-generic. > > That change fixes: > > https://bugs.linaro.org/show_bug.cgi?id=1194 > > > > Signed-off-by: Maxim Uvarov > > > > Reviewed-by: Mike Holmes > > Clears the new test case patch "validation: add version string check" > which should be added as insurance against this bug in the future before > closing the bug I think we can drop "static inline" to the version string function, because checking for a version string is not time critical right? If we assume that its not time critical the diff below + Mikes validation version string patch got it to pass and we hide more stuff from the public doxygen clean API include/odp/api/*.h files. Cheers, Anders $ git df diff --git a/platform/linux-generic/include/odp/version.h b/platform/linux-generic/include/odp/version.h index f29320a..2c557cc 100644 --- a/platform/linux-generic/include/odp/version.h +++ b/platform/linux-generic/include/odp/version.h @@ -23,11 +23,6 @@ extern "C" { * @{ */ -static inline const char *odp_version_api_str(void) -{ - return ODP_VERSION_API_STR; -} - /** * @} */ diff --git a/platform/linux-generic/odp_impl.c b/platform/linux-generic/odp_impl.c index ca3224d..23ab12d 100644 --- a/platform/linux-generic/odp_impl.c +++ b/platform/linux-generic/odp_impl.c @@ -28,6 +28,11 @@ const char *odp_version_impl_str(void) return ODP_VERSION_IMPL_STR; } +const char *odp_version_api_str(void) +{ + return ODP_VERSION_API_STR; +} + #ifdef __cplusplus } #endif