diff mbox series

[2/3] ARM: dts: imx: emcon-avari: Fix nxp,pca8574 #gpio-cells

Message ID 6cd916fc8c0a133cd216eee06cac86716b66eff4.1621583562.git.geert+renesas@glider.be
State Accepted
Commit b73eb6b3b91ff7d76cff5f8c7ab92fe0c51e3829
Headers show
Series [1/3] ARM: dts: dra7x-evm: Align GPIO hog names with dt-schema | expand

Commit Message

Geert Uytterhoeven May 21, 2021, 7:54 a.m. UTC
According to the DT bindings, #gpio-cells must be two.

Fixes: 63e71fedc07c4ece ("ARM: dts: Add support for emtrion emCON-MX6 series")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 arch/arm/boot/dts/imx6qdl-emcon-avari.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Laurent Pinchart May 23, 2021, 1:55 a.m. UTC | #1
Hi Geert,

Thank you for the patch.

On Fri, May 21, 2021 at 09:54:07AM +0200, Geert Uytterhoeven wrote:
> According to the DT bindings, #gpio-cells must be two.

> 

> Fixes: 63e71fedc07c4ece ("ARM: dts: Add support for emtrion emCON-MX6 series")

> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>


Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>


> ---

>  arch/arm/boot/dts/imx6qdl-emcon-avari.dtsi | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/arch/arm/boot/dts/imx6qdl-emcon-avari.dtsi b/arch/arm/boot/dts/imx6qdl-emcon-avari.dtsi

> index 828cf3e39784afd6..c4e146f3341bb85d 100644

> --- a/arch/arm/boot/dts/imx6qdl-emcon-avari.dtsi

> +++ b/arch/arm/boot/dts/imx6qdl-emcon-avari.dtsi

> @@ -126,7 +126,7 @@ boardid: gpio@3a {

>  		compatible = "nxp,pca8574";

>  		reg = <0x3a>;

>  		gpio-controller;

> -		#gpio-cells = <1>;

> +		#gpio-cells = <2>;

>  	};

>  };

>  


-- 
Regards,

Laurent Pinchart
Shawn Guo May 23, 2021, 5:42 a.m. UTC | #2
On Fri, May 21, 2021 at 09:54:07AM +0200, Geert Uytterhoeven wrote:
> According to the DT bindings, #gpio-cells must be two.
> 
> Fixes: 63e71fedc07c4ece ("ARM: dts: Add support for emtrion emCON-MX6 series")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Applied, thanks.
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/imx6qdl-emcon-avari.dtsi b/arch/arm/boot/dts/imx6qdl-emcon-avari.dtsi
index 828cf3e39784afd6..c4e146f3341bb85d 100644
--- a/arch/arm/boot/dts/imx6qdl-emcon-avari.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-emcon-avari.dtsi
@@ -126,7 +126,7 @@  boardid: gpio@3a {
 		compatible = "nxp,pca8574";
 		reg = <0x3a>;
 		gpio-controller;
-		#gpio-cells = <1>;
+		#gpio-cells = <2>;
 	};
 };