From patchwork Wed Feb 11 08:20:54 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Auger Eric X-Patchwork-Id: 44553 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-la0-f70.google.com (mail-la0-f70.google.com [209.85.215.70]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 2A45E2151F for ; Wed, 11 Feb 2015 08:23:20 +0000 (UTC) Received: by labge10 with SMTP id ge10sf989292lab.3 for ; Wed, 11 Feb 2015 00:23:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe; bh=csTNK03Ei/iYr/cUb7M8xL7SyIUp2osGZ1Hk05rwIsE=; b=GIinw6HzOChtRDPUNR2wQWYLlehpATedjn2jOqJVp3zbh1ymtN3tfuPd7TLc42fOWb eDNAoiVFc2RdGliXBBkmz5qNbGYU+FdWxhG4w2J2TljUmokIJWLRIA6x/QROgyylRG8Q K+Pd/q997+guouuHoi8+IosNyWuYBALFuj558JCeAfh5beEQ7yPuMrbJ1X+/O/pSNQQ3 SCCQ4fz/3zis2Ujov3uE5alnmXkE99mHTZUL7zn4piUBjZ7jgVNC0amPhXCcwxKLWYit dNcuZ2KL67CAke81HdaSNRcV01bKXlu9jwbsECRe1CdH1GETbsinOtaqjo/9meG+cT4u x0zQ== X-Gm-Message-State: ALoCoQlVDG++g1jayCmNxHOZolJH5sR18zGqT5XDe0kBxcedaN1sWShD2mRE9g8VtLot6m6Zk+LU X-Received: by 10.152.26.74 with SMTP id j10mr3295883lag.10.1423642999177; Wed, 11 Feb 2015 00:23:19 -0800 (PST) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.6.97 with SMTP id z1ls32603laz.35.gmail; Wed, 11 Feb 2015 00:23:18 -0800 (PST) X-Received: by 10.152.37.138 with SMTP id y10mr26823792laj.88.1423642998972; Wed, 11 Feb 2015 00:23:18 -0800 (PST) Received: from mail-la0-f51.google.com (mail-la0-f51.google.com. [209.85.215.51]) by mx.google.com with ESMTPS id ai4si98546lbc.10.2015.02.11.00.23.18 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Feb 2015 00:23:18 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.51 as permitted sender) client-ip=209.85.215.51; Received: by labhz20 with SMTP id hz20so1839912lab.0 for ; Wed, 11 Feb 2015 00:23:18 -0800 (PST) X-Received: by 10.112.161.34 with SMTP id xp2mr1132154lbb.73.1423642998536; Wed, 11 Feb 2015 00:23:18 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.112.35.133 with SMTP id h5csp1105317lbj; Wed, 11 Feb 2015 00:23:17 -0800 (PST) X-Received: by 10.42.64.193 with SMTP id h1mr1936825ici.32.1423642997150; Wed, 11 Feb 2015 00:23:17 -0800 (PST) Received: from mail-ie0-f174.google.com (mail-ie0-f174.google.com. [209.85.223.174]) by mx.google.com with ESMTPS id t81si93704ioe.24.2015.02.11.00.23.16 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Feb 2015 00:23:17 -0800 (PST) Received-SPF: pass (google.com: domain of eric.auger@linaro.org designates 209.85.223.174 as permitted sender) client-ip=209.85.223.174; Received: by iery20 with SMTP id y20so2270783ier.9 for ; Wed, 11 Feb 2015 00:23:16 -0800 (PST) X-Received: by 10.50.67.100 with SMTP id m4mr28821430igt.22.1423642996412; Wed, 11 Feb 2015 00:23:16 -0800 (PST) Received: from gnx2579.solutionip.com ([113.28.134.59]) by mx.google.com with ESMTPSA id g11sm56703iod.28.2015.02.11.00.23.12 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 11 Feb 2015 00:23:15 -0800 (PST) From: Eric Auger To: eric.auger@st.com, eric.auger@linaro.org, christoffer.dall@linaro.org, marc.zyngier@arm.com, andre.przywara@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, alex.williamson@redhat.com Cc: patches@linaro.org, a.motakis@virtualopensystems.com, a.rigo@virtualopensystems.com, b.reynal@virtualopensystems.com Subject: [RFC v2 1/4] chip.c: complete the forwarded IRQ in case the handler is not reached Date: Wed, 11 Feb 2015 09:20:54 +0100 Message-Id: <1423642857-24240-2-git-send-email-eric.auger@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1423642857-24240-1-git-send-email-eric.auger@linaro.org> References: <1423642857-24240-1-git-send-email-eric.auger@linaro.org> X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: eric.auger@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.51 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , With current handle_fasteoi_irq implementation, in case irqd_irq_disabled is true (disable_irq was called) or !irq_may_run, the IRQ is not completed. Only the running priority is dropped. IN those cases, the IRQ will never be forwarded and hence will never be deactivated by anyone else. Signed-off-by: Eric Auger --- kernel/irq/chip.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c index 2f9571b..f12cce6 100644 --- a/kernel/irq/chip.c +++ b/kernel/irq/chip.c @@ -561,8 +561,12 @@ handle_fasteoi_irq(unsigned int irq, struct irq_desc *desc) raw_spin_unlock(&desc->lock); return; out: - if (!(chip->flags & IRQCHIP_EOI_IF_HANDLED)) - eoi_irq(desc, chip); + if (!(chip->flags & IRQCHIP_EOI_IF_HANDLED)) { + if (chip->irq_priority_drop) + chip->irq_priority_drop(&desc->irq_data); + if (chip->irq_eoi) + chip->irq_eoi(&desc->irq_data); + } raw_spin_unlock(&desc->lock); } EXPORT_SYMBOL_GPL(handle_fasteoi_irq);