| Message ID | 1423798368-16597-1-git-send-email-petri.savolainen@linaro.org |
|---|---|
| State | Accepted |
| Commit | 0b0ed4323cf6b827010257cc18cb55552d39f5ae |
| Headers | show |
This patch series is self-contained but incomplete. I've discussed this with Petri and will post a follow-on patch that finishes this change. For this series: Reviewed-and-tested-by: Bill Fischofer <bill.fischofer@linaro.org> On Fri, Feb 13, 2015 at 11:32 AM, Petri Savolainen < petri.savolainen@linaro.org> wrote: > Completed odp_pool_param_t definition with packet pool parameters. > > * seg_len > Control number of packet data bytes that are stored in the first > segment of a packet. > > * num > Define maximum number of packets (that are 'len' bytes or smaller). > > * len > Required packet length that the pool must provide 'num' packets > > Signed-off-by: Petri Savolainen <petri.savolainen@linaro.org> > --- > include/odp/api/pool.h | 24 +++++++++++++++++++----- > 1 file changed, 19 insertions(+), 5 deletions(-) > > diff --git a/include/odp/api/pool.h b/include/odp/api/pool.h > index b8c0f2e..66dc70e 100644 > --- a/include/odp/api/pool.h > +++ b/include/odp/api/pool.h > @@ -60,13 +60,27 @@ typedef struct odp_pool_param_t { > of 8. */ > uint32_t num; /**< Number of buffers in the pool > */ > } buf; > -/* Reserved for packet and timeout specific params > struct { > - uint32_t seg_size; > - uint32_t seg_align; > - uint32_t num; > + uint32_t seg_len; /**< Minimum number of packet > data > + bytes that are stored in > the > + first segment of a packet. > + The maximum value is > defined by > + > ODP_CONFIG_PACKET_SEG_LEN_MAX. > + Use 0 for default. */ > + uint32_t __res1; /* Keep struct identical to > buf, > + until implementation is > fixed */ > + uint32_t num; /**< The number of packets > that the > + pool must provide that are > + packet lenght 'len' bytes > or > + smaller. */ > + uint32_t len; /**< Minimum packet length > that the > + pool must provide 'num' > + packets. The number of > packets > + may be less than 'num' > when > + packets are larger than > 'len'. > + Use 0 for default. > + */ > } pkt; > -*/ > struct { > uint32_t __res1; /* Keep struct identical to buf, > */ > uint32_t __res2; /* until pool implementation is > fixed*/ > -- > 2.3.0 > > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > http://lists.linaro.org/mailman/listinfo/lng-odp >
Merged, Maxim. On 02/13/2015 06:32 AM, Petri Savolainen wrote: > Completed odp_pool_param_t definition with packet pool parameters. > > * seg_len > Control number of packet data bytes that are stored in the first > segment of a packet. > > * num > Define maximum number of packets (that are 'len' bytes or smaller). > > * len > Required packet length that the pool must provide 'num' packets > > Signed-off-by: Petri Savolainen <petri.savolainen@linaro.org> > --- > include/odp/api/pool.h | 24 +++++++++++++++++++----- > 1 file changed, 19 insertions(+), 5 deletions(-) > > diff --git a/include/odp/api/pool.h b/include/odp/api/pool.h > index b8c0f2e..66dc70e 100644 > --- a/include/odp/api/pool.h > +++ b/include/odp/api/pool.h > @@ -60,13 +60,27 @@ typedef struct odp_pool_param_t { > of 8. */ > uint32_t num; /**< Number of buffers in the pool */ > } buf; > -/* Reserved for packet and timeout specific params > struct { > - uint32_t seg_size; > - uint32_t seg_align; > - uint32_t num; > + uint32_t seg_len; /**< Minimum number of packet data > + bytes that are stored in the > + first segment of a packet. > + The maximum value is defined by > + ODP_CONFIG_PACKET_SEG_LEN_MAX. > + Use 0 for default. */ > + uint32_t __res1; /* Keep struct identical to buf, > + until implementation is fixed */ > + uint32_t num; /**< The number of packets that the > + pool must provide that are > + packet lenght 'len' bytes or > + smaller. */ > + uint32_t len; /**< Minimum packet length that the > + pool must provide 'num' > + packets. The number of packets > + may be less than 'num' when > + packets are larger than 'len'. > + Use 0 for default. > + */ > } pkt; > -*/ > struct { > uint32_t __res1; /* Keep struct identical to buf, */ > uint32_t __res2; /* until pool implementation is fixed*/
diff --git a/include/odp/api/pool.h b/include/odp/api/pool.h index b8c0f2e..66dc70e 100644 --- a/include/odp/api/pool.h +++ b/include/odp/api/pool.h @@ -60,13 +60,27 @@ typedef struct odp_pool_param_t { of 8. */ uint32_t num; /**< Number of buffers in the pool */ } buf; -/* Reserved for packet and timeout specific params struct { - uint32_t seg_size; - uint32_t seg_align; - uint32_t num; + uint32_t seg_len; /**< Minimum number of packet data + bytes that are stored in the + first segment of a packet. + The maximum value is defined by + ODP_CONFIG_PACKET_SEG_LEN_MAX. + Use 0 for default. */ + uint32_t __res1; /* Keep struct identical to buf, + until implementation is fixed */ + uint32_t num; /**< The number of packets that the + pool must provide that are + packet lenght 'len' bytes or + smaller. */ + uint32_t len; /**< Minimum packet length that the + pool must provide 'num' + packets. The number of packets + may be less than 'num' when + packets are larger than 'len'. + Use 0 for default. + */ } pkt; -*/ struct { uint32_t __res1; /* Keep struct identical to buf, */ uint32_t __res2; /* until pool implementation is fixed*/
Completed odp_pool_param_t definition with packet pool parameters. * seg_len Control number of packet data bytes that are stored in the first segment of a packet. * num Define maximum number of packets (that are 'len' bytes or smaller). * len Required packet length that the pool must provide 'num' packets Signed-off-by: Petri Savolainen <petri.savolainen@linaro.org> --- include/odp/api/pool.h | 24 +++++++++++++++++++----- 1 file changed, 19 insertions(+), 5 deletions(-)