| Message ID | 1424353087-14302-5-git-send-email-bill.fischofer@linaro.org |
|---|---|
| State | New |
| Headers | show |
2 latest patches have make check issue, that is the blocker. Can merge first 3 patches. Maxim. On 02/19/2015 05:56 PM, Savolainen, Petri (NSN - FI/Espoo) wrote: > Entire patch set > > Reviewed-by: Petri Savolainen <petri.savolainen@linaro.org> > > >> -----Original Message----- >> From: lng-odp-bounces@lists.linaro.org [mailto:lng-odp- >> bounces@lists.linaro.org] On Behalf Of ext Bill Fischofer >> Sent: Thursday, February 19, 2015 3:38 PM >> To: lng-odp@lists.linaro.org >> Subject: [lng-odp] [PATCHv4 5/5] api: config: simplify packet >> configuration >> >> Remove headroom/tailroom from ODP_CONFIG_PACKET_SEG_LEN_MIN and >> clarify meaning of ODP_CONFIG_PACKET_SEG_LEN_MAX. >> >> Signed-off-by: Bill Fischofer <bill.fischofer@linaro.org> >> --- >> include/odp/api/config.h | 12 ++---------- >> 1 file changed, 2 insertions(+), 10 deletions(-) >> >> diff --git a/include/odp/api/config.h b/include/odp/api/config.h >> index 3ac9e2c..c15d340 100644 >> --- a/include/odp/api/config.h >> +++ b/include/odp/api/config.h >> @@ -95,15 +95,8 @@ extern "C" { >> * This defines the minimum packet segment buffer length in bytes. The >> user >> * defined segment length (seg_len in odp_pool_param_t) will be rounded >> up into >> * this value. >> - * >> - * @internal In linux-generic implementation: >> - * - The value MUST be a multiple of 8. >> - * - The value MUST be a multiple of ODP_CACHE_LINE_SIZE >> - * - The default value (1664) is large enough to support 1536-byte >> packets >> - * with the default headroom shown above and is a multiple of both 64 >> and 128, >> - * which are the most common cache line sizes. >> */ >> -#define ODP_CONFIG_PACKET_SEG_LEN_MIN (1664) >> +#define ODP_CONFIG_PACKET_SEG_LEN_MIN (1598) >> >> /** >> * Maximum packet segment length >> @@ -111,9 +104,8 @@ extern "C" { >> * This defines the maximum packet segment buffer length in bytes. The >> user >> * defined segment length (seg_len in odp_pool_param_t) must not be >> larger than >> * this. >> - * >> */ >> -#define ODP_CONFIG_PACKET_SEG_LEN_MAX ODP_CONFIG_PACKET_SEG_LEN_MIN >> +#define ODP_CONFIG_PACKET_SEG_LEN_MAX (64*1024) >> >> /** >> * Maximum packet buffer length >> -- >> 2.1.0 >> >> >> _______________________________________________ >> lng-odp mailing list >> lng-odp@lists.linaro.org >> http://lists.linaro.org/mailman/listinfo/lng-odp > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > http://lists.linaro.org/mailman/listinfo/lng-odp
V5 of patch series has been posted that resolved these issues. Only change is in config.h increased ODP_CONFIG_BUFFER_ALIGN_MIN from 8 to 16 so Petri's review should still be good. Bill On Thursday, February 19, 2015, Maxim Uvarov <maxim.uvarov@linaro.org> wrote: > 2 latest patches have make check issue, that is the blocker. > Can merge first 3 patches. > > Maxim. > > > On 02/19/2015 05:56 PM, Savolainen, Petri (NSN - FI/Espoo) wrote: > >> Entire patch set >> >> Reviewed-by: Petri Savolainen <petri.savolainen@linaro.org> >> >> >> -----Original Message----- >>> From: lng-odp-bounces@lists.linaro.org [mailto:lng-odp- >>> bounces@lists.linaro.org] On Behalf Of ext Bill Fischofer >>> Sent: Thursday, February 19, 2015 3:38 PM >>> To: lng-odp@lists.linaro.org >>> Subject: [lng-odp] [PATCHv4 5/5] api: config: simplify packet >>> configuration >>> >>> Remove headroom/tailroom from ODP_CONFIG_PACKET_SEG_LEN_MIN and >>> clarify meaning of ODP_CONFIG_PACKET_SEG_LEN_MAX. >>> >>> Signed-off-by: Bill Fischofer <bill.fischofer@linaro.org> >>> --- >>> include/odp/api/config.h | 12 ++---------- >>> 1 file changed, 2 insertions(+), 10 deletions(-) >>> >>> diff --git a/include/odp/api/config.h b/include/odp/api/config.h >>> index 3ac9e2c..c15d340 100644 >>> --- a/include/odp/api/config.h >>> +++ b/include/odp/api/config.h >>> @@ -95,15 +95,8 @@ extern "C" { >>> * This defines the minimum packet segment buffer length in bytes. The >>> user >>> * defined segment length (seg_len in odp_pool_param_t) will be rounded >>> up into >>> * this value. >>> - * >>> - * @internal In linux-generic implementation: >>> - * - The value MUST be a multiple of 8. >>> - * - The value MUST be a multiple of ODP_CACHE_LINE_SIZE >>> - * - The default value (1664) is large enough to support 1536-byte >>> packets >>> - * with the default headroom shown above and is a multiple of both 64 >>> and 128, >>> - * which are the most common cache line sizes. >>> */ >>> -#define ODP_CONFIG_PACKET_SEG_LEN_MIN (1664) >>> +#define ODP_CONFIG_PACKET_SEG_LEN_MIN (1598) >>> >>> /** >>> * Maximum packet segment length >>> @@ -111,9 +104,8 @@ extern "C" { >>> * This defines the maximum packet segment buffer length in bytes. The >>> user >>> * defined segment length (seg_len in odp_pool_param_t) must not be >>> larger than >>> * this. >>> - * >>> */ >>> -#define ODP_CONFIG_PACKET_SEG_LEN_MAX ODP_CONFIG_PACKET_SEG_LEN_MIN >>> +#define ODP_CONFIG_PACKET_SEG_LEN_MAX (64*1024) >>> >>> /** >>> * Maximum packet buffer length >>> -- >>> 2.1.0 >>> >>> >>> _______________________________________________ >>> lng-odp mailing list >>> lng-odp@lists.linaro.org >>> http://lists.linaro.org/mailman/listinfo/lng-odp >>> >> _______________________________________________ >> lng-odp mailing list >> lng-odp@lists.linaro.org >> http://lists.linaro.org/mailman/listinfo/lng-odp >> > > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > http://lists.linaro.org/mailman/listinfo/lng-odp >
diff --git a/include/odp/api/config.h b/include/odp/api/config.h index 3ac9e2c..c15d340 100644 --- a/include/odp/api/config.h +++ b/include/odp/api/config.h @@ -95,15 +95,8 @@ extern "C" { * This defines the minimum packet segment buffer length in bytes. The user * defined segment length (seg_len in odp_pool_param_t) will be rounded up into * this value. - * - * @internal In linux-generic implementation: - * - The value MUST be a multiple of 8. - * - The value MUST be a multiple of ODP_CACHE_LINE_SIZE - * - The default value (1664) is large enough to support 1536-byte packets - * with the default headroom shown above and is a multiple of both 64 and 128, - * which are the most common cache line sizes. */ -#define ODP_CONFIG_PACKET_SEG_LEN_MIN (1664) +#define ODP_CONFIG_PACKET_SEG_LEN_MIN (1598) /** * Maximum packet segment length @@ -111,9 +104,8 @@ extern "C" { * This defines the maximum packet segment buffer length in bytes. The user * defined segment length (seg_len in odp_pool_param_t) must not be larger than * this. - * */ -#define ODP_CONFIG_PACKET_SEG_LEN_MAX ODP_CONFIG_PACKET_SEG_LEN_MIN +#define ODP_CONFIG_PACKET_SEG_LEN_MAX (64*1024) /** * Maximum packet buffer length
Remove headroom/tailroom from ODP_CONFIG_PACKET_SEG_LEN_MIN and clarify meaning of ODP_CONFIG_PACKET_SEG_LEN_MAX. Signed-off-by: Bill Fischofer <bill.fischofer@linaro.org> --- include/odp/api/config.h | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-)