[1/2] validation: common: print odp_init failures to stderr

Message ID	1424779071-22631-1-git-send-email-stuart.haslam@linaro.org
State	Superseded
Headers	show Return-Path: <patchwork-forward+bncBDW4DOG33ALBBXOOWGTQKGQEMPU4FHQ@linaro.org> Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.180 as permitted sender) client-ip=209.85.217.180; Received-SPF: none (google.com: lng-odp-bounces@lists.linaro.org does not designate permitted sender hosts) client-ip=54.225.227.206; From: Stuart Haslam <stuart.haslam@linaro.org> To: lng-odp@lists.linaro.org Date: Tue, 24 Feb 2015 11:57:50 +0000 Message-Id: <1424779071-22631-1-git-send-email-stuart.haslam@linaro.org> Subject: [lng-odp] [PATCH 1/2] validation: common: print odp_init failures to stderr Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: lng-odp-bounces@lists.linaro.org Sender: lng-odp-bounces@lists.linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org

Message ID

1424779071-22631-1-git-send-email-stuart.haslam@linaro.org

State

Superseded

Headers

Received-SPF: pass (google.com: domain of
	patch+caf_=patchwork-forward=linaro.org@linaro.org designates
	209.85.217.180 as permitted sender) client-ip=209.85.217.180; 
Received-SPF: none (google.com: lng-odp-bounces@lists.linaro.org does not
	designate permitted sender hosts) client-ip=54.225.227.206; 
From: Stuart Haslam <stuart.haslam@linaro.org>
To: lng-odp@lists.linaro.org
Date: Tue, 24 Feb 2015 11:57:50 +0000
Message-Id: <1424779071-22631-1-git-send-email-stuart.haslam@linaro.org>
Subject: [lng-odp] [PATCH 1/2] validation: common: print odp_init failures
	to stderr
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: lng-odp-bounces@lists.linaro.org
Sender: lng-odp-bounces@lists.linaro.org
Mailing-list: list patchwork-forward@linaro.org;
	contact patchwork-forward+owners@linaro.org

Comments

Bill Fischofer Feb. 24, 2015, 10:01 p.m. UTC | #1

For this series:

Reviewed-by: Bill Fischofer <bill.fischofer@linaro.org>

On Tue, Feb 24, 2015 at 5:57 AM, Stuart Haslam <stuart.haslam@linaro.org>
wrote:

> Signed-off-by: Stuart Haslam <stuart.haslam@linaro.org>
> ---
>  test/validation/common/odp_cunit_common.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/test/validation/common/odp_cunit_common.c
> b/test/validation/common/odp_cunit_common.c
> index 8fdc1ea..b8d3313 100644
> --- a/test/validation/common/odp_cunit_common.c
> +++ b/test/validation/common/odp_cunit_common.c
> @@ -52,11 +52,11 @@ int main(void)
>         printf("\tODP implementation version: %s\n",
> odp_version_impl_str());
>
>         if (0 != odp_init_global(NULL, NULL)) {
> -               printf("odp_init_global fail.\n");
> +               fprintf(stderr, "error: odp_init_global() failed.\n");
>                 return -1;
>         }
>         if (0 != odp_init_local()) {
> -               printf("odp_init_local fail.\n");
> +               fprintf(stderr, "error: odp_init_local() failed.\n");
>                 return -1;
>         }
>
> --
> 2.1.1
>
>
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> http://lists.linaro.org/mailman/listinfo/lng-odp
>

Maxim Uvarov Feb. 25, 2015, 4:47 p.m. UTC | #2

For now that tests fail:

FAIL: odp_classification
FAIL: odp_crypto
FAIL: odp_queue
FAIL: odp_schedule
FAIL: odp_timer


Maxim.

On 02/25/2015 01:01 AM, Bill Fischofer wrote:
> For this series:
>
> Reviewed-by: Bill Fischofer <bill.fischofer@linaro.org 
> <mailto:bill.fischofer@linaro.org>>
>
> On Tue, Feb 24, 2015 at 5:57 AM, Stuart Haslam 
> <stuart.haslam@linaro.org <mailto:stuart.haslam@linaro.org>> wrote:
>
>     Signed-off-by: Stuart Haslam <stuart.haslam@linaro.org
>     <mailto:stuart.haslam@linaro.org>>
>     ---
>      test/validation/common/odp_cunit_common.c | 4 ++--
>      1 file changed, 2 insertions(+), 2 deletions(-)
>
>     diff --git a/test/validation/common/odp_cunit_common.c
>     b/test/validation/common/odp_cunit_common.c
>     index 8fdc1ea..b8d3313 100644
>     --- a/test/validation/common/odp_cunit_common.c
>     +++ b/test/validation/common/odp_cunit_common.c
>     @@ -52,11 +52,11 @@ int main(void)
>             printf("\tODP implementation version: %s\n",
>     odp_version_impl_str());
>
>             if (0 != odp_init_global(NULL, NULL)) {
>     -               printf("odp_init_global fail.\n");
>     +               fprintf(stderr, "error: odp_init_global() failed.\n");
>                     return -1;
>             }
>             if (0 != odp_init_local()) {
>     -               printf("odp_init_local fail.\n");
>     +               fprintf(stderr, "error: odp_init_local() failed.\n");
>                     return -1;
>             }
>
>     --
>     2.1.1
>
>
>     _______________________________________________
>     lng-odp mailing list
>     lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org>
>     http://lists.linaro.org/mailman/listinfo/lng-odp
>
>
>
>
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> http://lists.linaro.org/mailman/listinfo/lng-odp

Bill Fischofer Feb. 25, 2015, 4:51 p.m. UTC | #3

The fix for the odp_queue test was posted a couple of days ago.  It just
needs to be reviewed and merged.

On Wed, Feb 25, 2015 at 10:47 AM, Maxim Uvarov <maxim.uvarov@linaro.org>
wrote:

> For now that tests fail:
>
> FAIL: odp_classification
> FAIL: odp_crypto
> FAIL: odp_queue
> FAIL: odp_schedule
> FAIL: odp_timer
>
>
> Maxim.
>
> On 02/25/2015 01:01 AM, Bill Fischofer wrote:
>
>> For this series:
>>
>> Reviewed-by: Bill Fischofer <bill.fischofer@linaro.org <mailto:
>> bill.fischofer@linaro.org>>
>>
>> On Tue, Feb 24, 2015 at 5:57 AM, Stuart Haslam <stuart.haslam@linaro.org
>> <mailto:stuart.haslam@linaro.org>> wrote:
>>
>>     Signed-off-by: Stuart Haslam <stuart.haslam@linaro.org
>>     <mailto:stuart.haslam@linaro.org>>
>>     ---
>>      test/validation/common/odp_cunit_common.c | 4 ++--
>>      1 file changed, 2 insertions(+), 2 deletions(-)
>>
>>     diff --git a/test/validation/common/odp_cunit_common.c
>>     b/test/validation/common/odp_cunit_common.c
>>     index 8fdc1ea..b8d3313 100644
>>     --- a/test/validation/common/odp_cunit_common.c
>>     +++ b/test/validation/common/odp_cunit_common.c
>>     @@ -52,11 +52,11 @@ int main(void)
>>             printf("\tODP implementation version: %s\n",
>>     odp_version_impl_str());
>>
>>             if (0 != odp_init_global(NULL, NULL)) {
>>     -               printf("odp_init_global fail.\n");
>>     +               fprintf(stderr, "error: odp_init_global() failed.\n");
>>                     return -1;
>>             }
>>             if (0 != odp_init_local()) {
>>     -               printf("odp_init_local fail.\n");
>>     +               fprintf(stderr, "error: odp_init_local() failed.\n");
>>                     return -1;
>>             }
>>
>>     --
>>     2.1.1
>>
>>
>>     _______________________________________________
>>     lng-odp mailing list
>>     lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org>
>>     http://lists.linaro.org/mailman/listinfo/lng-odp
>>
>>
>>
>>
>> _______________________________________________
>> lng-odp mailing list
>> lng-odp@lists.linaro.org
>> http://lists.linaro.org/mailman/listinfo/lng-odp
>>
>
>
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> http://lists.linaro.org/mailman/listinfo/lng-odp
>

Maxim Uvarov Feb. 25, 2015, 6:27 p.m. UTC | #4

On 02/25/2015 07:51 PM, Bill Fischofer wrote:
> The fix for the odp_queue test was posted a couple of days ago.  It 
> just needs to be reviewed and merged.

Yes, Bill I applied Tarases fix due to not call free for initialized 
function. Other things he did the same. So odp_queue not
is not in the list.

Maxim.

>
> On Wed, Feb 25, 2015 at 10:47 AM, Maxim Uvarov 
> <maxim.uvarov@linaro.org <mailto:maxim.uvarov@linaro.org>> wrote:
>
>     For now that tests fail:
>
>     FAIL: odp_classification
>     FAIL: odp_crypto
>     FAIL: odp_queue
>     FAIL: odp_schedule
>     FAIL: odp_timer
>
>
>     Maxim.
>
>     On 02/25/2015 01:01 AM, Bill Fischofer wrote:
>
>         For this series:
>
>         Reviewed-by: Bill Fischofer <bill.fischofer@linaro.org
>         <mailto:bill.fischofer@linaro.org>
>         <mailto:bill.fischofer@linaro.org
>         <mailto:bill.fischofer@linaro.org>>>
>
>         On Tue, Feb 24, 2015 at 5:57 AM, Stuart Haslam
>         <stuart.haslam@linaro.org <mailto:stuart.haslam@linaro.org>
>         <mailto:stuart.haslam@linaro.org
>         <mailto:stuart.haslam@linaro.org>>> wrote:
>
>             Signed-off-by: Stuart Haslam <stuart.haslam@linaro.org
>         <mailto:stuart.haslam@linaro.org>
>             <mailto:stuart.haslam@linaro.org
>         <mailto:stuart.haslam@linaro.org>>>
>             ---
>              test/validation/common/odp_cunit_common.c | 4 ++--
>              1 file changed, 2 insertions(+), 2 deletions(-)
>
>             diff --git a/test/validation/common/odp_cunit_common.c
>             b/test/validation/common/odp_cunit_common.c
>             index 8fdc1ea..b8d3313 100644
>             --- a/test/validation/common/odp_cunit_common.c
>             +++ b/test/validation/common/odp_cunit_common.c
>             @@ -52,11 +52,11 @@ int main(void)
>                     printf("\tODP implementation version: %s\n",
>             odp_version_impl_str());
>
>                     if (0 != odp_init_global(NULL, NULL)) {
>             -               printf("odp_init_global fail.\n");
>             +               fprintf(stderr, "error: odp_init_global()
>         failed.\n");
>                             return -1;
>                     }
>                     if (0 != odp_init_local()) {
>             -               printf("odp_init_local fail.\n");
>             +               fprintf(stderr, "error: odp_init_local()
>         failed.\n");
>                             return -1;
>                     }
>
>             --
>             2.1.1
>
>
>             _______________________________________________
>             lng-odp mailing list
>         lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org>
>         <mailto:lng-odp@lists.linaro.org
>         <mailto:lng-odp@lists.linaro.org>>
>         http://lists.linaro.org/mailman/listinfo/lng-odp
>
>
>
>
>         _______________________________________________
>         lng-odp mailing list
>         lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org>
>         http://lists.linaro.org/mailman/listinfo/lng-odp
>
>
>
>     _______________________________________________
>     lng-odp mailing list
>     lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org>
>     http://lists.linaro.org/mailman/listinfo/lng-odp
>
>

diff --git a/test/validation/common/odp_cunit_common.c b/test/validation/common/odp_cunit_common.c
index 8fdc1ea..b8d3313 100644
--- a/test/validation/common/odp_cunit_common.c
+++ b/test/validation/common/odp_cunit_common.c
@@ -52,11 +52,11 @@  int main(void)
 	printf("\tODP implementation version: %s\n", odp_version_impl_str());
 
 	if (0 != odp_init_global(NULL, NULL)) {
-		printf("odp_init_global fail.\n");
+		fprintf(stderr, "error: odp_init_global() failed.\n");
 		return -1;
 	}
 	if (0 != odp_init_local()) {
-		printf("odp_init_local fail.\n");
+		fprintf(stderr, "error: odp_init_local() failed.\n");
 		return -1;
 	}

[1/2] validation: common: print odp_init failures to stderr

Commit Message

Comments

Patch