diff mbox series

[05/11] dt-bindings: spi: fsl-lpspi: Add imx8ulp compatible string

Message ID 20210607083921.2668568-6-ping.bai@nxp.com
State Superseded
Headers show
Series Add imx8ulp basic dtsi support | expand

Commit Message

Jacky Bai June 7, 2021, 8:39 a.m. UTC
For i.MX8ULP, it uses two compatible strings, so update the
comaptible strings.

Signed-off-by: Jacky Bai <ping.bai@nxp.com>
---
 .../devicetree/bindings/spi/spi-fsl-lpspi.yaml        | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

Comments

Dong Aisheng June 11, 2021, 1:57 p.m. UTC | #1
On Mon, Jun 7, 2021 at 4:33 PM Jacky Bai <ping.bai@nxp.com> wrote:
>

> For i.MX8ULP, it uses two compatible strings, so update the

> comaptible strings.

>

> Signed-off-by: Jacky Bai <ping.bai@nxp.com>


As previously mentioned, pls improve commit message,
otherwise:
Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com>


Regards
Aisheng

> ---

>  .../devicetree/bindings/spi/spi-fsl-lpspi.yaml        | 11 +++++++----

>  1 file changed, 7 insertions(+), 4 deletions(-)

>

> diff --git a/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml b/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml

> index 312d8fee9dbb..1d46877fe46a 100644

> --- a/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml

> +++ b/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml

> @@ -14,10 +14,13 @@ allOf:

>

>  properties:

>    compatible:

> -    enum:

> -      - fsl,imx7ulp-spi

> -      - fsl,imx8qxp-spi

> -

> +    oneOf:

> +      - enum:

> +          - fsl,imx7ulp-spi

> +          - fsl,imx8qxp-spi

> +      - items:

> +          - const: fsl,imx8ulp-spi

> +          - const: fsl,imx7ulp-spi

>    reg:

>      maxItems: 1

>

> --

> 2.26.2

>

>

> _______________________________________________

> linux-arm-kernel mailing list

> linux-arm-kernel@lists.infradead.org

> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Rob Herring (Arm) June 16, 2021, 11:45 p.m. UTC | #2
On Mon, Jun 07, 2021 at 04:39:15PM +0800, Jacky Bai wrote:
> For i.MX8ULP, it uses two compatible strings, so update the

> comaptible strings.


typo here.

> 

> Signed-off-by: Jacky Bai <ping.bai@nxp.com>

> ---

>  .../devicetree/bindings/spi/spi-fsl-lpspi.yaml        | 11 +++++++----

>  1 file changed, 7 insertions(+), 4 deletions(-)


Acked-by: Rob Herring <robh@kernel.org>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml b/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml
index 312d8fee9dbb..1d46877fe46a 100644
--- a/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml
+++ b/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml
@@ -14,10 +14,13 @@  allOf:
 
 properties:
   compatible:
-    enum:
-      - fsl,imx7ulp-spi
-      - fsl,imx8qxp-spi
-
+    oneOf:
+      - enum:
+          - fsl,imx7ulp-spi
+          - fsl,imx8qxp-spi
+      - items:
+          - const: fsl,imx8ulp-spi
+          - const: fsl,imx7ulp-spi
   reg:
     maxItems: 1