[v1,3/5] bootimg: Skip build iso image for aarch64

Message ID 1426258527-2329-4-git-send-email-naresh.bhat@linaro.org
State New
Headers show

Commit Message

naresh.bhat@linaro.org March 13, 2015, 2:55 p.m.
Build iso image required syslinux package.  We have already skip the syslinux
package.  Hence just skip the iso image build too.

Signed-off-by: Naresh Bhat <naresh.bhat@linaro.org>
---
 meta/classes/bootimg.bbclass |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

Comments

naresh.bhat@linaro.org March 16, 2015, 7:53 a.m. | #1
On 13 March 2015 at 22:47, Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
wrote:

> On March 13, 2015 5:00:15 PM GMT+01:00, Richard Purdie <
> richard.purdie@linuxfoundation.org> wrote:
> >On Fri, 2015-03-13 at 20:25 +0530, Naresh Bhat wrote:
> >> Build iso image required syslinux package.  We have already skip the
> >syslinux
> >> package.  Hence just skip the iso image build too.
> >>
> >> Signed-off-by: Naresh Bhat <naresh.bhat@linaro.org>
> >> ---
> >>  meta/classes/bootimg.bbclass |    6 +++++-
> >>  1 file changed, 5 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/meta/classes/bootimg.bbclass
> >b/meta/classes/bootimg.bbclass
> >> index ed7b32f..d8c2a59 100644
> >> --- a/meta/classes/bootimg.bbclass
> >> +++ b/meta/classes/bootimg.bbclass
> >> @@ -265,7 +265,11 @@ python do_bootimg() {
> >>      if d.getVar("EFI", True) == "1":
> >>          bb.build.exec_func('build_efi_cfg', d)
> >>      bb.build.exec_func('build_hddimg', d)
> >> -    bb.build.exec_func('build_iso', d)
> >> +
> >> +    if d.getVar('TARGET_ARCH', True) == "aarch64":
> >> +            return
> >> +    else:
> >> +            bb.build.exec_func('build_iso', d)
> >
> >Its minor but the else: here is redundant after a return.
>
> As previously asked, why does this only affect aarch64 and not all not
> COMPATIBLE_HOST ?
> Shouldn't you instead set NOISO to 1 for !COMPATIBLE_HOST ?
>
Thank you very much.  I will try it out and update in my next series.

>
> Thanks,
>
>
>

Patch

diff --git a/meta/classes/bootimg.bbclass b/meta/classes/bootimg.bbclass
index ed7b32f..d8c2a59 100644
--- a/meta/classes/bootimg.bbclass
+++ b/meta/classes/bootimg.bbclass
@@ -265,7 +265,11 @@  python do_bootimg() {
     if d.getVar("EFI", True) == "1":
         bb.build.exec_func('build_efi_cfg', d)
     bb.build.exec_func('build_hddimg', d)
-    bb.build.exec_func('build_iso', d)
+
+    if d.getVar('TARGET_ARCH', True) == "aarch64":
+            return
+    else:
+            bb.build.exec_func('build_iso', d)
 }
 
 IMAGE_TYPEDEP_iso = "ext3"