From patchwork Tue Mar 17 12:21:07 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yao Qi X-Patchwork-Id: 45880 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-we0-f199.google.com (mail-we0-f199.google.com [74.125.82.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 03D2F2153C for ; Tue, 17 Mar 2015 12:21:26 +0000 (UTC) Received: by wevk48 with SMTP id k48sf1494851wev.0 for ; Tue, 17 Mar 2015 05:21:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:mailing-list :precedence:list-id:list-unsubscribe:list-subscribe:list-archive :list-post:list-help:sender:delivered-to:from:to:subject:date :message-id:x-original-sender:x-original-authentication-results; bh=9eYqG73oefpV53xDc0JFPFQ149GzpICVXbkP6CKAUAA=; b=hAOyWXlFqPsLk3NPYqsrttCnaTNhuIInfzUbLiuOBhOoWC7U1fRTNZ3s4YyfK4YX/N XilGukOIonVi2bTAjMjQGIKKvBb/qbmQYS+/ySd5j9B0iYuC4WTAbcqMl1AUe7X7J+ln y1omi/jBjl+XflBD4GG+bCD+q70AqBrQRUpulimGYJMRzkb7BKKvhZb1KOIiRQL4keAq X1KoIjlb4bz8C0THGteYtHlPoIHUYiQsuuP7sd1h3QVsLXNXGo3PW0ubVbzq+PC1oGZs 8kpy65ptBw80xh3eEuXXfD4ofZKuEKijmiab28EmEkODRaYQEKdgpPuI4wNp9F4tJ1qU 2kGA== X-Gm-Message-State: ALoCoQlY50LxKNxFWjY8ykXuglBA4IN3hDC4P8OL0lJ2MJNhcw3/ocBz+1+gC3IsTFv33N56mCk4 X-Received: by 10.112.25.7 with SMTP id y7mr9848097lbf.21.1426594885281; Tue, 17 Mar 2015 05:21:25 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.242.132 with SMTP id wq4ls32880lac.30.gmail; Tue, 17 Mar 2015 05:21:25 -0700 (PDT) X-Received: by 10.112.163.229 with SMTP id yl5mr59215408lbb.60.1426594884998; Tue, 17 Mar 2015 05:21:24 -0700 (PDT) Received: from mail-la0-x22b.google.com (mail-la0-x22b.google.com. [2a00:1450:4010:c03::22b]) by mx.google.com with ESMTPS id d9si10400580lad.116.2015.03.17.05.21.24 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Mar 2015 05:21:24 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 2a00:1450:4010:c03::22b as permitted sender) client-ip=2a00:1450:4010:c03::22b; Received: by labjg1 with SMTP id jg1so6829921lab.2 for ; Tue, 17 Mar 2015 05:21:24 -0700 (PDT) X-Received: by 10.152.116.65 with SMTP id ju1mr40046566lab.32.1426594884904; Tue, 17 Mar 2015 05:21:24 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.35.133 with SMTP id h5csp469541lbj; Tue, 17 Mar 2015 05:21:24 -0700 (PDT) X-Received: by 10.66.222.7 with SMTP id qi7mr153079068pac.15.1426594883157; Tue, 17 Mar 2015 05:21:23 -0700 (PDT) Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id hf1si28996029pac.201.2015.03.17.05.21.22 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Mar 2015 05:21:23 -0700 (PDT) Received-SPF: pass (google.com: domain of gdb-patches-return-120818-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Received: (qmail 49680 invoked by alias); 17 Mar 2015 12:21:16 -0000 Mailing-List: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org Precedence: list List-Id: List-Unsubscribe: , List-Subscribe: List-Archive: List-Post: , List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 49647 invoked by uid 89); 17 Mar 2015 12:21:15 -0000 X-Virus-Found: No X-Spam-SWARE-Status: No, score=2.3 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, KAM_FROM_URIBL_PCCC, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=no version=3.3.2 X-HELO: mail-pd0-f180.google.com Received: from mail-pd0-f180.google.com (HELO mail-pd0-f180.google.com) (209.85.192.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 17 Mar 2015 12:21:14 +0000 Received: by pdbcz9 with SMTP id cz9so8272683pdb.3 for ; Tue, 17 Mar 2015 05:21:13 -0700 (PDT) X-Received: by 10.67.5.230 with SMTP id cp6mr109515277pad.55.1426594872994; Tue, 17 Mar 2015 05:21:12 -0700 (PDT) Received: from E107787-LIN.cambridge.arm.com (gcc1-power7.osuosl.org. [140.211.15.137]) by mx.google.com with ESMTPSA id ey1sm22219744pdb.30.2015.03.17.05.21.11 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 17 Mar 2015 05:21:12 -0700 (PDT) From: Yao Qi To: gdb-patches@sourceware.org Subject: [PATCH] Don't call set_gdbarch_cannot_step_breakpoint in aarch64_gdbarch_init Date: Tue, 17 Mar 2015 12:21:07 +0000 Message-Id: <1426594867-21302-1-git-send-email-qiyaoltc@gmail.com> X-IsSubscribed: yes X-Original-Sender: qiyaoltc@gmail.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 2a00:1450:4010:c03::22b as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org; dkim=pass header.i=@sourceware.org; dmarc=fail (p=NONE dis=NONE) header.from=gmail.com X-Google-Group-Id: 836684582541 From: Yao Qi Hi, I am looking at the following fails in aarch64-linux, stepi^M 47 NOP; /* after permanent bp */^M (gdb) FAIL: gdb.base/bp-permanent.exp: always_inserted=off, sw_watchpoint=0: stepi signal with handler: single-step to handler the test expects GDB single step into signal handler, but GDB doesn't. The code in infrun.c:resume /* Most targets can step a breakpoint instruction, thus executing it normally. But if this one cannot, just continue and we will hit it anyway. */ if (gdbarch_cannot_step_breakpoint (gdbarch)) step = 0; change the intended action from "step" to "continue". The gdbarch method cannot_step_breakpoint isn't documented well, and I don't get much clue after explore the history. However, from the comments above, aarch64-linux can step a breakpoint instruction, so don't need to call set_gdbarch_cannot_step_breakpoint. Regression tested on aarch64-linux, both native and gdbserver. gdb: 2015-03-17 Yao Qi * aarch64-tdep.c (aarch64_gdbarch_init): Don't call set_gdbarch_cannot_step_breakpoint. --- gdb/aarch64-tdep.c | 1 - 1 file changed, 1 deletion(-) diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c index 472ce70..ddc9022 100644 --- a/gdb/aarch64-tdep.c +++ b/gdb/aarch64-tdep.c @@ -2698,7 +2698,6 @@ aarch64_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches) /* Breakpoint manipulation. */ set_gdbarch_breakpoint_from_pc (gdbarch, aarch64_breakpoint_from_pc); - set_gdbarch_cannot_step_breakpoint (gdbarch, 1); set_gdbarch_have_nonsteppable_watchpoint (gdbarch, 1); set_gdbarch_software_single_step (gdbarch, aarch64_software_single_step);