| Message ID | 20210615135554.29158-1-wanghai38@huawei.com |
|---|---|
| State | New |
| Headers | show |
| Series | [bpf-next] samples/bpf: Add missing option to xdp_fwd usage | expand |
On Tue, 15 Jun 2021 21:55:54 +0800 Wang Hai <wanghai38@huawei.com> wrote: > xdp_fwd usage() is missing the introduction of the "-S" > and "-F" options, this patch adds it. > > Signed-off-by: Wang Hai <wanghai38@huawei.com> > --- > samples/bpf/xdp_fwd_user.c | 2 ++ > 1 file changed, 2 insertions(+) Fixes: d50ecc46d18f ("samples/bpf: Attach XDP programs in driver mode by default") LGTM but please add "Fixes:" tag next time, I think patchwork will pick this up via this reply. Acked-by: Jesper Dangaard Brouer <brouer@redhat.com> > diff --git a/samples/bpf/xdp_fwd_user.c b/samples/bpf/xdp_fwd_user.c > index 74a4583d0d86..00061261a8da 100644 > --- a/samples/bpf/xdp_fwd_user.c > +++ b/samples/bpf/xdp_fwd_user.c > @@ -67,6 +67,8 @@ static void usage(const char *prog) > "usage: %s [OPTS] interface-list\n" > "\nOPTS:\n" > " -d detach program\n" > + " -S use skb-mode\n" > + " -F force loading prog\n" > " -D direct table lookups (skip fib rules)\n", > prog); > } - -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer
diff --git a/samples/bpf/xdp_fwd_user.c b/samples/bpf/xdp_fwd_user.c index 74a4583d0d86..00061261a8da 100644 --- a/samples/bpf/xdp_fwd_user.c +++ b/samples/bpf/xdp_fwd_user.c @@ -67,6 +67,8 @@ static void usage(const char *prog) "usage: %s [OPTS] interface-list\n" "\nOPTS:\n" " -d detach program\n" + " -S use skb-mode\n" + " -F force loading prog\n" " -D direct table lookups (skip fib rules)\n", prog); }
xdp_fwd usage() is missing the introduction of the "-S" and "-F" options, this patch adds it. Signed-off-by: Wang Hai <wanghai38@huawei.com> --- samples/bpf/xdp_fwd_user.c | 2 ++ 1 file changed, 2 insertions(+)