From patchwork Fri Mar 20 11:44:00 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Lezcano X-Patchwork-Id: 46140 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-la0-f70.google.com (mail-la0-f70.google.com [209.85.215.70]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 9E08721418 for ; Fri, 20 Mar 2015 11:45:04 +0000 (UTC) Received: by lams18 with SMTP id s18sf17069158lam.2 for ; Fri, 20 Mar 2015 04:45:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=bidCYBdOBucBl/+9c4QQcz5PpfnBgo1Uz4ZJgXsgZhA=; b=d2l3WGMLvL/V2e8hdMILJ+DpW3kt1XPREi4EcOMwM7eNw+vz653JDApT4VL4sANHfu VjSgd7jvw2wL5j3QX4db65xvXCFNI55iCvlgkh3NhddpDSvE5iz8pN1AK/x0F4DoVuuq zW5de5W6K3kXP3Td5dqruGiUxr9uEOUgmWKqblig45M6ZlUJyAODZhcn8NyNDZbLJeLz edDPh4iqHXvml6nh2RipZcGlzelKn4GE+BB9N2sFzdyAcwP1BCmF9RkXdwDFt6ZaL6E7 chRf8C4kJujQ33GuFayV9RcsSW0XRfoxA/atLsRX/mO3b1hFyPlXuTTEdPSKTkX/CSj7 sqrA== X-Gm-Message-State: ALoCoQmOu3neUX9yC4MvPDDEGvKxTyXkdUXyv6OyQ5WpgqDcUbVPbMwmd4ZiKV27DSf2gZ/DjCZs X-Received: by 10.181.29.66 with SMTP id ju2mr2667069wid.1.1426851903602; Fri, 20 Mar 2015 04:45:03 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.179.4 with SMTP id dc4ls412836lac.73.gmail; Fri, 20 Mar 2015 04:45:03 -0700 (PDT) X-Received: by 10.112.131.66 with SMTP id ok2mr69442343lbb.51.1426851903308; Fri, 20 Mar 2015 04:45:03 -0700 (PDT) Received: from mail-la0-f53.google.com (mail-la0-f53.google.com. [209.85.215.53]) by mx.google.com with ESMTPS id sr5si3016218lbb.113.2015.03.20.04.45.03 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 20 Mar 2015 04:45:03 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.53 as permitted sender) client-ip=209.85.215.53; Received: by labe2 with SMTP id e2so9518625lab.3 for ; Fri, 20 Mar 2015 04:45:03 -0700 (PDT) X-Received: by 10.112.162.232 with SMTP id yd8mr6229597lbb.41.1426851903159; Fri, 20 Mar 2015 04:45:03 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.35.133 with SMTP id h5csp968090lbj; Fri, 20 Mar 2015 04:45:01 -0700 (PDT) X-Received: by 10.70.119.37 with SMTP id kr5mr425972pdb.107.1426851890658; Fri, 20 Mar 2015 04:44:50 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ry1si8717553pab.199.2015.03.20.04.44.49; Fri, 20 Mar 2015 04:44:50 -0700 (PDT) Received-SPF: none (google.com: linux-pm-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752073AbbCTLoY (ORCPT + 11 others); Fri, 20 Mar 2015 07:44:24 -0400 Received: from mail-wi0-f182.google.com ([209.85.212.182]:38366 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752063AbbCTLoW (ORCPT ); Fri, 20 Mar 2015 07:44:22 -0400 Received: by wibgn9 with SMTP id gn9so11652658wib.1 for ; Fri, 20 Mar 2015 04:44:20 -0700 (PDT) X-Received: by 10.194.171.100 with SMTP id at4mr138078321wjc.122.1426851860779; Fri, 20 Mar 2015 04:44:20 -0700 (PDT) Received: from mai.lan (135-224-190-109.dsl.ovh.fr. [109.190.224.135]) by mx.google.com with ESMTPSA id m4sm6007225wjb.25.2015.03.20.04.44.18 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 20 Mar 2015 04:44:20 -0700 (PDT) From: Daniel Lezcano To: rjw@rjwysocki.net, lorenzo.pieralisi@arm.com Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Catalin.Marinas@arm.com, robherring2@gmail.com, arnd@arndb.de, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, lina.iyer@linaro.org, sboyd@codeaurora.org Subject: [PATCH V3 7/8] ARM: cpuidle: Register per cpuidle device Date: Fri, 20 Mar 2015 12:44:00 +0100 Message-Id: <1426851841-2072-8-git-send-email-daniel.lezcano@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1426851841-2072-1-git-send-email-daniel.lezcano@linaro.org> References: <1426851841-2072-1-git-send-email-daniel.lezcano@linaro.org> Sender: linux-pm-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: daniel.lezcano@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.53 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Some architectures have some cpus which does not support idle states. Let the underlying low level code to return -ENXIO when it is not possible to set an idle state. Signed-off-by: Daniel Lezcano --- drivers/cpuidle/cpuidle-arm.c | 42 ++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 40 insertions(+), 2 deletions(-) diff --git a/drivers/cpuidle/cpuidle-arm.c b/drivers/cpuidle/cpuidle-arm.c index 1c94b88..e4a6eba 100644 --- a/drivers/cpuidle/cpuidle-arm.c +++ b/drivers/cpuidle/cpuidle-arm.c @@ -17,6 +17,7 @@ #include #include #include +#include #include @@ -94,6 +95,7 @@ static int __init arm_idle_init(void) { int cpu, ret; struct cpuidle_driver *drv = &arm_idle_driver; + struct cpuidle_device *dev; /* * Initialize idle states data, starting at index 1. @@ -105,18 +107,54 @@ static int __init arm_idle_init(void) if (ret <= 0) return ret ? : -ENODEV; + ret = cpuidle_register_driver(drv); + if (ret) { + pr_err("Failed to register cpuidle driver\n"); + return ret; + } + /* * Call arch CPU operations in order to initialize * idle states suspend back-end specific data */ for_each_possible_cpu(cpu) { ret = arm_cpuidle_init(cpu); + + /* This cpu does not support any idle states */ + if (ret == -ENXIO) + continue; + if (ret) { pr_err("CPU %d failed to init idle CPU ops\n", cpu); - return ret; + goto out_fail; + } + + dev = kzalloc(sizeof(*dev), GFP_KERNEL); + if (!dev) { + pr_err("Failed to allocate cpuidle device\n"); + goto out_fail; + } + dev->cpu = cpu; + + ret = cpuidle_register_device(dev); + if (ret) { + pr_err("Failed to register cpuidle device for CPU %d\n", + cpu); + kfree(dev); + goto out_fail; } } - return cpuidle_register(drv, NULL); + return 0; +out_fail: + while (--cpu >= 0) { + dev = per_cpu(cpuidle_devices, cpu); + cpuidle_unregister_device(dev); + kfree(dev); + } + + cpuidle_unregister_driver(drv); + + return ret; } device_initcall(arm_idle_init);