diff mbox

[PATCHv3] validation: packet: use non-zero as true indicator

Message ID 1427386066-3289-1-git-send-email-bill.fischofer@linaro.org
State Accepted
Commit 744aa99d25a97aaae4499521f27321f5bb0680b9
Headers show

Commit Message

Bill Fischofer March 26, 2015, 4:07 p.m. UTC
This change addresses Bug https://bugs.linaro.org/show_bug.cgi?id=1334

Signed-off-by: Bill Fischofer <bill.fischofer@linaro.org>
---

Note that for v3 this patch is split. The test change doe not affect
the ODP API and hence can be merged as part of the next ODP maintenance
release. The API change (just doxygen) is posted to API-NEXT for
inclusion in the next API update release.

 test/validation/odp_packet.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
2.1.0

Comments

Maxim Uvarov March 27, 2015, 3:21 p.m. UTC | #1
Merged,
Maxim.

On 03/27/15 11:18, Savolainen, Petri (Nokia - FI/Espoo) wrote:
> Reviewed-by: Petri Savolainen <petri.savolainen@nokia.com>
>
>> -----Original Message-----
>> From: lng-odp-bounces@lists.linaro.org [mailto:lng-odp-
>> bounces@lists.linaro.org] On Behalf Of ext Bill Fischofer
>> Sent: Thursday, March 26, 2015 6:08 PM
>> To: lng-odp@lists.linaro.org
>> Subject: [lng-odp] [PATCHv3] validation: packet: use non-zero as true
>> indicator
>>
>> This change addresses Bug https://bugs.linaro.org/show_bug.cgi?id=1334
>>
>> Signed-off-by: Bill Fischofer <bill.fischofer@linaro.org>
>> ---
>>
>> Note that for v3 this patch is split. The test change doe not affect
>> the ODP API and hence can be merged as part of the next ODP maintenance
>> release. The API change (just doxygen) is posted to API-NEXT for
>> inclusion in the next API update release.
>>
>>   test/validation/odp_packet.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/test/validation/odp_packet.c b/test/validation/odp_packet.c
>> index 8f764bf..0c1d069 100644
>> --- a/test/validation/odp_packet.c
>> +++ b/test/validation/odp_packet.c
>> @@ -425,7 +425,7 @@ do { \
>>   	odp_packet_has_##flag##_set(packet, 0);           \
>>   	CU_ASSERT(odp_packet_has_##flag(packet) == 0);    \
>>   	odp_packet_has_##flag##_set(packet, 1);           \
>> -	CU_ASSERT(odp_packet_has_##flag(packet) == 1);    \
>> +	CU_ASSERT(odp_packet_has_##flag(packet) != 0);    \
>>   } while (0)
>>
>>   static void packet_in_flags(void)
>> --
>> 2.1.0
>>
>> _______________________________________________
>> lng-odp mailing list
>> lng-odp@lists.linaro.org
>> http://lists.linaro.org/mailman/listinfo/lng-odp
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> http://lists.linaro.org/mailman/listinfo/lng-odp
diff mbox

Patch

diff --git a/test/validation/odp_packet.c b/test/validation/odp_packet.c
index 8f764bf..0c1d069 100644
--- a/test/validation/odp_packet.c
+++ b/test/validation/odp_packet.c
@@ -425,7 +425,7 @@  do { \
 	odp_packet_has_##flag##_set(packet, 0);           \
 	CU_ASSERT(odp_packet_has_##flag(packet) == 0);    \
 	odp_packet_has_##flag##_set(packet, 1);           \
-	CU_ASSERT(odp_packet_has_##flag(packet) == 1);    \
+	CU_ASSERT(odp_packet_has_##flag(packet) != 0);    \
 } while (0)

 static void packet_in_flags(void)