diff mbox series

[net-next,2/7] net: ocelot: delete call to br_fdb_replay

Message ID 20210625185321.626325-3-olteanv@gmail.com
State New
Headers show
Series Cleanup for the bridge replay helpers | expand

Commit Message

Vladimir Oltean June 25, 2021, 6:53 p.m. UTC 
From: Vladimir Oltean <vladimir.oltean@nxp.com>

Not using this driver, I did not realize it doesn't react to
SWITCHDEV_FDB_{ADD,DEL}_TO_DEVICE notifications, but it implements just
the bridge bypass operations (.ndo_fdb_{add,del}). So the call to
br_fdb_replay just produces notifications that are ignored, delete it
for now.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
 drivers/net/ethernet/mscc/ocelot_net.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

Florian Fainelli June 27, 2021, 2:55 a.m. UTC | #1 
On 6/25/2021 11:53 AM, Vladimir Oltean wrote:
> From: Vladimir Oltean <vladimir.oltean@nxp.com>

> 

> Not using this driver, I did not realize it doesn't react to

> SWITCHDEV_FDB_{ADD,DEL}_TO_DEVICE notifications, but it implements just

> the bridge bypass operations (.ndo_fdb_{add,del}). So the call to

> br_fdb_replay just produces notifications that are ignored, delete it

> for now.

> 

> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>


Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>

-- 
Florian
diff mbox series

Patch

diff --git a/drivers/net/ethernet/mscc/ocelot_net.c b/drivers/net/ethernet/mscc/ocelot_net.c
index aad33d22c33f..4fc74ee4aaab 100644
--- a/drivers/net/ethernet/mscc/ocelot_net.c
+++ b/drivers/net/ethernet/mscc/ocelot_net.c
@@ -1165,10 +1165,6 @@  static int ocelot_switchdev_sync(struct ocelot *ocelot, int port,
 	if (err && err != -EOPNOTSUPP)
 		return err;
 
-	err = br_fdb_replay(bridge_dev, brport_dev, &ocelot_switchdev_nb);
-	if (err)
-		return err;
-
 	err = br_vlan_replay(bridge_dev, brport_dev,
 			     &ocelot_switchdev_blocking_nb, extack);
 	if (err && err != -EOPNOTSUPP)