gas thunderx support

Message ID CABXYE2VCDjNyuyUvrvymGFV9x_C8O3N55K8RVd-uemcW=iU=cg@mail.gmail.com
State New
Headers show

Commit Message

Jim Wilson April 23, 2015, 10:58 p.m.
I noticed an inconsistency between gas and gcc.  The gcc
config/aarch64/aarch64-cores.def file says that thunderx has crc and
crypto support.  The gas config/tc-aarch64.c file says it doesn't.
Andrew Pinski recentlly posted some thunderx /proc/cpuinfo output on
the gcc list that makes it clear that thunderx does have crc and
crypto support.  So gas needs to be fixed.

This was tested by using some gcc testsuite test cases to generate
assembly files with crc and crypto instructions, and noting that they
would not assemble when using ".cpu thunderx" without the patch, but
they do assemble with the patch.

Jim

Comments

Jim Wilson April 24, 2015, 8:48 p.m. | #1
On Fri, Apr 24, 2015 at 1:53 AM, Marcus Shawcroft
<marcus.shawcroft@gmail.com> wrote:
> On 23 April 2015 at 23:58, Jim Wilson <jim.wilson@linaro.org> wrote:
> You have a typo in the filename here, otherwise OK. Thanks /Marcus

Thanks.  Checked in with the typo fixed.

Jim

Patch hide | download patch | download mbox

gas/

	* config/tc-aatch64.c (aarch64_cpus): Add CRC and CRYPTO features
	for thunderx.

diff --git a/gas/config/tc-aarch64.c b/gas/config/tc-aarch64.c
index 5492ff4..dec50c7 100644
--- a/gas/config/tc-aarch64.c
+++ b/gas/config/tc-aarch64.c
@@ -7327,7 +7327,9 @@  static const struct aarch64_cpu_option_table aarch64_cpus[] = {
   {"exynos-m1", AARCH64_FEATURE (AARCH64_ARCH_V8,
 				 AARCH64_FEATURE_CRC | AARCH64_FEATURE_CRYPTO),
 				"Samsung Exynos M1"},
-  {"thunderx", AARCH64_ARCH_V8, "Cavium ThunderX"},
+  {"thunderx", AARCH64_FEATURE (AARCH64_ARCH_V8,
+				AARCH64_FEATURE_CRC | AARCH64_FEATURE_CRYPTO),
+   "Cavium ThunderX"},
   /* The 'xgene-1' name is an older name for 'xgene1', which was used
      in earlier releases and is superseded by 'xgene1' in all
      tools.  */