From patchwork Thu Apr 23 22:58:18 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jim Wilson X-Patchwork-Id: 47480 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-la0-f70.google.com (mail-la0-f70.google.com [209.85.215.70]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 224722121F for ; Thu, 23 Apr 2015 22:58:43 +0000 (UTC) Received: by lamp14 with SMTP id p14sf8159385lam.3 for ; Thu, 23 Apr 2015 15:58:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:mailing-list:precedence:list-id :list-unsubscribe:list-subscribe:list-archive:list-post:list-help :sender:delivered-to:mime-version:date:message-id:subject:from:to :content-type:x-original-sender:x-original-authentication-results; bh=iqYznAtJqiMk/kWmr48x+iVmvxJro94E36hp6lw/E8I=; b=WwhF5/ehBsTBmH47v+xLAbUW0TyYaD8nvnjdOszd+AIp8kQNIGb+QiS16e472XecEn PK96p93gHj5tQf0NhwcJP4QopieJkiR5yxrCsA3U4EcBpksmQ6qwjq/+bIfAQCocpirD i8/pqhO6i2yrXPhhQBwOV2AI0mKBWQUkMqbowxREvedMS5DUV7wL1NG7dIrs/yVnaSKk GJ/ca6EYGhcBuz/J0dkkfCmgtKY4r4Xq1soG1/RZEU3w1Rw5dLcGYk1X09rtcwEQrXz6 6fp2ttNosuvcLzrm83hIa6Oo1o9rk8jKzHBQ4spYaARPJHuOuFLbfISf+tt74JrSzKb6 wtwA== X-Gm-Message-State: ALoCoQnoA+0xx00TNr2qS6Cv8YRiJ9O4ReeJMyqiqskZ7kPKkZ7pFOeAcMMgWopxadfSMsixKo7v X-Received: by 10.112.26.5 with SMTP id h5mr2579425lbg.4.1429829922143; Thu, 23 Apr 2015 15:58:42 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.19.231 with SMTP id i7ls383740lae.85.gmail; Thu, 23 Apr 2015 15:58:41 -0700 (PDT) X-Received: by 10.152.121.72 with SMTP id li8mr4330594lab.11.1429829921930; Thu, 23 Apr 2015 15:58:41 -0700 (PDT) Received: from mail-la0-x229.google.com (mail-la0-x229.google.com. [2a00:1450:4010:c03::229]) by mx.google.com with ESMTPS id le4si6927585lac.158.2015.04.23.15.58.41 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 23 Apr 2015 15:58:41 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 2a00:1450:4010:c03::229 as permitted sender) client-ip=2a00:1450:4010:c03::229; Received: by labbd9 with SMTP id bd9so23223504lab.2 for ; Thu, 23 Apr 2015 15:58:41 -0700 (PDT) X-Received: by 10.152.205.6 with SMTP id lc6mr1891576lac.73.1429829921654; Thu, 23 Apr 2015 15:58:41 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.67.65 with SMTP id l1csp847916lbt; Thu, 23 Apr 2015 15:58:40 -0700 (PDT) X-Received: by 10.68.65.38 with SMTP id u6mr9386531pbs.41.1429829919436; Thu, 23 Apr 2015 15:58:39 -0700 (PDT) Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id ew7si14520074pac.200.2015.04.23.15.58.38 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 23 Apr 2015 15:58:39 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-return-87538-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Received: (qmail 114865 invoked by alias); 23 Apr 2015 22:58:23 -0000 Mailing-List: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org Precedence: list List-Id: List-Unsubscribe: , List-Subscribe: List-Archive: List-Post: , List-Help: , Sender: binutils-owner@sourceware.org Delivered-To: mailing list binutils@sourceware.org Received: (qmail 114855 invoked by uid 89); 23 Apr 2015 22:58:22 -0000 X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.8 required=5.0 tests=AWL, BAYES_40, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-qg0-f49.google.com Received: from mail-qg0-f49.google.com (HELO mail-qg0-f49.google.com) (209.85.192.49) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 23 Apr 2015 22:58:21 +0000 Received: by qgej70 with SMTP id j70so15424131qge.2 for ; Thu, 23 Apr 2015 15:58:19 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.140.102.180 with SMTP id w49mr5988674qge.82.1429829898881; Thu, 23 Apr 2015 15:58:18 -0700 (PDT) Received: by 10.140.98.213 with HTTP; Thu, 23 Apr 2015 15:58:18 -0700 (PDT) Date: Thu, 23 Apr 2015 15:58:18 -0700 Message-ID: Subject: gas thunderx support From: Jim Wilson To: binutils@sourceware.org X-Original-Sender: jim.wilson@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 2a00:1450:4010:c03::229 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org; dkim=pass header.i=@sourceware.org X-Google-Group-Id: 836684582541 I noticed an inconsistency between gas and gcc. The gcc config/aarch64/aarch64-cores.def file says that thunderx has crc and crypto support. The gas config/tc-aarch64.c file says it doesn't. Andrew Pinski recentlly posted some thunderx /proc/cpuinfo output on the gcc list that makes it clear that thunderx does have crc and crypto support. So gas needs to be fixed. This was tested by using some gcc testsuite test cases to generate assembly files with crc and crypto instructions, and noting that they would not assemble when using ".cpu thunderx" without the patch, but they do assemble with the patch. Jim gas/ * config/tc-aatch64.c (aarch64_cpus): Add CRC and CRYPTO features for thunderx. diff --git a/gas/config/tc-aarch64.c b/gas/config/tc-aarch64.c index 5492ff4..dec50c7 100644 --- a/gas/config/tc-aarch64.c +++ b/gas/config/tc-aarch64.c @@ -7327,7 +7327,9 @@ static const struct aarch64_cpu_option_table aarch64_cpus[] = { {"exynos-m1", AARCH64_FEATURE (AARCH64_ARCH_V8, AARCH64_FEATURE_CRC | AARCH64_FEATURE_CRYPTO), "Samsung Exynos M1"}, - {"thunderx", AARCH64_ARCH_V8, "Cavium ThunderX"}, + {"thunderx", AARCH64_FEATURE (AARCH64_ARCH_V8, + AARCH64_FEATURE_CRC | AARCH64_FEATURE_CRYPTO), + "Cavium ThunderX"}, /* The 'xgene-1' name is an older name for 'xgene1', which was used in earlier releases and is superseded by 'xgene1' in all tools. */