| Message ID | 1430851424-23352-1-git-send-email-mike.holmes@linaro.org |
|---|---|
| State | New |
| Headers | show |
On 6 May 2015 at 03:30, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolainen@nokia.com> wrote: > Hi, > > This is pure implementation change and thus does not belong to api-next > (but master). I agree the code is implementation, but the change in the release numbering is significant and coupled to the doc <https://docs.google.com/document/d/1jCWRW9yHbzNp8dmZ1X8ZNQB1YzKyZbipoYY101Uhkhg/edit> clarification so I wanted to make sure it was seen by all/ This has to be in 1.1.0 > Also the string could contain more information, à la Linux "uname -a" e.g. > > linux-generic: > "Linaro/LNG linux-generic 1.0.1-5 (ODP v1.0.1) Wed May 6 10:17:46 UTC 2015" > > linux-dpdk: > "Linaro/LNG linux-dpdk 1.0.1-13 (ODP v1.0.1, DPDK v1.8) Fri May 15 > 17:05:55 UTC 2015" > > > The minimum string would be "linux-generic 1.0.1-5", but I think it's good > to explicitly list ODP API version, DPDK (and other strict lib) version > dependency, the organization and build date. It's helps bug reporting/etc, > when it's clear which API version/code base/build the user is running. > Sure, lets add platform to the string and build date to linux -generic, the dpdk platform can add DPDK version. > > > -Petri > > > > -----Original Message----- > > From: lng-odp [mailto:lng-odp-bounces@lists.linaro.org] On Behalf Of ext > > Mike Holmes > > Sent: Tuesday, May 05, 2015 9:44 PM > > To: lng-odp@lists.linaro.org > > Subject: [lng-odp] [API-NEXT PATCH] linux-generic: odp_impl: concatenate > > api version with implementation version > > > > Signed-off-by: Mike Holmes <mike.holmes@linaro.org> > > --- > > platform/linux-generic/odp_impl.c | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/platform/linux-generic/odp_impl.c b/platform/linux- > > generic/odp_impl.c > > index ca3224d..a182bc6 100644 > > --- a/platform/linux-generic/odp_impl.c > > +++ b/platform/linux-generic/odp_impl.c > > @@ -21,7 +21,11 @@ extern "C" { > > #include <odp/version.h> > > > > #define ODP_VERSION_IMPL 0 > > -#define ODP_VERSION_IMPL_STR ODP_VERSION_TO_STR(ODP_VERSION_IMPL) > > +#define ODP_VERSION_IMPL_STR \ > > + ODP_VERSION_TO_STR(ODP_VERSION_API_GENERATION) "." \ > > + ODP_VERSION_TO_STR(ODP_VERSION_API_MAJOR) "." \ > > + ODP_VERSION_TO_STR(ODP_VERSION_API_MINOR) "-" \ > > + ODP_VERSION_TO_STR(ODP_VERSION_IMPL) > > > > const char *odp_version_impl_str(void) > > { > > -- > > 2.1.4 > > > > _______________________________________________ > > lng-odp mailing list > > lng-odp@lists.linaro.org > > https://lists.linaro.org/mailman/listinfo/lng-odp >
Are we happy with this output from the test? I think the owner is well known, and adding "Linaro/LNG" feels wrong to me - do people feel strongly that we add an owner ODP API version: 1.0.4 ODP implementation version: linux-generic 1.0.4-0 (v1.0.4) May 6 201507:54:33 On 6 May 2015 at 07:06, Mike Holmes <mike.holmes@linaro.org> wrote: > > > On 6 May 2015 at 03:30, Savolainen, Petri (Nokia - FI/Espoo) < > petri.savolainen@nokia.com> wrote: > >> Hi, >> >> This is pure implementation change and thus does not belong to api-next >> (but master). > > > I agree the code is implementation, but the change in the release > numbering is significant and coupled to the doc > <https://docs.google.com/document/d/1jCWRW9yHbzNp8dmZ1X8ZNQB1YzKyZbipoYY101Uhkhg/edit> clarification > so I wanted to make sure it was seen by all/ This has to be in 1.1.0 > > >> Also the string could contain more information, à la Linux "uname -a" e.g. >> >> linux-generic: >> "Linaro/LNG linux-generic 1.0.1-5 (ODP v1.0.1) Wed May 6 10:17:46 UTC >> 2015" >> >> linux-dpdk: >> "Linaro/LNG linux-dpdk 1.0.1-13 (ODP v1.0.1, DPDK v1.8) Fri May 15 >> 17:05:55 UTC 2015" >> >> >> The minimum string would be "linux-generic 1.0.1-5", but I think it's >> good to explicitly list ODP API version, DPDK (and other strict lib) >> version dependency, the organization and build date. It's helps bug >> reporting/etc, when it's clear which API version/code base/build the user >> is running. >> > > Sure, lets add platform to the string and build date to linux -generic, > the dpdk platform can add DPDK version. > > >> >> >> -Petri >> >> >> > -----Original Message----- >> > From: lng-odp [mailto:lng-odp-bounces@lists.linaro.org] On Behalf Of >> ext >> > Mike Holmes >> > Sent: Tuesday, May 05, 2015 9:44 PM >> > To: lng-odp@lists.linaro.org >> > Subject: [lng-odp] [API-NEXT PATCH] linux-generic: odp_impl: concatenate >> > api version with implementation version >> > >> > Signed-off-by: Mike Holmes <mike.holmes@linaro.org> >> > --- >> > platform/linux-generic/odp_impl.c | 6 +++++- >> > 1 file changed, 5 insertions(+), 1 deletion(-) >> > >> > diff --git a/platform/linux-generic/odp_impl.c b/platform/linux- >> > generic/odp_impl.c >> > index ca3224d..a182bc6 100644 >> > --- a/platform/linux-generic/odp_impl.c >> > +++ b/platform/linux-generic/odp_impl.c >> > @@ -21,7 +21,11 @@ extern "C" { >> > #include <odp/version.h> >> > >> > #define ODP_VERSION_IMPL 0 >> > -#define ODP_VERSION_IMPL_STR ODP_VERSION_TO_STR(ODP_VERSION_IMPL) >> > +#define ODP_VERSION_IMPL_STR \ >> > + ODP_VERSION_TO_STR(ODP_VERSION_API_GENERATION) "." \ >> > + ODP_VERSION_TO_STR(ODP_VERSION_API_MAJOR) "." \ >> > + ODP_VERSION_TO_STR(ODP_VERSION_API_MINOR) "-" \ >> > + ODP_VERSION_TO_STR(ODP_VERSION_IMPL) >> > >> > const char *odp_version_impl_str(void) >> > { >> > -- >> > 2.1.4 >> > >> > _______________________________________________ >> > lng-odp mailing list >> > lng-odp@lists.linaro.org >> > https://lists.linaro.org/mailman/listinfo/lng-odp >> > > > > -- > Mike Holmes > Technical Manager - Linaro Networking Group > Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs > > >
diff --git a/platform/linux-generic/odp_impl.c b/platform/linux-generic/odp_impl.c index ca3224d..a182bc6 100644 --- a/platform/linux-generic/odp_impl.c +++ b/platform/linux-generic/odp_impl.c @@ -21,7 +21,11 @@ extern "C" { #include <odp/version.h> #define ODP_VERSION_IMPL 0 -#define ODP_VERSION_IMPL_STR ODP_VERSION_TO_STR(ODP_VERSION_IMPL) +#define ODP_VERSION_IMPL_STR \ + ODP_VERSION_TO_STR(ODP_VERSION_API_GENERATION) "." \ + ODP_VERSION_TO_STR(ODP_VERSION_API_MAJOR) "." \ + ODP_VERSION_TO_STR(ODP_VERSION_API_MINOR) "-" \ + ODP_VERSION_TO_STR(ODP_VERSION_IMPL) const char *odp_version_impl_str(void) {
Signed-off-by: Mike Holmes <mike.holmes@linaro.org> --- platform/linux-generic/odp_impl.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)