diff mbox series

[V4,1/5] dt-bindings: virtio: Add binding for virtio devices

Message ID d8319fd18df7086b12cdcc23193c313893aa071a.1627362340.git.viresh.kumar@linaro.org
State New
Headers show
Series virtio: Add virtio-device bindings | expand

Commit Message

Viresh Kumar July 27, 2021, 5:23 a.m. UTC
Allow virtio device sub-nodes to be added to the virtio mmio or pci
nodes. The compatible property for virtio device must be of the format
"virtio,device<ID>", where ID is virtio device ID in hexadecimal format.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

---
 .../devicetree/bindings/virtio/mmio.yaml      |  3 +-
 .../bindings/virtio/virtio-device.yaml        | 41 +++++++++++++++++++
 2 files changed, 43 insertions(+), 1 deletion(-)
 create mode 100644 Documentation/devicetree/bindings/virtio/virtio-device.yaml

-- 
2.31.1.272.g89b43f80a514

Comments

Arnd Bergmann July 27, 2021, 7:51 a.m. UTC | #1
On Tue, Jul 27, 2021 at 7:23 AM Viresh Kumar <viresh.kumar@linaro.org> wrote:
>

> Allow virtio device sub-nodes to be added to the virtio mmio or pci

> nodes. The compatible property for virtio device must be of the format

> "virtio,device<ID>", where ID is virtio device ID in hexadecimal format.

>

> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>


Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Rob Herring Aug. 2, 2021, 7:40 p.m. UTC | #2
On Tue, 27 Jul 2021 10:53:48 +0530, Viresh Kumar wrote:
> Allow virtio device sub-nodes to be added to the virtio mmio or pci

> nodes. The compatible property for virtio device must be of the format

> "virtio,device<ID>", where ID is virtio device ID in hexadecimal format.

> 

> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

> ---

>  .../devicetree/bindings/virtio/mmio.yaml      |  3 +-

>  .../bindings/virtio/virtio-device.yaml        | 41 +++++++++++++++++++

>  2 files changed, 43 insertions(+), 1 deletion(-)

>  create mode 100644 Documentation/devicetree/bindings/virtio/virtio-device.yaml

> 


Reviewed-by: Rob Herring <robh@kernel.org>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/virtio/mmio.yaml b/Documentation/devicetree/bindings/virtio/mmio.yaml
index d46597028cf1..4b7a0273181c 100644
--- a/Documentation/devicetree/bindings/virtio/mmio.yaml
+++ b/Documentation/devicetree/bindings/virtio/mmio.yaml
@@ -36,7 +36,8 @@  title: virtio memory mapped devices
   - reg
   - interrupts
 
-additionalProperties: false
+additionalProperties:
+  type: object
 
 examples:
   - |
diff --git a/Documentation/devicetree/bindings/virtio/virtio-device.yaml b/Documentation/devicetree/bindings/virtio/virtio-device.yaml
new file mode 100644
index 000000000000..1778ea9b5aa5
--- /dev/null
+++ b/Documentation/devicetree/bindings/virtio/virtio-device.yaml
@@ -0,0 +1,41 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/virtio/virtio-device.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Virtio device bindings
+
+maintainers:
+  - Viresh Kumar <viresh.kumar@linaro.org>
+
+description:
+  These bindings are applicable to virtio devices irrespective of the bus they
+  are bound to, like mmio or pci.
+
+# We need a select here so we don't match all nodes with 'virtio,mmio'
+properties:
+  compatible:
+    pattern: "^virtio,device[0-9a-f]{1,8}$"
+    description: Virtio device nodes.
+      "virtio,deviceID", where ID is the virtio device id. The textual
+      representation of ID shall be in lower case hexadecimal with leading
+      zeroes suppressed.
+
+required:
+  - compatible
+
+additionalProperties: true
+
+examples:
+  - |
+    virtio@3000 {
+        compatible = "virtio,mmio";
+        reg = <0x3000 0x100>;
+        interrupts = <43>;
+
+        i2c {
+            compatible = "virtio,device22";
+        };
+    };
+...