doc: announce the deprecation of lcore state FINISHED

Message ID 20210730195912.17859-1-honnappa.nagarahalli@arm.com
State New
Headers show
Series
  • doc: announce the deprecation of lcore state FINISHED
Related show

Commit Message

Honnappa Nagarahalli July 30, 2021, 7:59 p.m.
Lcore state FINISHED is used by the worker thread to indicate that
it has completed the assigned task. The state is changed to
WAIT by another thread after it observes the updated state. This
additional step is redundant. After this deprecation, the worker
thread will update the state to WAIT.

Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>

Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>

---
More discussion at:
http://patches.dpdk.org/project/dpdk/patch/20210224212018.17576-4-honnappa.nagarahalli@arm.com/

 doc/guides/rel_notes/deprecation.rst | 4 ++++
 1 file changed, 4 insertions(+)

-- 
2.17.1

Comments

Jerin Jacob Aug. 7, 2021, 1:31 p.m. | #1
On Thu, Aug 5, 2021 at 11:43 AM Feifei Wang <Feifei.Wang2@arm.com> wrote:
>

> > -----邮件原件-----

> > 发件人: dev <dev-bounces@dpdk.org> 代表 Honnappa Nagarahalli

> > 发送时间: Saturday, July 31, 2021 3:59 AM

> > 收件人: dev@dpdk.org; Honnappa Nagarahalli

> > <Honnappa.Nagarahalli@arm.com>; thomas@monjalon.net;

> > konstantin.ananyev@intel.com; Feifei Wang (Arm Technology China)

> > <Feifei.Wang@arm.com>

> > 抄送: Ruifeng Wang <Ruifeng.Wang@arm.com>; nd <nd@arm.com>

> > 主题: [dpdk-dev] [PATCH] doc: announce the deprecation of lcore state

> > FINISHED

> >

> > Lcore state FINISHED is used by the worker thread to indicate that it has

> > completed the assigned task. The state is changed to WAIT by another

> > thread after it observes the updated state. This additional step is redundant.

> > After this deprecation, the worker thread will update the state to WAIT.

> >

> > Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>

> > Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>

> > ---

> Acked-by: Feifei Wang <feifei.wang2@arm.com>


Acked-by: Jerin Jacob <jerinj@marvell.com>



>

> > More discussion at:

> > http://patches.dpdk.org/project/dpdk/patch/20210224212018.17576-4-

> > honnappa.nagarahalli@arm.com/

> >

> >  doc/guides/rel_notes/deprecation.rst | 4 ++++

> >  1 file changed, 4 insertions(+)

> >

> > diff --git a/doc/guides/rel_notes/deprecation.rst

> > b/doc/guides/rel_notes/deprecation.rst

> > index 9584d6bfd7..3adbde9e94 100644

> > --- a/doc/guides/rel_notes/deprecation.rst

> > +++ b/doc/guides/rel_notes/deprecation.rst

> > @@ -11,6 +11,10 @@ here.

> >  Deprecation Notices

> >  -------------------

> >

> > +* eal: The lcore state FINISHED will be removed from the enum

> > +  rte_lcore_state_t. The lcore state WAIT is enough to represent the

> > +same

> > +  state.

> > +

> >  * kvargs: The function ``rte_kvargs_process`` will get a new parameter

> >    for returning key match count. It will ease handling of no-match case.

> >

> > --

> > 2.17.1

>
Thomas Monjalon Aug. 7, 2021, 2:59 p.m. | #2
> > > Lcore state FINISHED is used by the worker thread to indicate that it has

> > > completed the assigned task. The state is changed to WAIT by another

> > > thread after it observes the updated state. This additional step is redundant.

> > > After this deprecation, the worker thread will update the state to WAIT.

> > >

> > > Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>

> > > Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>

> > > ---

> > Acked-by: Feifei Wang <feifei.wang2@arm.com>

> 

> Acked-by: Jerin Jacob <jerinj@marvell.com>


Acked-by: Thomas Monjalon <thomas@monjalon.net>


Applied, thanks.

Patch

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 9584d6bfd7..3adbde9e94 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -11,6 +11,10 @@  here.
 Deprecation Notices
 -------------------
 
+* eal: The lcore state FINISHED will be removed from the enum
+  rte_lcore_state_t. The lcore state WAIT is enough to represent the same
+  state.
+
 * kvargs: The function ``rte_kvargs_process`` will get a new parameter
   for returning key match count. It will ease handling of no-match case.