diff mbox

[PATCHv2,2/2] checkpatch: use codespell for odp

Message ID 1433163482-26369-3-git-send-email-maxim.uvarov@linaro.org
State New
Headers show

Commit Message

Maxim Uvarov June 1, 2015, 12:58 p.m. UTC
Turn on spelling checks with codespell tool.
Tool can be installed with apt-get install codespell.

Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org>
---
 .checkpatch.conf | 1 +
 1 file changed, 1 insertion(+)

Comments

Mike Holmes June 2, 2015, 7:47 p.m. UTC | #1
I have a problem with this - I might have missed something.

So I have codespell installed:-

mike@mike-desktop:~/git/odp$ sudo  apt-get install codespell
Reading package lists... Done
Building dependency tree
Reading state information... Done
codespell is already the newest version.
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.


But I get a new warning on Ubuntu 15.04 about a new dictionary in another
location that is missing :-

mike@mike-desktop:~/git/odp$ ./scripts/checkpatch.pl
~/incoming/PATCHv2_1-2_validation_init_src_files_in_single_directory.mbox
No codespell typos will be found - file
'/usr/local/share/codespell/dictionary.txt': No such file or directory
total: 0 errors, 0 warnings, 0 checks, 12 lines checked

NOTE: Ignored message types: DEPRECATED_VARIABLE NEW_TYPEDEFS

/home/mike/incoming/PATCHv2_1-2_validation_init_src_files_in_single_directory.mbox
has no obvious style problems and is ready for submission.








On 1 June 2015 at 08:58, Maxim Uvarov <maxim.uvarov@linaro.org> wrote:

> Turn on spelling checks with codespell tool.
> Tool can be installed with apt-get install codespell.
>
> Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org>
> ---
>  .checkpatch.conf | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/.checkpatch.conf b/.checkpatch.conf
> index 9076410..17fcea6 100644
> --- a/.checkpatch.conf
> +++ b/.checkpatch.conf
> @@ -2,3 +2,4 @@
>  --strict
>  --ignore=NEW_TYPEDEFS
>  --ignore=DEPRECATED_VARIABLE
> +--codespell
> --
> 1.9.1
>
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> https://lists.linaro.org/mailman/listinfo/lng-odp
>
Maxim Uvarov June 3, 2015, 9:45 a.m. UTC | #2
On 06/02/15 22:47, Mike Holmes wrote:
> I have a problem with this - I might have missed something.
>
> So I have codespell installed:-
>
> mike@mike-desktop:~/git/odp$ sudo  apt-get install codespell
> Reading package lists... Done
> Building dependency tree
> Reading state information... Done
> codespell is already the newest version.
> 0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
>
>
> But I get a new warning on Ubuntu 15.04 about a new dictionary in 
> another location that is missing :-
>
> mike@mike-desktop:~/git/odp$ ./scripts/checkpatch.pl 
> <http://checkpatch.pl> 
> ~/incoming/PATCHv2_1-2_validation_init_src_files_in_single_directory.mbox
> No codespell typos will be found - file 
> '/usr/local/share/codespell/dictionary.txt': No such file or directory

can you search where is dictionary.txt in you filesystem?

Maxim.

> total: 0 errors, 0 warnings, 0 checks, 12 lines checked
>
> NOTE: Ignored message types: DEPRECATED_VARIABLE NEW_TYPEDEFS
>
> /home/mike/incoming/PATCHv2_1-2_validation_init_src_files_in_single_directory.mbox 
> has no obvious style problems and is ready for submission.
>
>
>
>
>
>
>
>
> On 1 June 2015 at 08:58, Maxim Uvarov <maxim.uvarov@linaro.org 
> <mailto:maxim.uvarov@linaro.org>> wrote:
>
>     Turn on spelling checks with codespell tool.
>     Tool can be installed with apt-get install codespell.
>
>     Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org
>     <mailto:maxim.uvarov@linaro.org>>
>     ---
>      .checkpatch.conf | 1 +
>      1 file changed, 1 insertion(+)
>
>     diff --git a/.checkpatch.conf b/.checkpatch.conf
>     index 9076410..17fcea6 100644
>     --- a/.checkpatch.conf
>     +++ b/.checkpatch.conf
>     @@ -2,3 +2,4 @@
>      --strict
>      --ignore=NEW_TYPEDEFS
>      --ignore=DEPRECATED_VARIABLE
>     +--codespell
>     --
>     1.9.1
>
>     _______________________________________________
>     lng-odp mailing list
>     lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org>
>     https://lists.linaro.org/mailman/listinfo/lng-odp
>
>
>
>
> -- 
> Mike Holmes
> Technical Manager - Linaro Networking Group
> Linaro.org <http://www.linaro.org/>***│ *Open source software for ARM SoCs
>
Stuart Haslam June 3, 2015, 9:59 a.m. UTC | #3
On Wed, Jun 03, 2015 at 12:45:22PM +0300, Maxim Uvarov wrote:
> On 06/02/15 22:47, Mike Holmes wrote:
> >I have a problem with this - I might have missed something.
> >
> >So I have codespell installed:-
> >
> >mike@mike-desktop:~/git/odp$ sudo  apt-get install codespell
> >Reading package lists... Done
> >Building dependency tree
> >Reading state information... Done
> >codespell is already the newest version.
> >0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
> >
> >
> >But I get a new warning on Ubuntu 15.04 about a new dictionary in
> >another location that is missing :-
> >
> >mike@mike-desktop:~/git/odp$ ./scripts/checkpatch.pl
> ><http://checkpatch.pl> ~/incoming/PATCHv2_1-2_validation_init_src_files_in_single_directory.mbox
> >No codespell typos will be found - file
> >'/usr/local/share/codespell/dictionary.txt': No such file or
> >directory
> 
> can you search where is dictionary.txt in you filesystem?
> 
> Maxim.

Ubuntu seems to put it in /usr/share/codespell/dictionary.txt
Maxim Uvarov June 4, 2015, 9:24 a.m. UTC | #4
On 06/03/15 12:59, Stuart Haslam wrote:
> On Wed, Jun 03, 2015 at 12:45:22PM +0300, Maxim Uvarov wrote:
>> On 06/02/15 22:47, Mike Holmes wrote:
>>> I have a problem with this - I might have missed something.
>>>
>>> So I have codespell installed:-
>>>
>>> mike@mike-desktop:~/git/odp$ sudo  apt-get install codespell
>>> Reading package lists... Done
>>> Building dependency tree
>>> Reading state information... Done
>>> codespell is already the newest version.
>>> 0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
>>>
>>>
>>> But I get a new warning on Ubuntu 15.04 about a new dictionary in
>>> another location that is missing :-
>>>
>>> mike@mike-desktop:~/git/odp$ ./scripts/checkpatch.pl
>>> <http://checkpatch.pl> ~/incoming/PATCHv2_1-2_validation_init_src_files_in_single_directory.mbox
>>> No codespell typos will be found - file
>>> '/usr/local/share/codespell/dictionary.txt': No such file or
>>> directory
>> can you search where is dictionary.txt in you filesystem?
>>
>> Maxim.
> Ubuntu seems to put it in /usr/share/codespell/dictionary.txt
>
Right. Sent patch for it to kernel.

Maxim.
diff mbox

Patch

diff --git a/.checkpatch.conf b/.checkpatch.conf
index 9076410..17fcea6 100644
--- a/.checkpatch.conf
+++ b/.checkpatch.conf
@@ -2,3 +2,4 @@ 
 --strict
 --ignore=NEW_TYPEDEFS
 --ignore=DEPRECATED_VARIABLE
+--codespell