diff mbox series

[v1] arm64: dts: qcom: sc7280: Add clock controller ID headers

Message ID 1628642571-25383-1-git-send-email-tdas@codeaurora.org
State Accepted
Commit c8efde9f6b18b66da3c8b7c77bd1ac422b872aee
Headers show
Series [v1] arm64: dts: qcom: sc7280: Add clock controller ID headers | expand

Commit Message

Taniya Das Aug. 11, 2021, 12:42 a.m. UTC
Add the GPUCC, DISPCC and VIDEOCC clock headers which were dropped
earlier.

Fixes: 422a295221bb ("arm64: dts: qcom: sc7280: Add clock controller nodes")
Signed-off-by: Taniya Das <tdas@codeaurora.org>
---
 arch/arm64/boot/dts/qcom/sc7280.dtsi | 3 +++
 1 file changed, 3 insertions(+)

--
Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member
of the Code Aurora Forum, hosted by the  Linux Foundation.

Comments

Doug Anderson Sept. 16, 2021, 3:39 p.m. UTC | #1
Hi,

On Tue, Aug 24, 2021 at 3:52 PM Doug Anderson <dianders@chromium.org> wrote:
>

> Hi,

>

> On Tue, Aug 10, 2021 at 5:43 PM Taniya Das <tdas@codeaurora.org> wrote:

> >

> > Add the GPUCC, DISPCC and VIDEOCC clock headers which were dropped

> > earlier.

> >

> > Fixes: 422a295221bb ("arm64: dts: qcom: sc7280: Add clock controller nodes")

>

> IMO drop the "Fixes". To me having the "Fixes" there means that there

> was a bug in the old patch. This isn't really fixing a bug.

>

> > Signed-off-by: Taniya Das <tdas@codeaurora.org>

> > ---

> >  arch/arm64/boot/dts/qcom/sc7280.dtsi | 3 +++

> >  1 file changed, 3 insertions(+)

>

> Other than removing the "Fixes" then this seems like it would be nice

> to land soon after the next -rc1 comes out so that patches that start

> referring to the clocks in these controllers can take advantage of

> them. Snooze 3 weeks till (presumably) -rc1 might come out.

>

> Reviewed-by: Douglas Anderson <dianders@chromium.org>


Bjorn: if you agree and are willing to drop the "Fixes" line yourself
when applying then I think this is ready to land since it's now "soon
after the next -rc1". ;-)

-Doug
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
index 53a21d0..3e96604 100644
--- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
@@ -5,8 +5,11 @@ 
  * Copyright (c) 2020-2021, The Linux Foundation. All rights reserved.
  */

+#include <dt-bindings/clock/qcom,dispcc-sc7280.h>
 #include <dt-bindings/clock/qcom,gcc-sc7280.h>
+#include <dt-bindings/clock/qcom,gpucc-sc7280.h>
 #include <dt-bindings/clock/qcom,rpmh.h>
+#include <dt-bindings/clock/qcom,videocc-sc7280.h>
 #include <dt-bindings/interconnect/qcom,sc7280.h>
 #include <dt-bindings/interrupt-controller/arm-gic.h>
 #include <dt-bindings/mailbox/qcom-ipcc.h>