From patchwork Wed Jun 17 14:28:07 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 49982 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wi0-f199.google.com (mail-wi0-f199.google.com [209.85.212.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id DD896228CC for ; Wed, 17 Jun 2015 14:30:41 +0000 (UTC) Received: by wizw5 with SMTP id w5sf14181363wiz.2 for ; Wed, 17 Jun 2015 07:30:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-type :content-transfer-encoding:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=+Uk9wn68IbJ07RjuSkRL3yUZlLKhSoM6XP3MLgee0yc=; b=m+XSob7TkA7zuZzJWIJM6qcBWBnxcI4eMozfVoiVQWI74tRYHGWXfLr9OhFNWxkrOP bRRLCLoPbiwiyaGIvSa1IvjDTm8m5rVsOCBm5oVo4x0SVwGo/si05E7SV/eOa8iteMdV P2/mlLH5AAZsT4EGoNatZIv9R1f1CFQ/JX6PPOsRRJe7joWXc8EK127lpU/ybsOOjpNY 5UYg7Lu9tNRCL27M0LzaFcCugMno3By1HquPN/pO7okJ5Fg7zaqmf8/sQeNMRHL1w5Yj X3nyvSMt45Msks3cwqaeXXAlkQ1InxFsAc1mI8RbNVhU2WR+9obxSX5oIKHS+2uuj+kL IBKg== X-Gm-Message-State: ALoCoQmNyMoWKmX53vBPISELfvslOfmaGw4d5bnCKVf7x84CWpjPWZPxDVWe5NREkWKry1NpbbP9 X-Received: by 10.180.106.10 with SMTP id gq10mr30270982wib.0.1434551441249; Wed, 17 Jun 2015 07:30:41 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.7.146 with SMTP id j18ls321404laa.22.gmail; Wed, 17 Jun 2015 07:30:41 -0700 (PDT) X-Received: by 10.112.144.69 with SMTP id sk5mr8305151lbb.6.1434551441095; Wed, 17 Jun 2015 07:30:41 -0700 (PDT) Received: from mail-la0-f50.google.com (mail-la0-f50.google.com. [209.85.215.50]) by mx.google.com with ESMTPS id ll10si3765349lac.26.2015.06.17.07.30.40 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 17 Jun 2015 07:30:40 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.50 as permitted sender) client-ip=209.85.215.50; Received: by lacny3 with SMTP id ny3so34436283lac.3 for ; Wed, 17 Jun 2015 07:30:40 -0700 (PDT) X-Received: by 10.112.140.231 with SMTP id rj7mr8172692lbb.76.1434551440670; Wed, 17 Jun 2015 07:30:40 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.108.230 with SMTP id hn6csp509912lbb; Wed, 17 Jun 2015 07:30:39 -0700 (PDT) X-Received: by 10.68.219.1 with SMTP id pk1mr11485184pbc.18.1434551438955; Wed, 17 Jun 2015 07:30:38 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ls17si4805653pab.136.2015.06.17.07.30.37; Wed, 17 Jun 2015 07:30:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757060AbbFQOa1 (ORCPT + 30 others); Wed, 17 Jun 2015 10:30:27 -0400 Received: from smtp.citrix.com ([66.165.176.89]:14566 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755509AbbFQO2r (ORCPT ); Wed, 17 Jun 2015 10:28:47 -0400 X-IronPort-AV: E=Sophos;i="5.13,633,1427760000"; d="scan'208";a="272885266" From: Julien Grall To: CC: , , Julien Grall , Julien Grall , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Konrad Rzeszutek Wilk , "Boris Ostrovsky" , David Vrabel Subject: [PATCH v2 6/7] block/xen-blkfront: Remove invalid comment Date: Wed, 17 Jun 2015 15:28:07 +0100 Message-ID: <1434551288-14113-7-git-send-email-julien.grall@citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1434551288-14113-1-git-send-email-julien.grall@citrix.com> References: <1434551288-14113-1-git-send-email-julien.grall@citrix.com> MIME-Version: 1.0 X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: linux-kernel-owner@vger.kernel.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.50 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , From: Julien Grall Since commit b764915 "xen-blkfront: use a different scatterlist for each request", biovec has been replaced by scatterlist when copying back the data during a completion request. Signed-off-by: Julien Grall Acked-by: Roger Pau Monné Cc: Konrad Rzeszutek Wilk Cc: Boris Ostrovsky Cc: David Vrabel --- Changes in v2: - Add Roger's Acked-by --- drivers/block/xen-blkfront.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c index 5c72c25..60cf1d6 100644 --- a/drivers/block/xen-blkfront.c +++ b/drivers/block/xen-blkfront.c @@ -1056,12 +1056,6 @@ static void blkif_completion(struct blk_shadow *s, struct blkfront_info *info, s->req.u.indirect.nr_segments : s->req.u.rw.nr_segments; if (bret->operation == BLKIF_OP_READ && info->feature_persistent) { - /* - * Copy the data received from the backend into the bvec. - * Since bv_offset can be different than 0, and bv_len different - * than PAGE_SIZE, we have to keep track of the current offset, - * to be sure we are copying the data from the right shared page. - */ for_each_sg(s->sg, sg, nseg, i) { BUG_ON(sg->offset + sg->length > PAGE_SIZE); shared_data = kmap_atomic(