diff mbox

[1/9] ARM: mxc: time: convert to clk_prepare/clk_unprepare

Message ID 1320900854-13031-1-git-send-email-richard.zhao@linaro.org
State Changes Requested
Headers show

Commit Message

Richard Zhao Nov. 10, 2011, 4:54 a.m. UTC
Signed-off-by: Richard Zhao <richard.zhao@linaro.org>
---
 arch/arm/plat-mxc/time.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Comments

Sascha Hauer Nov. 10, 2011, 8:03 a.m. UTC | #1
Hi Richard,

I think we should introduce two new helpers:

clk_prepare_enable()
clk_disable_unprepare()

This series could look much nicer with it.

Minor nitpick: I don't like the subject. 'convert' suggests that you are
replacing something, instead you are adding something.

Sascha
Richard Zhao Nov. 10, 2011, 8:18 a.m. UTC | #2
On Thu, Nov 10, 2011 at 09:03:31AM +0100, Sascha Hauer wrote:
> Hi Richard,
> 
> I think we should introduce two new helpers:
> 
> clk_prepare_enable()
> clk_disable_unprepare()
right. I will add two inline functions in include/linux/clk.h.
> 
> This series could look much nicer with it.
> 
> Minor nitpick: I don't like the subject. 'convert' suggests that you are
> replacing something, instead you are adding something.
It's copied from other commits doing the same thing. If you don't like it,
I can change it to "Add clk_prepare/clk_unprepare support".

For other driver patch doing the same thing, do you think you can handle it too, or let other
different driver maintainer handle it? If you can, I'll merge it into the same series.

Richard
> 
> Sascha
> 
> -- 
> Pengutronix e.K.                           |                             |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
diff mbox

Patch

diff --git a/arch/arm/plat-mxc/time.c b/arch/arm/plat-mxc/time.c
index 4b0fe28..5fa0cc4 100644
--- a/arch/arm/plat-mxc/time.c
+++ b/arch/arm/plat-mxc/time.c
@@ -292,6 +292,7 @@  void __init mxc_timer_init(struct clk *timer_clk, void __iomem *base, int irq)
 {
 	uint32_t tctl_val;
 
+	clk_prepare(timer_clk);
 	clk_enable(timer_clk);
 
 	timer_base = base;