diff mbox series

[2/2] dt: bindings: net: mt76: add eeprom-data property

Message ID YSWdv7ZKz7SBtF+v@makrotopia.org
State New
Headers show
Series [1/2] mt76: support reading EEPROM data embedded in fdt | expand

Commit Message

Daniel Golle Aug. 25, 2021, 1:33 a.m. UTC
EEPROM data for mt76 can be embedded into device-tree as an array.

Signed-off-by: Daniel Golle <daniel@makrotopia.org>
---
 .../devicetree/bindings/net/wireless/mediatek,mt76.yaml      | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Rob Herring (Arm) Aug. 31, 2021, 7:28 p.m. UTC | #1
On Wed, 25 Aug 2021 02:33:23 +0100, Daniel Golle wrote:
> EEPROM data for mt76 can be embedded into device-tree as an array.
> 
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> ---
>  .../devicetree/bindings/net/wireless/mediatek,mt76.yaml      | 5 +++++
>  1 file changed, 5 insertions(+)
> 

Acked-by: Rob Herring <robh@kernel.org>
Daniel Golle Oct. 5, 2021, 4:08 p.m. UTC | #2
On Fri, Sep 24, 2021 at 07:14:47PM +0200, Felix Fietkau wrote:
> 

> On 2021-08-25 03:33, Daniel Golle wrote:

> > EEPROM data for mt76 can be embedded into device-tree as an array.

> > 

> > Signed-off-by: Daniel Golle <daniel@makrotopia.org>

> > ---

> >  .../devicetree/bindings/net/wireless/mediatek,mt76.yaml      | 5 +++++

> >  1 file changed, 5 insertions(+)

> > 

> > diff --git a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml

> > index 3e2c2e43175e5..1489d3c1cd6ec 100644

> > --- a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml

> > +++ b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml

> > @@ -47,6 +47,11 @@ properties:

> >  

> >    ieee80211-freq-limit: true

> >  

> > +  mediatek,eeprom-data:

> > +    $ref: /schemas/types.yaml#/definitions/uint32-array

> Given that the driver patch simply uses memcpy on the data, shouldn't we

> use an uint8-array here?


When using the /incbin/('file.bin'); syntax the result is included as
what appears to be a uint32-array when decompiling again with dtc.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
index 3e2c2e43175e5..1489d3c1cd6ec 100644
--- a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
+++ b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
@@ -47,6 +47,11 @@  properties:
 
   ieee80211-freq-limit: true
 
+  mediatek,eeprom-data:
+    $ref: /schemas/types.yaml#/definitions/uint32-array
+    description:
+      EEPROM data embedded as array.
+
   mediatek,mtd-eeprom:
     $ref: /schemas/types.yaml#/definitions/phandle-array
     description: