mmc: sdhci: msm: Boost controller core clock

Message ID 1435317417-369-1-git-send-email-ivan.ivanov@linaro.org
State New
Headers show

Commit Message

Ivan T. Ivanov June 26, 2015, 11:16 a.m.
Ensure SDCC is working with maximum clock otherwise card
detection could be extremely slow, up to 7 seconds.

Signed-off-by: Ivan T. Ivanov <ivan.ivanov@linaro.org>
---
 drivers/mmc/host/sdhci-msm.c | 5 +++++
 1 file changed, 5 insertions(+)

--
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Georgi Djakov June 26, 2015, 11:34 a.m. | #1
On 06/26/2015 02:16 PM, Ivan T. Ivanov wrote:
> Ensure SDCC is working with maximum clock otherwise card
> detection could be extremely slow, up to 7 seconds.
> 
> Signed-off-by: Ivan T. Ivanov <ivan.ivanov@linaro.org>
> ---
>  drivers/mmc/host/sdhci-msm.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
> index 4a09f76..b2556bc 100644
> --- a/drivers/mmc/host/sdhci-msm.c
> +++ b/drivers/mmc/host/sdhci-msm.c
> @@ -489,6 +489,11 @@ static int sdhci_msm_probe(struct platform_device *pdev)
>  		goto pclk_disable;
>  	}
> 
> +	/* Vote for maximum clock rate for maximum performance */
> +	ret = clk_set_rate(msm_host->clk, INT_MAX);
> +	if (ret)
> +		dev_warn(&pdev->dev, "core clock boost falied\n");

failed?

Otherwise looks good to me.

> +
>  	ret = clk_prepare_enable(msm_host->clk);
>  	if (ret)
>  		goto pclk_disable;
> --
> 1.9.1
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Ivan T. Ivanov June 26, 2015, 11:59 a.m. | #2
On Fri, 2015-06-26 at 14:34 +0300, Georgi Djakov wrote:
> On 06/26/2015 02:16 PM, Ivan T. Ivanov wrote:
> > Ensure SDCC is working with maximum clock otherwise card
> > detection could be extremely slow, up to 7 seconds.
> > 
> > Signed-off-by: Ivan T. Ivanov ivanov@linaro.org>
> > ---
> >  drivers/mmc/host/sdhci-msm.c | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
> > index 4a09f76..b2556bc 100644
> > --- a/drivers/mmc/host/sdhci-msm.c
> > +++ b/drivers/mmc/host/sdhci-msm.c
> > @@ -489,6 +489,11 @@ static int sdhci_msm_probe(struct platform_device *pdev)
> >                 goto pclk_disable;
> >         }
> > 
> > +       /* Vote for maximum clock rate for maximum performance */
> > +       ret = clk_set_rate(msm_host->clk, INT_MAX);
> > +       if (ret)
> > +               dev_warn(&pdev->dev, "core clock boost falied\n");
> 
> failed?
> 
> Otherwise looks good to me.
> 

Oops, will fix.

Thanks,
Ivan

> > +
> >         ret = clk_prepare_enable(msm_host->clk);
> >         if (ret)
> >                 goto pclk_disable;
> > --
> > 1.9.1
> > 
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
index 4a09f76..b2556bc 100644
--- a/drivers/mmc/host/sdhci-msm.c
+++ b/drivers/mmc/host/sdhci-msm.c
@@ -489,6 +489,11 @@  static int sdhci_msm_probe(struct platform_device *pdev)
 		goto pclk_disable;
 	}

+	/* Vote for maximum clock rate for maximum performance */
+	ret = clk_set_rate(msm_host->clk, INT_MAX);
+	if (ret)
+		dev_warn(&pdev->dev, "core clock boost falied\n");
+
 	ret = clk_prepare_enable(msm_host->clk);
 	if (ret)
 		goto pclk_disable;