diff mbox series

seg6_iptunnel: Remove redundant initialization of variable err

Message ID 20210902143506.41956-1-colin.king@canonical.com
State New
Headers show
Series seg6_iptunnel: Remove redundant initialization of variable err | expand

Commit Message

Colin King Sept. 2, 2021, 2:35 p.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

The variable err is being initialized with a value that is never read, it
is being updated later on. The assignment is redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 net/ipv6/seg6_iptunnel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

patchwork-bot+netdevbpf@kernel.org Sept. 3, 2021, 11:40 a.m. UTC | #1 
Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Thu,  2 Sep 2021 15:35:05 +0100 you wrote:
> From: Colin Ian King <colin.king@canonical.com>

> 

> The variable err is being initialized with a value that is never read, it

> is being updated later on. The assignment is redundant and can be removed.

> 

> Addresses-Coverity: ("Unused value")

> Signed-off-by: Colin Ian King <colin.king@canonical.com>

> 

> [...]


Here is the summary with links:
  - seg6_iptunnel: Remove redundant initialization of variable err
    https://git.kernel.org/netdev/net/c/bf0df73a2f0d

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
diff mbox series

Patch

diff --git a/net/ipv6/seg6_iptunnel.c b/net/ipv6/seg6_iptunnel.c
index 1bf5f5ae75ac..3adc5d9211ad 100644
--- a/net/ipv6/seg6_iptunnel.c
+++ b/net/ipv6/seg6_iptunnel.c
@@ -385,7 +385,7 @@  static int seg6_output_core(struct net *net, struct sock *sk,
 	struct dst_entry *orig_dst = skb_dst(skb);
 	struct dst_entry *dst = NULL;
 	struct seg6_lwt *slwt;
-	int err = -EINVAL;
+	int err;
 
 	err = seg6_do_srh(skb);
 	if (unlikely(err))