[edk2,2/2] MdePkg: remove PcdDefaultTerminalType

Message ID 1436870180-18841-3-git-send-email-ard.biesheuvel@linaro.org
State New
Headers show

Commit Message

Ard Biesheuvel July 14, 2015, 10:36 a.m.
The PCD gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType is not used
anywhere in MdePkg itself, and with the introduction of TTYTERM, it
may now assume values that are not defined in MdePkg either.

So now that we moved it to MdeModulePkg, remove this one that is
now unused.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
 MdePkg/MdePkg.dec | 9 ---------
 1 file changed, 9 deletions(-)

Comments

Roy Franz July 14, 2015, 3:43 p.m. | #1
On Tue, Jul 14, 2015 at 3:36 AM, Ard Biesheuvel
<ard.biesheuvel@linaro.org> wrote:
> The PCD gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType is not used
> anywhere in MdePkg itself, and with the introduction of TTYTERM, it
> may now assume values that are not defined in MdePkg either.
>
> So now that we moved it to MdeModulePkg, remove this one that is
> now unused.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
>  MdePkg/MdePkg.dec | 9 ---------
>  1 file changed, 9 deletions(-)
>
> diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec
> index bda6550ed6c6..026a94987bef 100644
> --- a/MdePkg/MdePkg.dec
> +++ b/MdePkg/MdePkg.dec
> @@ -2007,15 +2007,6 @@ [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx]
>    # @ValidRange 0x80000001 | 0 - 3
>    gEfiMdePkgTokenSpaceGuid.PcdUartDefaultStopBits|1|UINT8|0x00000023
>
> -  ## Indicates the usable type of terminal.<BR><BR>
> -  #  0 - PCANSI<BR>
> -  #  1 - VT100<BR>
> -  #  2 - VT100+<BR>
> -  #  3 - UTF8<BR>
> -  # @Prompt Default Terminal Type.
> -  # @ValidRange 0x80000001 | 0 - 3
> -  gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType|0|UINT8|0x00000024
> -
>    ## Error level for hardware recorder.
>    #  If value 0, platform does not support feature of hardware error record.
>    # @Prompt Error Level For Hardware Recorder
> --
> 1.9.1
>
Reviewed-by: Roy Franz <roy.franz@linaro.org>

------------------------------------------------------------------------------
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
Ard Biesheuvel July 15, 2015, 8:59 a.m. | #2
On 15 July 2015 at 08:26, Gao, Liming <liming.gao@intel.com> wrote:
> Ard:
>   From compatible view, I don't prefer to make this change. The driver in other EDKII package may use this PCD. After this change, they will build break.
>
>   I suggest to keep this PCD, and update its comment to include new type. Its comment can highlight this type is not defined in UEFI specification.
>

OK, that is also fine,

Thanks,
Ard.


> -----Original Message-----
> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]
> Sent: Tuesday, July 14, 2015 6:36 PM
> To: edk2-devel@lists.sourceforge.net; heyi.guo@linaro.org; lersek@redhat.com; Tian, Feng; Gao, Liming
> Cc: roy.franz@linaro.org; Ard Biesheuvel
> Subject: [PATCH 2/2] MdePkg: remove PcdDefaultTerminalType
>
> The PCD gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType is not used anywhere in MdePkg itself, and with the introduction of TTYTERM, it may now assume values that are not defined in MdePkg either.
>
> So now that we moved it to MdeModulePkg, remove this one that is now unused.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
>  MdePkg/MdePkg.dec | 9 ---------
>  1 file changed, 9 deletions(-)
>
> diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index bda6550ed6c6..026a94987bef 100644
> --- a/MdePkg/MdePkg.dec
> +++ b/MdePkg/MdePkg.dec
> @@ -2007,15 +2007,6 @@ [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx]
>    # @ValidRange 0x80000001 | 0 - 3
>    gEfiMdePkgTokenSpaceGuid.PcdUartDefaultStopBits|1|UINT8|0x00000023
>
> -  ## Indicates the usable type of terminal.<BR><BR>
> -  #  0 - PCANSI<BR>
> -  #  1 - VT100<BR>
> -  #  2 - VT100+<BR>
> -  #  3 - UTF8<BR>
> -  # @Prompt Default Terminal Type.
> -  # @ValidRange 0x80000001 | 0 - 3
> -  gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType|0|UINT8|0x00000024
> -
>    ## Error level for hardware recorder.
>    #  If value 0, platform does not support feature of hardware error record.
>    # @Prompt Error Level For Hardware Recorder
> --
> 1.9.1
>

------------------------------------------------------------------------------
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/

Patch hide | download patch | download mbox

diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec
index bda6550ed6c6..026a94987bef 100644
--- a/MdePkg/MdePkg.dec
+++ b/MdePkg/MdePkg.dec
@@ -2007,15 +2007,6 @@  [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx]
   # @ValidRange 0x80000001 | 0 - 3
   gEfiMdePkgTokenSpaceGuid.PcdUartDefaultStopBits|1|UINT8|0x00000023
 
-  ## Indicates the usable type of terminal.<BR><BR>
-  #  0 - PCANSI<BR>
-  #  1 - VT100<BR>
-  #  2 - VT100+<BR>
-  #  3 - UTF8<BR>
-  # @Prompt Default Terminal Type.
-  # @ValidRange 0x80000001 | 0 - 3
-  gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType|0|UINT8|0x00000024
-
   ## Error level for hardware recorder.
   #  If value 0, platform does not support feature of hardware error record.
   # @Prompt Error Level For Hardware Recorder