[v1] examples: ipsec: fix inner IP checksum computation

Message ID 1436876749-14412-1-git-send-email-alexandru.badicioiu@linaro.org
State Accepted
Commit 5501b3afba8ba8b9640a7579967d91f46e6f3e1c
Headers show

Commit Message

Alexandru Badicioiu July 14, 2015, 12:25 p.m.
From: Alexandru Badicioiu <alexandru.badicioiu@linaro.org>

Signed-off-by: Alexandru Badicioiu <alexandru.badicioiu@linaro.org>
---
 example/ipsec/odp_ipsec_stream.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Bill Fischofer July 14, 2015, 12:40 p.m. | #1
On Tue, Jul 14, 2015 at 7:25 AM, <alexandru.badicioiu@linaro.org> wrote:

> From: Alexandru Badicioiu <alexandru.badicioiu@linaro.org>
>
> Signed-off-by: Alexandru Badicioiu <alexandru.badicioiu@linaro.org>
>

Reviewed-by: Bill Fischofer <bill.fischofer@linaro.org>


> ---
>  example/ipsec/odp_ipsec_stream.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/example/ipsec/odp_ipsec_stream.c
> b/example/ipsec/odp_ipsec_stream.c
> index a140d36..9c4d682 100644
> --- a/example/ipsec/odp_ipsec_stream.c
> +++ b/example/ipsec/odp_ipsec_stream.c
> @@ -268,7 +268,7 @@ odp_packet_t create_ipv4_packet(stream_db_entry_t
> *stream,
>                 inner_ip->frag_offset = 0;
>                 inner_ip->src_addr = odp_cpu_to_be_32(stream->src_ip);
>                 inner_ip->dst_addr = odp_cpu_to_be_32(stream->dst_ip);
> -               inner_ip->chksum = odp_chksum(inner_ip, sizeof(inner_ip));
> +               inner_ip->chksum = odp_chksum(inner_ip, sizeof(*inner_ip));
>                 data += sizeof(*inner_ip);
>         }
>
> --
> 1.7.3.4
>
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> https://lists.linaro.org/mailman/listinfo/lng-odp
>
Maxim Uvarov July 15, 2015, 10:39 a.m. | #2
Merged,

Maxim.

On 07/14/15 15:40, Bill Fischofer wrote:
>
>
> On Tue, Jul 14, 2015 at 7:25 AM, <alexandru.badicioiu@linaro.org 
> <mailto:alexandru.badicioiu@linaro.org>> wrote:
>
>     From: Alexandru Badicioiu <alexandru.badicioiu@linaro.org
>     <mailto:alexandru.badicioiu@linaro.org>>
>
>     Signed-off-by: Alexandru Badicioiu <alexandru.badicioiu@linaro.org
>     <mailto:alexandru.badicioiu@linaro.org>>
>
>
> Reviewed-by: Bill Fischofer <bill.fischofer@linaro.org 
> <mailto:bill.fischofer@linaro.org>>
>
>     ---
>      example/ipsec/odp_ipsec_stream.c |    2 +-
>      1 files changed, 1 insertions(+), 1 deletions(-)
>
>     diff --git a/example/ipsec/odp_ipsec_stream.c
>     b/example/ipsec/odp_ipsec_stream.c
>     index a140d36..9c4d682 100644
>     --- a/example/ipsec/odp_ipsec_stream.c
>     +++ b/example/ipsec/odp_ipsec_stream.c
>     @@ -268,7 +268,7 @@ odp_packet_t
>     create_ipv4_packet(stream_db_entry_t *stream,
>                     inner_ip->frag_offset = 0;
>                     inner_ip->src_addr = odp_cpu_to_be_32(stream->src_ip);
>                     inner_ip->dst_addr = odp_cpu_to_be_32(stream->dst_ip);
>     -               inner_ip->chksum = odp_chksum(inner_ip,
>     sizeof(inner_ip));
>     +               inner_ip->chksum = odp_chksum(inner_ip,
>     sizeof(*inner_ip));
>                     data += sizeof(*inner_ip);
>             }
>
>     --
>     1.7.3.4
>
>     _______________________________________________
>     lng-odp mailing list
>     lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org>
>     https://lists.linaro.org/mailman/listinfo/lng-odp
>
>
>
>
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> https://lists.linaro.org/mailman/listinfo/lng-odp

Patch

diff --git a/example/ipsec/odp_ipsec_stream.c b/example/ipsec/odp_ipsec_stream.c
index a140d36..9c4d682 100644
--- a/example/ipsec/odp_ipsec_stream.c
+++ b/example/ipsec/odp_ipsec_stream.c
@@ -268,7 +268,7 @@  odp_packet_t create_ipv4_packet(stream_db_entry_t *stream,
 		inner_ip->frag_offset = 0;
 		inner_ip->src_addr = odp_cpu_to_be_32(stream->src_ip);
 		inner_ip->dst_addr = odp_cpu_to_be_32(stream->dst_ip);
-		inner_ip->chksum = odp_chksum(inner_ip, sizeof(inner_ip));
+		inner_ip->chksum = odp_chksum(inner_ip, sizeof(*inner_ip));
 		data += sizeof(*inner_ip);
 	}