[edk2,V3,3/4] MdeModulePkg/TerminalDxe: Set NullRemaining to FALSE by default

Message ID 1437012588-24390-4-git-send-email-heyi.guo@linaro.org
State New
Headers show

Commit Message

Heyi Guo July 16, 2015, 2:09 a.m.
This is bug fix for TerminalDxe: NullRemaining should be set to FALSE
by fault and then be set to TRUE conditionally.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Heyi Guo <heyi.guo@linaro.org>
---
 MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Heyi Guo July 16, 2015, 12:11 p.m. | #1
On 07/16/2015 05:56 PM, Laszlo Ersek wrote:
> On 07/16/15 04:09, Heyi Guo wrote:
>> This is bug fix for TerminalDxe: NullRemaining should be set to FALSE
>> by fault and then be set to TRUE conditionally.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Signed-off-by: Heyi Guo <heyi.guo@linaro.org>
>> ---
>>   MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c b/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c
>> index 597b15d..75bfdec 100644
>> --- a/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c
>> +++ b/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c
>> @@ -568,7 +568,7 @@ TerminalDriverBindingStart (
>>     DefaultNode        = NULL;
>>     ConInSelected       = FALSE;
>>     ConOutSelected      = FALSE;
>> -  NullRemaining      = TRUE;
>> +  NullRemaining      = FALSE;
>>     SimTxtInInstalled  = FALSE;
>>     SimTxtOutInstalled = FALSE;
>>     FirstEnter         = FALSE;
>>
> This patch is identical to its counterpart in v2, therefore it should
> have been posted with Feng's R-b added, from
>
> http://thread.gmane.org/gmane.comp.bios.tianocore.devel/17244/focus=17309
>
> Ditto for [v2 3/3] <-> [v3 4/4].
>
> Basically, sometime during the preparation of the next version of a
> patch series, run a dedicated "git rebase -i", set all the actions to
> "reword", and copy the tags (Reviewed-by, Acked-by, Tested-by, etc) from
> the feedback you received to the commit messages. (Unless you changed
> the patch significantly.)
Nice tips :) Will try next time. Thank you :-)

Heyi

>
> Thanks
> Laszlo
>


------------------------------------------------------------------------------
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/

Patch hide | download patch | download mbox

diff --git a/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c b/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c
index 597b15d..75bfdec 100644
--- a/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c
+++ b/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c
@@ -568,7 +568,7 @@  TerminalDriverBindingStart (
   DefaultNode        = NULL;
   ConInSelected       = FALSE;
   ConOutSelected      = FALSE;
-  NullRemaining      = TRUE;
+  NullRemaining      = FALSE;
   SimTxtInInstalled  = FALSE;
   SimTxtOutInstalled = FALSE;
   FirstEnter         = FALSE;