diff mbox series

[-net] ptp: dp83640: don't define PAGE0

Message ID 20210913220605.19682-1-rdunlap@infradead.org
State New
Headers show
Series [-net] ptp: dp83640: don't define PAGE0 | expand

Commit Message

Randy Dunlap Sept. 13, 2021, 10:06 p.m. UTC
Building dp83640.c on arch/parisc/ produces a build warning for
PAGE0 being redefined. Since the macro is not used in the dp83640
driver, just make it a comment for documentation purposes.

In file included from ../drivers/net/phy/dp83640.c:23:
../drivers/net/phy/dp83640_reg.h:8: warning: "PAGE0" redefined
    8 | #define PAGE0                     0x0000
                 from ../drivers/net/phy/dp83640.c:11:
../arch/parisc/include/asm/page.h:187: note: this is the location of the previous definition
  187 | #define PAGE0   ((struct zeropage *)__PAGE_OFFSET)

Fixes: cb646e2b02b2 ("ptp: Added a clock driver for the National Semiconductor PHYTER.")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Richard Cochran <richard.cochran@omicron.at>
Cc: John Stultz <john.stultz@linaro.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Russell King <linux@armlinux.org.uk>
---
 drivers/net/phy/dp83640_reg.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andrew Lunn Sept. 14, 2021, 12:24 a.m. UTC | #1
On Mon, Sep 13, 2021 at 03:06:05PM -0700, Randy Dunlap wrote:
> Building dp83640.c on arch/parisc/ produces a build warning for
> PAGE0 being redefined. Since the macro is not used in the dp83640
> driver, just make it a comment for documentation purposes.
> 
> In file included from ../drivers/net/phy/dp83640.c:23:
> ../drivers/net/phy/dp83640_reg.h:8: warning: "PAGE0" redefined
>     8 | #define PAGE0                     0x0000
>                  from ../drivers/net/phy/dp83640.c:11:
> ../arch/parisc/include/asm/page.h:187: note: this is the location of the previous definition
>   187 | #define PAGE0   ((struct zeropage *)__PAGE_OFFSET)
> 
> Fixes: cb646e2b02b2 ("ptp: Added a clock driver for the National Semiconductor PHYTER.")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: Richard Cochran <richard.cochran@omicron.at>
> Cc: John Stultz <john.stultz@linaro.org>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Andrew Lunn <andrew@lunn.ch>
> Cc: Heiner Kallweit <hkallweit1@gmail.com>
> Cc: Russell King <linux@armlinux.org.uk>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
patchwork-bot+netdevbpf@kernel.org Sept. 15, 2021, 3:10 a.m. UTC | #2
Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Mon, 13 Sep 2021 15:06:05 -0700 you wrote:
> Building dp83640.c on arch/parisc/ produces a build warning for

> PAGE0 being redefined. Since the macro is not used in the dp83640

> driver, just make it a comment for documentation purposes.

> 

> In file included from ../drivers/net/phy/dp83640.c:23:

> ../drivers/net/phy/dp83640_reg.h:8: warning: "PAGE0" redefined

>     8 | #define PAGE0                     0x0000

>                  from ../drivers/net/phy/dp83640.c:11:

> ../arch/parisc/include/asm/page.h:187: note: this is the location of the previous definition

>   187 | #define PAGE0   ((struct zeropage *)__PAGE_OFFSET)

> 

> [...]


Here is the summary with links:
  - [-net] ptp: dp83640: don't define PAGE0
    https://git.kernel.org/netdev/net/c/7366c23ff492

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
diff mbox series

Patch

--- linux-next-20210913.orig/drivers/net/phy/dp83640_reg.h
+++ linux-next-20210913/drivers/net/phy/dp83640_reg.h
@@ -5,7 +5,7 @@ 
 #ifndef HAVE_DP83640_REGISTERS
 #define HAVE_DP83640_REGISTERS
 
-#define PAGE0                     0x0000
+/* #define PAGE0                  0x0000 */
 #define PHYCR2                    0x001c /* PHY Control Register 2 */
 
 #define PAGE4                     0x0004