| Message ID | 1437575714-2928-1-git-send-email-mike.holmes@linaro.org |
|---|---|
| State | Accepted |
| Commit | f55c40b045fbbbd20016b7dc483502584afd881d |
| Headers | show |
This is a duplicate of Patch http://patches.opendataplane.org/patch/2215/ that I submitted on July 10th. On Wed, Jul 22, 2015 at 9:35 AM, Mike Holmes <mike.holmes@linaro.org> wrote: > Signed-off-by: Mike Holmes <mike.holmes@linaro.org> > --- > platform/linux-generic/include/odp_buffer_internal.h | 9 --------- > platform/linux-generic/odp_buffer.c | 8 -------- > 2 files changed, 17 deletions(-) > > diff --git a/platform/linux-generic/include/odp_buffer_internal.h > b/platform/linux-generic/include/odp_buffer_internal.h > index ef116c3..a7638da 100644 > --- a/platform/linux-generic/include/odp_buffer_internal.h > +++ b/platform/linux-generic/include/odp_buffer_internal.h > @@ -168,15 +168,6 @@ odp_buffer_t buffer_alloc(odp_pool_t pool, size_t > size); > */ > int _odp_buffer_type(odp_buffer_t buf); > > -/* > - * Buffer type set > - * > - * @param buf Buffer handle > - * @param type New type value > - * > - */ > - void _odp_buffer_type_set(odp_buffer_t buf, int type); > - > #ifdef __cplusplus > } > #endif > diff --git a/platform/linux-generic/odp_buffer.c > b/platform/linux-generic/odp_buffer.c > index 0803805..d5d42a6 100644 > --- a/platform/linux-generic/odp_buffer.c > +++ b/platform/linux-generic/odp_buffer.c > @@ -47,14 +47,6 @@ int _odp_buffer_type(odp_buffer_t buf) > return hdr->type; > } > > -void _odp_buffer_type_set(odp_buffer_t buf, int type) > -{ > - odp_buffer_hdr_t *hdr = odp_buf_to_hdr(buf); > - > - hdr->type = type; > -} > - > - > int odp_buffer_is_valid(odp_buffer_t buf) > { > return validate_buf(buf) != NULL; > -- > 2.1.4 > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/lng-odp >
I will cherry-pick original patch from api-next to master. Maxim. On 07/22/15 17:46, Bill Fischofer wrote: > This is a duplicate of Patch > http://patches.opendataplane.org/patch/2215/ that I submitted on July > 10th. > > On Wed, Jul 22, 2015 at 9:35 AM, Mike Holmes <mike.holmes@linaro.org > <mailto:mike.holmes@linaro.org>> wrote: > > Signed-off-by: Mike Holmes <mike.holmes@linaro.org > <mailto:mike.holmes@linaro.org>> > --- > platform/linux-generic/include/odp_buffer_internal.h | 9 --------- > platform/linux-generic/odp_buffer.c | 8 -------- > 2 files changed, 17 deletions(-) > > diff --git a/platform/linux-generic/include/odp_buffer_internal.h > b/platform/linux-generic/include/odp_buffer_internal.h > index ef116c3..a7638da 100644 > --- a/platform/linux-generic/include/odp_buffer_internal.h > +++ b/platform/linux-generic/include/odp_buffer_internal.h > @@ -168,15 +168,6 @@ odp_buffer_t buffer_alloc(odp_pool_t pool, > size_t size); > */ > int _odp_buffer_type(odp_buffer_t buf); > > -/* > - * Buffer type set > - * > - * @param buf Buffer handle > - * @param type New type value > - * > - */ > - void _odp_buffer_type_set(odp_buffer_t buf, int type); > - > #ifdef __cplusplus > } > #endif > diff --git a/platform/linux-generic/odp_buffer.c > b/platform/linux-generic/odp_buffer.c > index 0803805..d5d42a6 100644 > --- a/platform/linux-generic/odp_buffer.c > +++ b/platform/linux-generic/odp_buffer.c > @@ -47,14 +47,6 @@ int _odp_buffer_type(odp_buffer_t buf) > return hdr->type; > } > > -void _odp_buffer_type_set(odp_buffer_t buf, int type) > -{ > - odp_buffer_hdr_t *hdr = odp_buf_to_hdr(buf); > - > - hdr->type = type; > -} > - > - > int odp_buffer_is_valid(odp_buffer_t buf) > { > return validate_buf(buf) != NULL; > -- > 2.1.4 > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org> > https://lists.linaro.org/mailman/listinfo/lng-odp > > > > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/lng-odp
ping On 22 July 2015 at 10:49, Maxim Uvarov <maxim.uvarov@linaro.org> wrote: > I will cherry-pick original patch from api-next to master. > > Maxim. > > On 07/22/15 17:46, Bill Fischofer wrote: > >> This is a duplicate of Patch http://patches.opendataplane.org/patch/2215/ >> that I submitted on July 10th. >> >> On Wed, Jul 22, 2015 at 9:35 AM, Mike Holmes <mike.holmes@linaro.org >> <mailto:mike.holmes@linaro.org>> wrote: >> >> Signed-off-by: Mike Holmes <mike.holmes@linaro.org >> <mailto:mike.holmes@linaro.org>> >> >> --- >> platform/linux-generic/include/odp_buffer_internal.h | 9 --------- >> platform/linux-generic/odp_buffer.c | 8 -------- >> 2 files changed, 17 deletions(-) >> >> diff --git a/platform/linux-generic/include/odp_buffer_internal.h >> b/platform/linux-generic/include/odp_buffer_internal.h >> index ef116c3..a7638da 100644 >> --- a/platform/linux-generic/include/odp_buffer_internal.h >> +++ b/platform/linux-generic/include/odp_buffer_internal.h >> @@ -168,15 +168,6 @@ odp_buffer_t buffer_alloc(odp_pool_t pool, >> size_t size); >> */ >> int _odp_buffer_type(odp_buffer_t buf); >> >> -/* >> - * Buffer type set >> - * >> - * @param buf Buffer handle >> - * @param type New type value >> - * >> - */ >> - void _odp_buffer_type_set(odp_buffer_t buf, int type); >> - >> #ifdef __cplusplus >> } >> #endif >> diff --git a/platform/linux-generic/odp_buffer.c >> b/platform/linux-generic/odp_buffer.c >> index 0803805..d5d42a6 100644 >> --- a/platform/linux-generic/odp_buffer.c >> +++ b/platform/linux-generic/odp_buffer.c >> @@ -47,14 +47,6 @@ int _odp_buffer_type(odp_buffer_t buf) >> return hdr->type; >> } >> >> -void _odp_buffer_type_set(odp_buffer_t buf, int type) >> -{ >> - odp_buffer_hdr_t *hdr = odp_buf_to_hdr(buf); >> - >> - hdr->type = type; >> -} >> - >> - >> int odp_buffer_is_valid(odp_buffer_t buf) >> { >> return validate_buf(buf) != NULL; >> -- >> 2.1.4 >> >> _______________________________________________ >> lng-odp mailing list >> lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org> >> https://lists.linaro.org/mailman/listinfo/lng-odp >> >> >> >> >> _______________________________________________ >> lng-odp mailing list >> lng-odp@lists.linaro.org >> https://lists.linaro.org/mailman/listinfo/lng-odp >> > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/lng-odp > -- Mike Holmes Technical Manager - Linaro Networking Group Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs
That commit is for _odp_buffer_type_set but we need to remove _odp_buffer_type. Maxim. On 11/03/2015 17:46, Mike Holmes wrote: > ping > > On 22 July 2015 at 10:49, Maxim Uvarov <maxim.uvarov@linaro.org > <mailto:maxim.uvarov@linaro.org>> wrote: > > I will cherry-pick original patch from api-next to master. > > Maxim. > > On 07/22/15 17:46, Bill Fischofer wrote: > > This is a duplicate of Patch > http://patches.opendataplane.org/patch/2215/ that I submitted > on July 10th. > > On Wed, Jul 22, 2015 at 9:35 AM, Mike Holmes > <mike.holmes@linaro.org <mailto:mike.holmes@linaro.org> > <mailto:mike.holmes@linaro.org > <mailto:mike.holmes@linaro.org>>> wrote: > > Signed-off-by: Mike Holmes <mike.holmes@linaro.org > <mailto:mike.holmes@linaro.org> > <mailto:mike.holmes@linaro.org > <mailto:mike.holmes@linaro.org>>> > > --- > platform/linux-generic/include/odp_buffer_internal.h | 9 > --------- > platform/linux-generic/odp_buffer.c | 8 -------- > 2 files changed, 17 deletions(-) > > diff --git > a/platform/linux-generic/include/odp_buffer_internal.h > b/platform/linux-generic/include/odp_buffer_internal.h > index ef116c3..a7638da 100644 > --- a/platform/linux-generic/include/odp_buffer_internal.h > +++ b/platform/linux-generic/include/odp_buffer_internal.h > @@ -168,15 +168,6 @@ odp_buffer_t buffer_alloc(odp_pool_t > pool, > size_t size); > */ > int _odp_buffer_type(odp_buffer_t buf); > > -/* > - * Buffer type set > - * > - * @param buf Buffer handle > - * @param type New type value > - * > - */ > - void _odp_buffer_type_set(odp_buffer_t buf, int type); > - > #ifdef __cplusplus > } > #endif > diff --git a/platform/linux-generic/odp_buffer.c > b/platform/linux-generic/odp_buffer.c > index 0803805..d5d42a6 100644 > --- a/platform/linux-generic/odp_buffer.c > +++ b/platform/linux-generic/odp_buffer.c > @@ -47,14 +47,6 @@ int _odp_buffer_type(odp_buffer_t buf) > return hdr->type; > } > > -void _odp_buffer_type_set(odp_buffer_t buf, int type) > -{ > - odp_buffer_hdr_t *hdr = odp_buf_to_hdr(buf); > - > - hdr->type = type; > -} > - > - > int odp_buffer_is_valid(odp_buffer_t buf) > { > return validate_buf(buf) != NULL; > -- > 2.1.4 > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org> > <mailto:lng-odp@lists.linaro.org > <mailto:lng-odp@lists.linaro.org>> > https://lists.linaro.org/mailman/listinfo/lng-odp > > > > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org> > https://lists.linaro.org/mailman/listinfo/lng-odp > > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org> > https://lists.linaro.org/mailman/listinfo/lng-odp > > > > > -- > Mike Holmes > Technical Manager - Linaro Networking Group > Linaro.org <http://www.linaro.org/>***│ *Open source software for ARM SoCs >
Let me investigate and I'll post either a patch to do the delete or an explanation of why we shouldn't do that. On Tue, Nov 3, 2015 at 8:55 AM, Maxim Uvarov <maxim.uvarov@linaro.org> wrote: > That commit is for _odp_buffer_type_set but we need to remove > _odp_buffer_type. > > Maxim. > > On 11/03/2015 17:46, Mike Holmes wrote: > >> ping >> >> On 22 July 2015 at 10:49, Maxim Uvarov <maxim.uvarov@linaro.org <mailto: >> maxim.uvarov@linaro.org>> wrote: >> >> I will cherry-pick original patch from api-next to master. >> >> Maxim. >> >> On 07/22/15 17:46, Bill Fischofer wrote: >> >> This is a duplicate of Patch >> http://patches.opendataplane.org/patch/2215/ that I submitted >> on July 10th. >> >> On Wed, Jul 22, 2015 at 9:35 AM, Mike Holmes >> <mike.holmes@linaro.org <mailto:mike.holmes@linaro.org> >> <mailto:mike.holmes@linaro.org >> <mailto:mike.holmes@linaro.org>>> wrote: >> >> Signed-off-by: Mike Holmes <mike.holmes@linaro.org >> <mailto:mike.holmes@linaro.org> >> <mailto:mike.holmes@linaro.org >> >> <mailto:mike.holmes@linaro.org>>> >> >> --- >> platform/linux-generic/include/odp_buffer_internal.h | 9 >> --------- >> platform/linux-generic/odp_buffer.c | 8 -------- >> 2 files changed, 17 deletions(-) >> >> diff --git >> a/platform/linux-generic/include/odp_buffer_internal.h >> b/platform/linux-generic/include/odp_buffer_internal.h >> index ef116c3..a7638da 100644 >> --- a/platform/linux-generic/include/odp_buffer_internal.h >> +++ b/platform/linux-generic/include/odp_buffer_internal.h >> @@ -168,15 +168,6 @@ odp_buffer_t buffer_alloc(odp_pool_t >> pool, >> size_t size); >> */ >> int _odp_buffer_type(odp_buffer_t buf); >> >> -/* >> - * Buffer type set >> - * >> - * @param buf Buffer handle >> - * @param type New type value >> - * >> - */ >> - void _odp_buffer_type_set(odp_buffer_t buf, int type); >> - >> #ifdef __cplusplus >> } >> #endif >> diff --git a/platform/linux-generic/odp_buffer.c >> b/platform/linux-generic/odp_buffer.c >> index 0803805..d5d42a6 100644 >> --- a/platform/linux-generic/odp_buffer.c >> +++ b/platform/linux-generic/odp_buffer.c >> @@ -47,14 +47,6 @@ int _odp_buffer_type(odp_buffer_t buf) >> return hdr->type; >> } >> >> -void _odp_buffer_type_set(odp_buffer_t buf, int type) >> -{ >> - odp_buffer_hdr_t *hdr = odp_buf_to_hdr(buf); >> - >> - hdr->type = type; >> -} >> - >> - >> int odp_buffer_is_valid(odp_buffer_t buf) >> { >> return validate_buf(buf) != NULL; >> -- >> 2.1.4 >> >> _______________________________________________ >> lng-odp mailing list >> lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org> >> <mailto:lng-odp@lists.linaro.org >> <mailto:lng-odp@lists.linaro.org>> >> https://lists.linaro.org/mailman/listinfo/lng-odp >> >> >> >> >> _______________________________________________ >> lng-odp mailing list >> lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org> >> https://lists.linaro.org/mailman/listinfo/lng-odp >> >> >> _______________________________________________ >> lng-odp mailing list >> lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org> >> https://lists.linaro.org/mailman/listinfo/lng-odp >> >> >> >> >> -- >> Mike Holmes >> Technical Manager - Linaro Networking Group >> Linaro.org <http://www.linaro.org/>***│ *Open source software for ARM >> SoCs >> >> > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/lng-odp >
Ok, turns out that at the time the set function was removed odp_timer.c was still using this function, which is why it wasn't removed as part of that patch. Since then odp_timer.c has been changed to use official odp_event_type() API, so this function is no longer used anywhere. Patch submitted to remove this one as well. On Tue, Nov 3, 2015 at 11:19 AM, Bill Fischofer <bill.fischofer@linaro.org> wrote: > Let me investigate and I'll post either a patch to do the delete or an > explanation of why we shouldn't do that. > > On Tue, Nov 3, 2015 at 8:55 AM, Maxim Uvarov <maxim.uvarov@linaro.org> > wrote: > >> That commit is for _odp_buffer_type_set but we need to remove >> _odp_buffer_type. >> >> Maxim. >> >> On 11/03/2015 17:46, Mike Holmes wrote: >> >>> ping >>> >>> On 22 July 2015 at 10:49, Maxim Uvarov <maxim.uvarov@linaro.org <mailto: >>> maxim.uvarov@linaro.org>> wrote: >>> >>> I will cherry-pick original patch from api-next to master. >>> >>> Maxim. >>> >>> On 07/22/15 17:46, Bill Fischofer wrote: >>> >>> This is a duplicate of Patch >>> http://patches.opendataplane.org/patch/2215/ that I submitted >>> on July 10th. >>> >>> On Wed, Jul 22, 2015 at 9:35 AM, Mike Holmes >>> <mike.holmes@linaro.org <mailto:mike.holmes@linaro.org> >>> <mailto:mike.holmes@linaro.org >>> <mailto:mike.holmes@linaro.org>>> wrote: >>> >>> Signed-off-by: Mike Holmes <mike.holmes@linaro.org >>> <mailto:mike.holmes@linaro.org> >>> <mailto:mike.holmes@linaro.org >>> >>> <mailto:mike.holmes@linaro.org>>> >>> >>> --- >>> platform/linux-generic/include/odp_buffer_internal.h | 9 >>> --------- >>> platform/linux-generic/odp_buffer.c | 8 -------- >>> 2 files changed, 17 deletions(-) >>> >>> diff --git >>> a/platform/linux-generic/include/odp_buffer_internal.h >>> b/platform/linux-generic/include/odp_buffer_internal.h >>> index ef116c3..a7638da 100644 >>> --- a/platform/linux-generic/include/odp_buffer_internal.h >>> +++ b/platform/linux-generic/include/odp_buffer_internal.h >>> @@ -168,15 +168,6 @@ odp_buffer_t buffer_alloc(odp_pool_t >>> pool, >>> size_t size); >>> */ >>> int _odp_buffer_type(odp_buffer_t buf); >>> >>> -/* >>> - * Buffer type set >>> - * >>> - * @param buf Buffer handle >>> - * @param type New type value >>> - * >>> - */ >>> - void _odp_buffer_type_set(odp_buffer_t buf, int >>> type); >>> - >>> #ifdef __cplusplus >>> } >>> #endif >>> diff --git a/platform/linux-generic/odp_buffer.c >>> b/platform/linux-generic/odp_buffer.c >>> index 0803805..d5d42a6 100644 >>> --- a/platform/linux-generic/odp_buffer.c >>> +++ b/platform/linux-generic/odp_buffer.c >>> @@ -47,14 +47,6 @@ int _odp_buffer_type(odp_buffer_t buf) >>> return hdr->type; >>> } >>> >>> -void _odp_buffer_type_set(odp_buffer_t buf, int type) >>> -{ >>> - odp_buffer_hdr_t *hdr = odp_buf_to_hdr(buf); >>> - >>> - hdr->type = type; >>> -} >>> - >>> - >>> int odp_buffer_is_valid(odp_buffer_t buf) >>> { >>> return validate_buf(buf) != NULL; >>> -- >>> 2.1.4 >>> >>> _______________________________________________ >>> lng-odp mailing list >>> lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org> >>> <mailto:lng-odp@lists.linaro.org >>> <mailto:lng-odp@lists.linaro.org>> >>> https://lists.linaro.org/mailman/listinfo/lng-odp >>> >>> >>> >>> >>> _______________________________________________ >>> lng-odp mailing list >>> lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org> >>> https://lists.linaro.org/mailman/listinfo/lng-odp >>> >>> >>> _______________________________________________ >>> lng-odp mailing list >>> lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org> >>> https://lists.linaro.org/mailman/listinfo/lng-odp >>> >>> >>> >>> >>> -- >>> Mike Holmes >>> Technical Manager - Linaro Networking Group >>> Linaro.org <http://www.linaro.org/>***│ *Open source software for ARM >>> SoCs >>> >>> >> _______________________________________________ >> lng-odp mailing list >> lng-odp@lists.linaro.org >> https://lists.linaro.org/mailman/listinfo/lng-odp >> > >
diff --git a/platform/linux-generic/include/odp_buffer_internal.h b/platform/linux-generic/include/odp_buffer_internal.h index ef116c3..a7638da 100644 --- a/platform/linux-generic/include/odp_buffer_internal.h +++ b/platform/linux-generic/include/odp_buffer_internal.h @@ -168,15 +168,6 @@ odp_buffer_t buffer_alloc(odp_pool_t pool, size_t size); */ int _odp_buffer_type(odp_buffer_t buf); -/* - * Buffer type set - * - * @param buf Buffer handle - * @param type New type value - * - */ - void _odp_buffer_type_set(odp_buffer_t buf, int type); - #ifdef __cplusplus } #endif diff --git a/platform/linux-generic/odp_buffer.c b/platform/linux-generic/odp_buffer.c index 0803805..d5d42a6 100644 --- a/platform/linux-generic/odp_buffer.c +++ b/platform/linux-generic/odp_buffer.c @@ -47,14 +47,6 @@ int _odp_buffer_type(odp_buffer_t buf) return hdr->type; } -void _odp_buffer_type_set(odp_buffer_t buf, int type) -{ - odp_buffer_hdr_t *hdr = odp_buf_to_hdr(buf); - - hdr->type = type; -} - - int odp_buffer_is_valid(odp_buffer_t buf) { return validate_buf(buf) != NULL;
Signed-off-by: Mike Holmes <mike.holmes@linaro.org> --- platform/linux-generic/include/odp_buffer_internal.h | 9 --------- platform/linux-generic/odp_buffer.c | 8 -------- 2 files changed, 17 deletions(-)