[v2,1/5] clk: qcom: Enable gpll0_vote rate propagation on MSM8916

Message ID 1437757119-6910-2-git-send-email-georgi.djakov@linaro.org
State New
Headers show

Commit Message

Georgi Djakov July 24, 2015, 4:58 p.m.
Currently we are missing the SET_RATE_PARENT flag on gpll0_vote and
as a result of that, when it has a child with SET_RATE_PARENT flag,
the rate of the child is not propagated up to the gpll0. Fix that
by adding the SET_RATE_PARENT flag to gpll0_vote.

Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
---
 drivers/clk/qcom/gcc-msm8916.c |    1 +
 1 file changed, 1 insertion(+)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Comments

Georgi Djakov July 25, 2015, 2:12 a.m. | #1
On 24.07.15 20:25, Stephen Boyd wrote:
> On 07/24/2015 09:58 AM, Georgi Djakov wrote:
>> Currently we are missing the SET_RATE_PARENT flag on gpll0_vote and
>> as a result of that, when it has a child with SET_RATE_PARENT flag,
>> the rate of the child is not propagated up to the gpll0. Fix that
>> by adding the SET_RATE_PARENT flag to gpll0_vote.
>>
>> Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
> 
> This doesn't make any sense. GPLL0 doesn't change rate, so having the flag here on the GPLL0 vote clock doesn't help anything.
> 

Right, gpll0 has a fixed rate. Sorry for the confusion.
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/clk/qcom/gcc-msm8916.c b/drivers/clk/qcom/gcc-msm8916.c
index 28ef2c771157..3019e89cdfa8 100644
--- a/drivers/clk/qcom/gcc-msm8916.c
+++ b/drivers/clk/qcom/gcc-msm8916.c
@@ -216,6 +216,7 @@  static struct clk_regmap gpll0_vote = {
 		.parent_names = (const char *[]){ "gpll0" },
 		.num_parents = 1,
 		.ops = &clk_pll_vote_ops,
+		.flags = CLK_SET_RATE_PARENT,
 	},
 };