diff mbox series

input: ariel-pwrbutton: Add SPI device ID table

Message ID 20210927134104.38648-1-broonie@kernel.org
State New
Headers show
Series input: ariel-pwrbutton: Add SPI device ID table | expand

Commit Message

Mark Brown Sept. 27, 2021, 1:41 p.m. UTC
Currently autoloading for SPI devices does not use the DT ID table, it uses
SPI modalises. Supporting OF modalises is going to be difficult if not
impractical, an attempt was made but has been reverted, so ensure that
module autoloading works for this driver by adding a SPI device ID table.

Fixes: 96c8395e2166 ("spi: Revert modalias changes")
Signed-off-by: Mark Brown <broonie@kernel.org>

---
 drivers/input/misc/ariel-pwrbutton.c | 7 +++++++
 1 file changed, 7 insertions(+)

-- 
2.20.1

Comments

Dmitry Torokhov Oct. 2, 2021, 4:21 a.m. UTC | #1
On Mon, Sep 27, 2021 at 02:41:04PM +0100, Mark Brown wrote:
> Currently autoloading for SPI devices does not use the DT ID table, it uses

> SPI modalises. Supporting OF modalises is going to be difficult if not

> impractical, an attempt was made but has been reverted, so ensure that

> module autoloading works for this driver by adding a SPI device ID table.

> 

> Fixes: 96c8395e2166 ("spi: Revert modalias changes")

> Signed-off-by: Mark Brown <broonie@kernel.org>


Applied, thank you.

-- 
Dmitry
diff mbox series

Patch

diff --git a/drivers/input/misc/ariel-pwrbutton.c b/drivers/input/misc/ariel-pwrbutton.c
index 17bbaac8b80c..cdc80715b5fd 100644
--- a/drivers/input/misc/ariel-pwrbutton.c
+++ b/drivers/input/misc/ariel-pwrbutton.c
@@ -149,12 +149,19 @@  static const struct of_device_id ariel_pwrbutton_of_match[] = {
 };
 MODULE_DEVICE_TABLE(of, ariel_pwrbutton_of_match);
 
+static const struct spi_device_id ariel_pwrbutton_spi_ids[] = {
+	{ .name = "wyse-ariel-ec-input" },
+	{ }
+};
+MODULE_DEVICE_TABLE(spi, ariel_pwrbutton_spi_ids);
+
 static struct spi_driver ariel_pwrbutton_driver = {
 	.driver = {
 		.name = "dell-wyse-ariel-ec-input",
 		.of_match_table = ariel_pwrbutton_of_match,
 	},
 	.probe = ariel_pwrbutton_probe,
+	.id_table = ariel_pwrbutton_spi_ids,
 };
 module_spi_driver(ariel_pwrbutton_driver);