diff mbox series

[5.14,075/162] kselftest/arm64: signal: Add SVE to the set of features we can check for

Message ID 20210927170236.052759270@linuxfoundation.org
State New
Headers show
Series None | expand

Commit Message

Greg Kroah-Hartman Sept. 27, 2021, 5:02 p.m. UTC 
From: Mark Brown <broonie@kernel.org>


[ Upstream commit d4e4dc4fab686c5f3f185272a19b83930664bef5 ]

Allow testcases for SVE signal handling to flag the dependency and be
skipped on systems without SVE support.

Signed-off-by: Mark Brown <broonie@kernel.org>

Link: https://lore.kernel.org/r/20210819134245.13935-2-broonie@kernel.org
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>

Signed-off-by: Sasha Levin <sashal@kernel.org>

---
 tools/testing/selftests/arm64/signal/test_signals.h       | 2 ++
 tools/testing/selftests/arm64/signal/test_signals_utils.c | 3 +++
 2 files changed, 5 insertions(+)

-- 
2.33.0

Comments

Mark Brown Sept. 27, 2021, 5:16 p.m. UTC | #1 
On Mon, Sep 27, 2021 at 07:02:01PM +0200, Greg Kroah-Hartman wrote:
> From: Mark Brown <broonie@kernel.org>

> 

> [ Upstream commit d4e4dc4fab686c5f3f185272a19b83930664bef5 ]

> 

> Allow testcases for SVE signal handling to flag the dependency and be

> skipped on systems without SVE support.


Unless you're backporting some test that makes use of this I'm not sure
why this is stable material?
Sasha Levin Sept. 28, 2021, 4:47 a.m. UTC | #2 
On Mon, Sep 27, 2021 at 06:16:02PM +0100, Mark Brown wrote:
>On Mon, Sep 27, 2021 at 07:02:01PM +0200, Greg Kroah-Hartman wrote:

>> From: Mark Brown <broonie@kernel.org>

>>

>> [ Upstream commit d4e4dc4fab686c5f3f185272a19b83930664bef5 ]

>>

>> Allow testcases for SVE signal handling to flag the dependency and be

>> skipped on systems without SVE support.

>

>Unless you're backporting some test that makes use of this I'm not sure

>why this is stable material?


The patch right after this one wanted it :)

-- 
Thanks,
Sasha
diff mbox series

Patch

diff --git a/tools/testing/selftests/arm64/signal/test_signals.h b/tools/testing/selftests/arm64/signal/test_signals.h
index f96baf1cef1a..ebe8694dbef0 100644
--- a/tools/testing/selftests/arm64/signal/test_signals.h
+++ b/tools/testing/selftests/arm64/signal/test_signals.h
@@ -33,10 +33,12 @@ 
  */
 enum {
 	FSSBS_BIT,
+	FSVE_BIT,
 	FMAX_END
 };
 
 #define FEAT_SSBS		(1UL << FSSBS_BIT)
+#define FEAT_SVE		(1UL << FSVE_BIT)
 
 /*
  * A descriptor used to describe and configure a test case.
diff --git a/tools/testing/selftests/arm64/signal/test_signals_utils.c b/tools/testing/selftests/arm64/signal/test_signals_utils.c
index 2de6e5ed5e25..6836510a522f 100644
--- a/tools/testing/selftests/arm64/signal/test_signals_utils.c
+++ b/tools/testing/selftests/arm64/signal/test_signals_utils.c
@@ -26,6 +26,7 @@  static int sig_copyctx = SIGTRAP;
 
 static char const *const feats_names[FMAX_END] = {
 	" SSBS ",
+	" SVE ",
 };
 
 #define MAX_FEATS_SZ	128
@@ -263,6 +264,8 @@  int test_init(struct tdescr *td)
 		 */
 		if (getauxval(AT_HWCAP) & HWCAP_SSBS)
 			td->feats_supported |= FEAT_SSBS;
+		if (getauxval(AT_HWCAP) & HWCAP_SVE)
+			td->feats_supported |= FEAT_SVE;
 		if (feats_ok(td))
 			fprintf(stderr,
 				"Required Features: [%s] supported\n",