| Message ID | 20211104141451.29967-2-etienne.carriere@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/5] tee: define session login identifiers | expand |
Hi, On 11/4/21 3:14 PM, Etienne Carriere wrote: > Remove unused OPTEE_MSG_LOGIN_* ID macros as suitable TEE_LOGIN_* ID > macros are already defined tee.h. > > Cc: Jens Wiklander <jens.wiklander@linaro.org> > Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org> > --- > This change was previously discussed in the U-Boot ML, latest is > "[PATCH v2 2/2] tee: optee: support session login as REE kernel", at: > https://patchwork.ozlabs.org/project/uboot/patch/20210519142613.7668-2-etienne.carriere@linaro.org/ > > Changes since this v2 post: > - Remove sanitation of the login Id passed to OP-TEE as secure world > - Rephrase header line since this change now simply remove duplicated > macros. > - Update OPTEE_MSG_CMD_OPEN_SESSION inline description comment with > a reference to TEE_LOGIN_* macros. > --- > drivers/tee/optee/optee_msg.h | 12 +----------- > 1 file changed, 1 insertion(+), 11 deletions(-) > Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com> Thanks Patrick
On Thu, Nov 4, 2021 at 3:15 PM Etienne Carriere <etienne.carriere@linaro.org> wrote: > > Remove unused OPTEE_MSG_LOGIN_* ID macros as suitable TEE_LOGIN_* ID > macros are already defined tee.h. > > Cc: Jens Wiklander <jens.wiklander@linaro.org> > Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org> > --- > This change was previously discussed in the U-Boot ML, latest is > "[PATCH v2 2/2] tee: optee: support session login as REE kernel", at: > https://patchwork.ozlabs.org/project/uboot/patch/20210519142613.7668-2-etienne.carriere@linaro.org/ > > Changes since this v2 post: > - Remove sanitation of the login Id passed to OP-TEE as secure world > - Rephrase header line since this change now simply remove duplicated > macros. > - Update OPTEE_MSG_CMD_OPEN_SESSION inline description comment with > a reference to TEE_LOGIN_* macros. > --- > drivers/tee/optee/optee_msg.h | 12 +----------- > 1 file changed, 1 insertion(+), 11 deletions(-) Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org> Thanks, Jens
diff --git a/drivers/tee/optee/optee_msg.h b/drivers/tee/optee/optee_msg.h index 8d40ce60c2..a8ef926a48 100644 --- a/drivers/tee/optee/optee_msg.h +++ b/drivers/tee/optee/optee_msg.h @@ -86,16 +86,6 @@ #define OPTEE_MSG_ATTR_CACHE_MASK GENMASK(2, 0) #define OPTEE_MSG_ATTR_CACHE_PREDEFINED 0 -/* - * Same values as TEE_LOGIN_* from TEE Internal API - */ -#define OPTEE_MSG_LOGIN_PUBLIC 0x00000000 -#define OPTEE_MSG_LOGIN_USER 0x00000001 -#define OPTEE_MSG_LOGIN_GROUP 0x00000002 -#define OPTEE_MSG_LOGIN_APPLICATION 0x00000004 -#define OPTEE_MSG_LOGIN_APPLICATION_USER 0x00000005 -#define OPTEE_MSG_LOGIN_APPLICATION_GROUP 0x00000006 - /* * Page size used in non-contiguous buffer entries */ @@ -279,7 +269,7 @@ struct optee_msg_arg { * parameters to pass the following information: * param[0].u.value.a-b uuid of Trusted Application * param[1].u.value.a-b uuid of Client - * param[1].u.value.c Login class of client OPTEE_MSG_LOGIN_* + * param[1].u.value.c Login class of client TEE_LOGIN_* * * OPTEE_MSG_CMD_INVOKE_COMMAND invokes a command a previously opened * session to a Trusted Application. struct optee_msg_arg::func is Trusted
Remove unused OPTEE_MSG_LOGIN_* ID macros as suitable TEE_LOGIN_* ID macros are already defined tee.h. Cc: Jens Wiklander <jens.wiklander@linaro.org> Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org> --- This change was previously discussed in the U-Boot ML, latest is "[PATCH v2 2/2] tee: optee: support session login as REE kernel", at: https://patchwork.ozlabs.org/project/uboot/patch/20210519142613.7668-2-etienne.carriere@linaro.org/ Changes since this v2 post: - Remove sanitation of the login Id passed to OP-TEE as secure world - Rephrase header line since this change now simply remove duplicated macros. - Update OPTEE_MSG_CMD_OPEN_SESSION inline description comment with a reference to TEE_LOGIN_* macros. --- drivers/tee/optee/optee_msg.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) -- 2.17.1