| Message ID | 20211123083617.2366756-1-weiyongjun1@huawei.com |
|---|---|
| State | New |
| Headers | show |
| Series | [-next] pinctrl: samsung: Make symbol 'exynos7885_pin_ctrl' static | expand |
On Tue, 23 Nov 2021 08:36:17 +0000, Wei Yongjun wrote: > The sparse tool complains as follows: > > drivers/pinctrl/samsung/pinctrl-exynos-arm64.c:490:31: warning: > symbol 'exynos7885_pin_ctrl' was not declared. Should it be static? > > This symbol is not used outside of pinctrl-exynos-arm64.c, so marks > it static. > > [...] Applied, thanks! [1/1] pinctrl: samsung: Make symbol 'exynos7885_pin_ctrl' static commit: 16dd3bb5c190654854c0846ee433076139f71c6a Best regards,
diff --git a/drivers/pinctrl/samsung/pinctrl-exynos-arm64.c b/drivers/pinctrl/samsung/pinctrl-exynos-arm64.c index b174796081ef..2e490e7696f4 100644 --- a/drivers/pinctrl/samsung/pinctrl-exynos-arm64.c +++ b/drivers/pinctrl/samsung/pinctrl-exynos-arm64.c @@ -487,7 +487,7 @@ static const struct samsung_pin_bank_data exynos7885_pin_banks3[] __initconst = EXYNOS850_PIN_BANK_EINTG(8, 0x200, "gpc2", 0x40), }; -const struct samsung_pin_ctrl exynos7885_pin_ctrl[] __initconst = { +static const struct samsung_pin_ctrl exynos7885_pin_ctrl[] __initconst = { { /* pin-controller instance 0 Alive data */ .pin_banks = exynos7885_pin_banks0,
The sparse tool complains as follows: drivers/pinctrl/samsung/pinctrl-exynos-arm64.c:490:31: warning: symbol 'exynos7885_pin_ctrl' was not declared. Should it be static? This symbol is not used outside of pinctrl-exynos-arm64.c, so marks it static. Fixes: b0ef7b1a7a07 ("pinctrl: samsung: Add Exynos7885 SoC specific data") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> --- drivers/pinctrl/samsung/pinctrl-exynos-arm64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)