diff mbox series

[5/5] firmware: scmi: smccc transport: simplify probe sequence

Message ID 20211108075611.30759-5-etienne.carriere@linaro.org
State Accepted
Commit 32190a959de4c9467008249d0e9fb4b425332a5c
Headers show
Series [1/5] firmware: scmi: fix description of an API function | expand

Commit Message

Etienne Carriere Nov. 8, 2021, 7:56 a.m. UTC
Minor simplification in scmi_smccc_probe() exit sequence.

Cc: Simon Glass <sjg@chromium.org>
Cc: Patrice Chotard <patrice.chotard@foss.st.com>
Cc: Patrick Delaunay <patrick.delaunay@foss.st.com>
Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
---
Changes since v1:
 - No change. Patch re-send.
---
 drivers/firmware/scmi/smccc_agent.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Comments

Patrick Delaunay Nov. 8, 2021, 10 a.m. UTC | #1
Hi,

On 11/8/21 8:56 AM, Etienne Carriere wrote:
> Minor simplification in scmi_smccc_probe() exit sequence.
>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Patrice Chotard <patrice.chotard@foss.st.com>
> Cc: Patrick Delaunay <patrick.delaunay@foss.st.com>
> Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
> ---
> Changes since v1:
>   - No change. Patch re-send.
> ---
>   drivers/firmware/scmi/smccc_agent.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
>



Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>

Thanks
Patrick
diff mbox series

Patch

diff --git a/drivers/firmware/scmi/smccc_agent.c b/drivers/firmware/scmi/smccc_agent.c
index f0477b91dc..5e166ca93e 100644
--- a/drivers/firmware/scmi/smccc_agent.c
+++ b/drivers/firmware/scmi/smccc_agent.c
@@ -65,12 +65,10 @@  static int scmi_smccc_of_to_plat(struct udevice *dev)
 	chan->func_id = func_id;
 
 	ret = scmi_dt_get_smt_buffer(dev, &chan->smt);
-	if (ret) {
+	if (ret)
 		dev_err(dev, "Failed to get smt resources: %d\n", ret);
-		return ret;
-	}
 
-	return 0;
+	return ret;
 }
 
 static const struct udevice_id scmi_smccc_ids[] = {