| Message ID | 20211116043238.67226-3-takahiro.akashi@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | efi_loader: capsule: improve capsule authentication support | expand |
On 11/16/21 05:32, AKASHI Takahiro wrote: > We want to always build mkeficapsule if tools-only_defconfig is used. > > Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org> Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > --- > configs/tools-only_defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/configs/tools-only_defconfig b/configs/tools-only_defconfig > index f482c9a1c1b0..5427797dd4c3 100644 > --- a/configs/tools-only_defconfig > +++ b/configs/tools-only_defconfig > @@ -31,3 +31,4 @@ CONFIG_I2C_EDID=y > # CONFIG_VIRTIO_MMIO is not set > # CONFIG_VIRTIO_PCI is not set > # CONFIG_VIRTIO_SANDBOX is not set > +CONFIG_TOOLS_MKEFICAPSULE=y >
On 11/16/21 13:20, Heinrich Schuchardt wrote: > On 11/16/21 05:32, AKASHI Takahiro wrote: >> We want to always build mkeficapsule if tools-only_defconfig is used. >> >> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org> > > Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > >> --- >> configs/tools-only_defconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/configs/tools-only_defconfig b/configs/tools-only_defconfig >> index f482c9a1c1b0..5427797dd4c3 100644 >> --- a/configs/tools-only_defconfig >> +++ b/configs/tools-only_defconfig >> @@ -31,3 +31,4 @@ CONFIG_I2C_EDID=y >> # CONFIG_VIRTIO_MMIO is not set >> # CONFIG_VIRTIO_PCI is not set >> # CONFIG_VIRTIO_SANDBOX is not set >> +CONFIG_TOOLS_MKEFICAPSULE=y >> > You cannot use a symbol that is not yet defined. Please, swap patches 2 and 3 when resubmitting. Best regards Heinrich
On Tue, Nov 16, 2021 at 02:58:39PM +0100, Heinrich Schuchardt wrote: > On 11/16/21 13:20, Heinrich Schuchardt wrote: > > On 11/16/21 05:32, AKASHI Takahiro wrote: > > > We want to always build mkeficapsule if tools-only_defconfig is used. > > > > > > Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org> > > > > Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > > > > > --- > > > configs/tools-only_defconfig | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/configs/tools-only_defconfig b/configs/tools-only_defconfig > > > index f482c9a1c1b0..5427797dd4c3 100644 > > > --- a/configs/tools-only_defconfig > > > +++ b/configs/tools-only_defconfig > > > @@ -31,3 +31,4 @@ CONFIG_I2C_EDID=y > > > # CONFIG_VIRTIO_MMIO is not set > > > # CONFIG_VIRTIO_PCI is not set > > > # CONFIG_VIRTIO_SANDBOX is not set > > > +CONFIG_TOOLS_MKEFICAPSULE=y > > > > > > You cannot use a symbol that is not yet defined. Please, swap patches 2 > and 3 when resubmitting. Instead of swapping, I will move the definition of TOOLS_MKEFICAPSULE from patch#3 to patch#2. That would clarify the intension. -Takahiro Akashi > Best regards > > Heinrich >
diff --git a/configs/tools-only_defconfig b/configs/tools-only_defconfig index f482c9a1c1b0..5427797dd4c3 100644 --- a/configs/tools-only_defconfig +++ b/configs/tools-only_defconfig @@ -31,3 +31,4 @@ CONFIG_I2C_EDID=y # CONFIG_VIRTIO_MMIO is not set # CONFIG_VIRTIO_PCI is not set # CONFIG_VIRTIO_SANDBOX is not set +CONFIG_TOOLS_MKEFICAPSULE=y
We want to always build mkeficapsule if tools-only_defconfig is used. Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org> --- configs/tools-only_defconfig | 1 + 1 file changed, 1 insertion(+)